You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
190 lines
5.8 KiB
190 lines
5.8 KiB
/**
|
|
* @author Toru Nagashima
|
|
* @copyright 2017 Toru Nagashima. All rights reserved.
|
|
* See LICENSE file in root directory for full license.
|
|
*/
|
|
'use strict'
|
|
|
|
const utils = require('../utils')
|
|
|
|
/**
|
|
* Check whether the given attribute is using the variables which are defined by `v-for` directives.
|
|
* @param {VDirective} vFor The attribute node of `v-for` to check.
|
|
* @param {VDirective} vBindKey The attribute node of `v-bind:key` to check.
|
|
* @returns {boolean} `true` if the node is using the variables which are defined by `v-for` directives.
|
|
*/
|
|
function isUsingIterationVar(vFor, vBindKey) {
|
|
if (vBindKey.value == null) {
|
|
return false
|
|
}
|
|
const references = vBindKey.value.references
|
|
const variables = vFor.parent.parent.variables
|
|
return references.some((reference) =>
|
|
variables.some(
|
|
(variable) =>
|
|
variable.id.name === reference.id.name && variable.kind === 'v-for'
|
|
)
|
|
)
|
|
}
|
|
|
|
/**
|
|
* Check the child element in tempalte v-for about `v-bind:key` attributes.
|
|
* @param {RuleContext} context The rule context to report.
|
|
* @param {VDirective} vFor The attribute node of `v-for` to check.
|
|
* @param {VElement} child The child node to check.
|
|
*/
|
|
function checkChildKey(context, vFor, child) {
|
|
const childFor = utils.getDirective(child, 'for')
|
|
// if child has v-for, check if parent iterator is used in v-for
|
|
if (childFor != null) {
|
|
const childForRefs = (childFor.value && childFor.value.references) || []
|
|
const variables = vFor.parent.parent.variables
|
|
const usedInFor = childForRefs.some((cref) =>
|
|
variables.some(
|
|
(variable) =>
|
|
cref.id.name === variable.id.name && variable.kind === 'v-for'
|
|
)
|
|
)
|
|
// if parent iterator is used, skip other checks
|
|
// iterator usage will be checked later by child v-for
|
|
if (usedInFor) {
|
|
return
|
|
}
|
|
}
|
|
// otherwise, check if parent iterator is directly used in child's key
|
|
checkKey(context, vFor, child)
|
|
}
|
|
|
|
/**
|
|
* Check the given element about `v-bind:key` attributes.
|
|
* @param {RuleContext} context The rule context to report.
|
|
* @param {VDirective} vFor The attribute node of `v-for` to check.
|
|
* @param {VElement} element The element node to check.
|
|
*/
|
|
function checkKey(context, vFor, element) {
|
|
const vBindKey = utils.getDirective(element, 'bind', 'key')
|
|
|
|
if (vBindKey == null && element.name === 'template') {
|
|
for (const child of element.children) {
|
|
if (child.type === 'VElement') {
|
|
checkChildKey(context, vFor, child)
|
|
}
|
|
}
|
|
return
|
|
}
|
|
|
|
if (utils.isCustomComponent(element) && vBindKey == null) {
|
|
context.report({
|
|
node: element.startTag,
|
|
messageId: 'requireKey'
|
|
})
|
|
}
|
|
if (vBindKey != null && !isUsingIterationVar(vFor, vBindKey)) {
|
|
context.report({
|
|
node: vBindKey,
|
|
messageId: 'keyUseFVorVars'
|
|
})
|
|
}
|
|
}
|
|
|
|
module.exports = {
|
|
meta: {
|
|
type: 'problem',
|
|
docs: {
|
|
description: 'enforce valid `v-for` directives',
|
|
categories: ['vue3-essential', 'vue2-essential'],
|
|
url: 'https://eslint.vuejs.org/rules/valid-v-for.html'
|
|
},
|
|
fixable: null,
|
|
schema: [],
|
|
messages: {
|
|
requireKey:
|
|
"Custom elements in iteration require 'v-bind:key' directives.",
|
|
keyUseFVorVars:
|
|
"Expected 'v-bind:key' directive to use the variables which are defined by the 'v-for' directive.",
|
|
unexpectedArgument: "'v-for' directives require no argument.",
|
|
unexpectedModifier: "'v-for' directives require no modifier.",
|
|
expectedValue: "'v-for' directives require that attribute value.",
|
|
unexpectedExpression:
|
|
"'v-for' directives require the special syntax '<alias> in <expression>'.",
|
|
invalidEmptyAlias: "Invalid alias ''.",
|
|
invalidAlias: "Invalid alias '{{text}}'."
|
|
}
|
|
},
|
|
/** @param {RuleContext} context */
|
|
create(context) {
|
|
const sourceCode = context.getSourceCode()
|
|
|
|
return utils.defineTemplateBodyVisitor(context, {
|
|
/** @param {VDirective} node */
|
|
"VAttribute[directive=true][key.name.name='for']"(node) {
|
|
const element = node.parent.parent
|
|
|
|
checkKey(context, node, element)
|
|
|
|
if (node.key.argument) {
|
|
context.report({
|
|
node: node.key.argument,
|
|
messageId: 'unexpectedArgument'
|
|
})
|
|
}
|
|
if (node.key.modifiers.length > 0) {
|
|
context.report({
|
|
node,
|
|
loc: {
|
|
start: node.key.modifiers[0].loc.start,
|
|
end: node.key.modifiers[node.key.modifiers.length - 1].loc.end
|
|
},
|
|
messageId: 'unexpectedModifier'
|
|
})
|
|
}
|
|
if (!node.value || utils.isEmptyValueDirective(node, context)) {
|
|
context.report({
|
|
node,
|
|
messageId: 'expectedValue'
|
|
})
|
|
return
|
|
}
|
|
|
|
const expr = node.value.expression
|
|
if (expr == null) {
|
|
return
|
|
}
|
|
if (expr.type !== 'VForExpression') {
|
|
context.report({
|
|
node: node.value,
|
|
messageId: 'unexpectedExpression'
|
|
})
|
|
return
|
|
}
|
|
|
|
const lhs = expr.left
|
|
const value = lhs[0]
|
|
const key = lhs[1]
|
|
const index = lhs[2]
|
|
|
|
if (value === null) {
|
|
context.report({
|
|
node: expr,
|
|
messageId: 'invalidEmptyAlias'
|
|
})
|
|
}
|
|
if (key !== undefined && (!key || key.type !== 'Identifier')) {
|
|
context.report({
|
|
node: key || expr,
|
|
messageId: 'invalidAlias',
|
|
data: { text: key ? sourceCode.getText(key) : '' }
|
|
})
|
|
}
|
|
if (index !== undefined && (!index || index.type !== 'Identifier')) {
|
|
context.report({
|
|
node: index || expr,
|
|
messageId: 'invalidAlias',
|
|
data: { text: index ? sourceCode.getText(index) : '' }
|
|
})
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|