From fcf32474b604915d2e1f7313bd42026f326260d9 Mon Sep 17 00:00:00 2001 From: huang Date: Fri, 8 Jul 2016 13:53:54 +0800 Subject: [PATCH 1/2] modified days and hours for nil data --- app/views/quality_analysis/_show.html.erb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/views/quality_analysis/_show.html.erb b/app/views/quality_analysis/_show.html.erb index 0b16a1adb..3adea5c72 100644 --- a/app/views/quality_analysis/_show.html.erb +++ b/app/views/quality_analysis/_show.html.erb @@ -45,11 +45,11 @@
技术债务 - <% if @complexity["msr"][8].nil? %> + <% if @complexity["msr"][8].nil? || @complexity["msr"][8]["frmt_val"] == "0" %> 0 <% else %> <%= /[0-9]*/.match(@complexity["msr"][8]["frmt_val"])[0] %>天 - <%= / [0-9]*/.match(@complexity["msr"][8]["frmt_val"]) %>小时 + <%= / [0-9]*/.match(@complexity["msr"][8]["frmt_val"]).nil? ? 0 : / [0-9]*/.match(@complexity["msr"][8]["frmt_val"]) %>小时 <% end %> 查看详情
From b22882aead320717750ef296cedfbcfd79333171 Mon Sep 17 00:00:00 2001 From: huang Date: Fri, 8 Jul 2016 14:22:20 +0800 Subject: [PATCH 2/2] some data for css --- app/controllers/quality_analysis_controller.rb | 2 +- app/views/quality_analysis/_show.html.erb | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/app/controllers/quality_analysis_controller.rb b/app/controllers/quality_analysis_controller.rb index c53e1939a..79bb733e8 100644 --- a/app/controllers/quality_analysis_controller.rb +++ b/app/controllers/quality_analysis_controller.rb @@ -74,7 +74,7 @@ class QualityAnalysisController < ApplicationController for i in 0..60 do sleep(30) @current_build_status = @client.job.get_current_build_status("#{job_name}") - if (@current_build_status != "not_run" || @current_build_status != "running") + if (@current_build_status == "success" || @current_build_status == "failure") break if i == 60 @build_console_result = false diff --git a/app/views/quality_analysis/_show.html.erb b/app/views/quality_analysis/_show.html.erb index 3adea5c72..2442299bd 100644 --- a/app/views/quality_analysis/_show.html.erb +++ b/app/views/quality_analysis/_show.html.erb @@ -14,13 +14,13 @@

质量等级

<%= @complexity["msr"][9].nil? ? "A" : @complexity["msr"][9]["frmt_val"] %> - borderRadius"><%= @complexity["msr"][9].blank? ? "很好" : sqale_rating_status(@complexity["msr"][9]["val"].to_i)[0] %>

+ borderRadius"><%= @complexity["msr"][9].blank? ? "很好" : sqale_rating_status(@complexity["msr"][9]["val"].to_i)[0] %>

复杂度

<%= @complexity["msr"][6].nil? ? 0 : @complexity["msr"][6]["val"] %> - borderRadius"><%= @complexity["msr"][6].nil? ? 0 : complexity_status(@complexity["msr"][6]["val"].to_i)[0] %>

+ borderRadius"><%= @complexity["msr"][6].nil? ? 0 : complexity_status(@complexity["msr"][6]["val"].to_i)[0] %>

@@ -28,13 +28,13 @@

代码重复度

<%= @complexity["msr"][7].nil? ? 0 : @complexity["msr"][7]["frmt_val"] %> - borderRadius"><%= @complexity["msr"][7].nil? ? 0 : duplicated_lines_density_status(@complexity["msr"][7]["val"].to_i)[0] %>

+ borderRadius"><%= @complexity["msr"][7].nil? ? 0 : duplicated_lines_density_status(@complexity["msr"][7]["val"].to_i)[0] %>

注释率

<%= @complexity["msr"][5].nil? ? 0 : @complexity["msr"][5]["frmt_val"] %> - borderRadius"><%= @complexity["msr"][5].nil? ? 0 : comment_lines_density_status(@complexity["msr"][5]["val"].to_i)[0] %>

+ borderRadius"><%= @complexity["msr"][5].nil? ? 0 : comment_lines_density_status(@complexity["msr"][5]["val"].to_i)[0] %>