From 2ff24841fdc9fff1ec1eb432d7969dd89621175f Mon Sep 17 00:00:00 2001 From: yanxd Date: Thu, 10 Jul 2014 10:12:16 +0800 Subject: [PATCH] optimization image check. --- public/javascripts/application.js | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/public/javascripts/application.js b/public/javascripts/application.js index 5952faf99..9bba6cbbd 100644 --- a/public/javascripts/application.js +++ b/public/javascripts/application.js @@ -625,15 +625,11 @@ $(document).ready(addFormObserversForDoubleSubmit); function img_thumbnails() { $('.thumbnails a').colorbox({rel:'nofollow'}); $('.attachments').find('a').each(function(index, element) { - if($(element).attr('href').indexOf('.jpg') > 0) { + var href_value = $(element).attr('href'); + if (/\.(jpg|png|gif|bmp)$/.test(href_value)) { $(element).colorbox({rel:'nofollow'}); } - if($(element).attr('href').indexOf('.png') > 0) { - $(element).colorbox({rel:'nofollow'}); - } - if($(element).attr('href').indexOf('.gif') > 0) { - $(element).colorbox({rel:'nofollow'}); - } - }) + + }); } $(document).ready(img_thumbnails);