diff --git a/app/controllers/notificationcomments_controller.rb b/app/controllers/notificationcomments_controller.rb index 78272aae1..e0c5adf72 100644 --- a/app/controllers/notificationcomments_controller.rb +++ b/app/controllers/notificationcomments_controller.rb @@ -6,7 +6,7 @@ class NotificationcommentsController < ApplicationController before_filter :authorize def create - raise Unauthorized unless @contestnotifications.commentable? + raise Unauthorized unless @contestnotifications.notificationcommentable? @notificaioncomment = Notificaioncomment.new @notificaioncomment.safe_attributes = params[:notificaioncomment] diff --git a/app/models/contestnotification.rb b/app/models/contestnotification.rb index a055d3000..cba9dfa0c 100644 --- a/app/models/contestnotification.rb +++ b/app/models/contestnotification.rb @@ -36,8 +36,8 @@ class Contestnotification < ActiveRecord::Base end # Returns true if the news can be commented by user - def commentable?(user=User.current) - user.allowed_to?(:comment_contestnotifications, contest) + def notificationcommentable?(user=User.current) + user.allowed_to?(:notificationcomment_contestnotifications, contest) end def recipients diff --git a/app/views/contestnotifications/_news.html.erb b/app/views/contestnotifications/_news.html.erb index 1621c5813..301a193d8 100644 --- a/app/views/contestnotifications/_news.html.erb +++ b/app/views/contestnotifications/_news.html.erb @@ -20,7 +20,7 @@ <%= contestnotifications.created_at %> <%= link_to l(:label_project_newother),contest_contestnotification_path(contestnotifications)%> - <%= "(#{l(:label_x_comments, :count => contestnotifications.comments_count)})" if contestnotifications.comments_count > 0 %> + <%= "(#{l(:label_x_comments, :count => contestnotifications.notificationcomments_count)})" if contestnotifications.notificationcomments_count > 0 %> diff --git a/app/views/contestnotifications/index.html.erb b/app/views/contestnotifications/index.html.erb index c9ce1622d..93d4aaf1f 100644 --- a/app/views/contestnotifications/index.html.erb +++ b/app/views/contestnotifications/index.html.erb @@ -48,7 +48,7 @@ <%= l :label_update_time %>  <%= format_time(contestnotifications.created_at) %> - <%= link_to l(:label_project_newother), contest_contestnotification_path(@contest, contestnotifications) %><%= "(#{l(:label_x_comments, :count => contestnotifications.comments.count)})" if(contestnotifications.comments.count >= 0)%> + <%= link_to l(:label_project_newother), contest_contestnotification_path(@contest, contestnotifications) %><%= "(#{l(:label_x_comments, :count => contestnotifications.notificationcomments.count)})" if(contestnotifications.notificationcomments.count >= 0)%> diff --git a/app/views/contestnotifications/show.html.erb b/app/views/contestnotifications/show.html.erb index 517f60bca..a9ba5f513 100644 --- a/app/views/contestnotifications/show.html.erb +++ b/app/views/contestnotifications/show.html.erb @@ -60,7 +60,7 @@ <% end %> -
+
<%= textilizable(@contestnotifications, :description) %> @@ -68,13 +68,13 @@ <%= link_to_attachments @contestnotifications %>
- <% if @contestnotifications.commentable? %> + <% if @contestnotifications.notificationcommentable? %>

- <%= toggle_link l(:label_comment_add), "add_comment_form", :focus => "comment_comments" %> + <%= toggle_link l(:label_comment_add), "add_notificationcomment_form", :focus => "comment_comments" %>

- <%= form_tag({:controller => 'comments', :action => 'create', :id => @contestnotifications}, :id => "add_comment_form", :style => "display:none;") do %> + <%= form_tag({:controller => 'notificationcomments', :action => 'create', :id => @contestnotifications}, :id => "add_notificationcomment_form", :style => "display:none;") do %>
- <%= text_area 'comment', 'comments', :cols => 80, :rows => 15, :class => 'wiki-edit' %> + <%= text_area 'notificationcomment', 'notificationcomments', :cols => 80, :rows => 15, :class => 'wiki-edit' %> <%= wikitoolbar_for 'comment_comments' %>

@@ -92,33 +92,33 @@

-

<%= l(:label_comment_plural) %>

- <% comments = @comments.reverse %> - <% comments.each do |comment| %> - <% next if comment.new_record? %> +

<%= l(:label_comment_plural) %>

+ <% notificationcomments = @notificationcomments.reverse %> + <% notificationcomments.each do |notificationcomment| %> + <% next if notificationcomment.new_record? %> - +
<%= image_tag(url_to_avatar(comment.author), :class => "avatar")%><%= image_tag(url_to_avatar(notificationcomment.author), :class => "avatar")%> - + - - +
<%= link_to_user(comment.author) if comment.respond_to?(:author) %> <%= l(:label_project_newadd) %><%= l(:label_comment_plural) %><%= link_to_user(notificationcomment.author) if notificationcomment.respond_to?(:author) %> <%= l(:label_project_newadd) %><%= l(:label_comment_plural) %>

- <%= textilizable(comment.comments) %> + <%= textilizable(notificationcomment.notificationcomments) %>

<%= format_time(comment.created_on) %><%= link_to_if_authorized image_tag('delete.png'), {:controller => 'comments', :action => 'destroy', :id => @contestnotifications, :comment_id => comment}, + <%= format_time(notificationcomment.created_at) %><%= link_to_if_authorized image_tag('delete.png'), {:controller => 'notificationcomments', :action => 'destroy', :id => @contestnotifications, :notificationcomment_id => notificationcomment}, :data => {:confirm => l(:text_are_you_sure)}, :method => :delete, :title => l(:button_delete) %>
- <% end if @comments.any? %> + <% end if @notificationcomments.any? %>
diff --git a/db/schema.rb b/db/schema.rb index 3573c188f..50d8e823f 100644 --- a/db/schema.rb +++ b/db/schema.rb @@ -211,9 +211,9 @@ ActiveRecord::Schema.define(:version => 20140605003915) do t.string "summary" t.string "description" t.integer "author_id" - t.integer "notificationcomments_count" - t.datetime "created_at", :null => false - t.datetime "updated_at", :null => false + t.integer "comments_count" + t.datetime "created_at", :null => false + t.datetime "updated_at", :null => false end create_table "contests", :force => true do |t| @@ -671,8 +671,8 @@ ActiveRecord::Schema.define(:version => 20140605003915) do t.boolean "inherit_members", :default => false, :null => false t.integer "project_type" t.boolean "hidden_repo", :default => false, :null => false - t.integer "attachmenttype", :default => 1 t.integer "user_id" + t.integer "attachmenttype", :default => 1 end add_index "projects", ["lft"], :name => "index_projects_on_lft" @@ -709,7 +709,7 @@ ActiveRecord::Schema.define(:version => 20140605003915) do end create_table "relative_memos", :force => true do |t| - t.integer "osp_id" + t.integer "osp_id", :null => false t.integer "parent_id" t.string "subject", :null => false t.text "content", :null => false @@ -796,10 +796,11 @@ ActiveRecord::Schema.define(:version => 20140605003915) do t.string "url" t.string "title" t.integer "share_type" - t.datetime "created_at", :null => false - t.datetime "updated_at", :null => false + t.datetime "created_at", :null => false + t.datetime "updated_at", :null => false t.integer "project_id" t.integer "user_id" + t.string "description" end create_table "softapplications", :force => true do |t| @@ -904,8 +905,8 @@ ActiveRecord::Schema.define(:version => 20140605003915) do t.integer "zip_code" t.datetime "created_at", :null => false t.datetime "updated_at", :null => false - t.integer "identity" t.string "technical_title" + t.integer "identity" t.string "student_id" t.string "teacher_realname" t.string "student_realname" diff --git a/lib/redmine.rb b/lib/redmine.rb index c612fd89e..71fbfed5b 100644 --- a/lib/redmine.rb +++ b/lib/redmine.rb @@ -148,9 +148,9 @@ Redmine::AccessControl.map do |map| end map.contest_module :contestnotifications do |map| - map.permission :manage_contestnotifications, {:contestnotifications => [:new, :create, :edit, :update, :destroy], :comments => [:destroy]}, :require => :member + map.permission :manage_contestnotifications, {:contestnotifications => [:new, :create, :edit, :update, :destroy], :notificationcomments => [:destroy]}, :require => :member map.permission :view_contestnotifications, {:contestnotifications => [:index, :show]}, :public => true, :read => true - map.permission :comment_contestnotifications, {:comments => :create} + map.permission :notificationcomment_contestnotifications, {:notificationcomments => :create} end map.project_module :documents do |map|