From 9b86661f4ac4afd697864bce3705a17b4bb975c1 Mon Sep 17 00:00:00 2001
From: huang <huang.jingquan@163.com>
Date: Fri, 26 Aug 2016 17:49:31 +0800
Subject: [PATCH] <ul class=contribute-list>

---
 .../quality_analysis_controller.rb            |  2 +-
 app/views/quality_analysis/_show.html.erb     | 26 ++++++++++---------
 2 files changed, 15 insertions(+), 13 deletions(-)

diff --git a/app/controllers/quality_analysis_controller.rb b/app/controllers/quality_analysis_controller.rb
index f0189a9b0..9fbe5bc3c 100644
--- a/app/controllers/quality_analysis_controller.rb
+++ b/app/controllers/quality_analysis_controller.rb
@@ -250,7 +250,7 @@ class QualityAnalysisController < ApplicationController
           changes = author_info.changes.to_i
           user_issues = open(@sonar_address + "/api/issues/search?projectKeys=#{@resource_id}&authors=#{email}&resolved=false").read
           issue_count = JSON.parse(user_issues)["total"].to_i
-          ratio = (changes == 0 ? 0 : issue_count%changes)
+          ratio = (changes == 0 ? 0 : format("%0.4f",issue_count.to_f/changes.to_f))
           @user_quality_infos << {:email => email, :changes => changes, :issue_count => issue_count, :ratio => ratio}
         end
 
diff --git a/app/views/quality_analysis/_show.html.erb b/app/views/quality_analysis/_show.html.erb
index fc8146a02..2fda1e727 100644
--- a/app/views/quality_analysis/_show.html.erb
+++ b/app/views/quality_analysis/_show.html.erb
@@ -140,18 +140,20 @@
 
       <% @user_quality_infos.each do |author_info| %>
           <% user = get_user_by_mail(author_info[:email]) %>
-          <ul class="contribute-list">
-            <li class="fl fontGrey2 contribute-list-avatar contribute-list-height">
-              <div class="mt8">
-                <%=link_to image_tag(url_to_avatar(user), :width => "50", :height => "30"), user_path(user), :class => "image-cir", :target => '_blank' %>
-                <p class="fontGrey2 hidden"><%=link_to (user.id == 2 ? author_info[:email] : user.show_name), user_path(user) %></p>
-              </div>
-            </li>
-            <li class="fl fontGrey2 contribute-list-code contribute-list-height contribute-list-line-height"><%= author_info[:changes] %></li>
-            <li class="fl fontGrey2 contribute-list-problem contribute-list-height contribute-list-line-height"><%= author_info[:issue_count] %></li>
-            <li class="fl contribute-list-rate fontBlue2 contribute-list-height contribute-list-line-height"><%= author_info[:ratio] %></li>
-            <div class="cl"></div>
-          </ul>
+          <% unless author_info[:changes] == 0 %>
+              <ul class="contribute-list">
+                <li class="fl fontGrey2 contribute-list-avatar contribute-list-height">
+                  <div class="mt8">
+                    <%=link_to image_tag(url_to_avatar(user), :width => "50", :height => "30"), user_path(user), :class => "image-cir", :target => '_blank' %>
+                    <p class="fontGrey2 hidden"><%=link_to (user.id == 2 ? author_info[:email] : user.show_name), user_path(user) %></p>
+                  </div>
+                </li>
+                <li class="fl fontGrey2 contribute-list-code contribute-list-height contribute-list-line-height"><%= author_info[:changes] %></li>
+                <li class="fl fontGrey2 contribute-list-problem contribute-list-height contribute-list-line-height"><%= author_info[:issue_count] %></li>
+                <li class="fl contribute-list-rate fontBlue2 contribute-list-height contribute-list-line-height"><%= author_info[:ratio] %></li>
+                <div class="cl"></div>
+              </ul>
+          <% end %>
       <% end %>
 
     </div>