diff --git a/app/controllers/projects_controller.rb b/app/controllers/projects_controller.rb index 1793eb39c..efe5a52ee 100644 --- a/app/controllers/projects_controller.rb +++ b/app/controllers/projects_controller.rb @@ -365,15 +365,18 @@ class ProjectsController < ApplicationController def invite_members_by_mail if User.current.member_of?(@project) || User.current.admin? @inviter_lists = InviteList.where(project_id:@project.id).all + @inviters = [] + @waiters = [] unless @inviter_lists.blank? @inviter_lists.each do|inviter_list| - @inviters = [] - @waiters = [] - @inviters << inviter_list.user - @inviters_count = @inviters.size - unless inviter_list.user.member_of?(@project) - @waiters << inviter_list.user - @waiters_count = @waiters.size + unless inviter_list.user.nil? + if inviter_list.user.member_of?(@project) + @inviters << inviter_list.user + @inviters_count = @inviters.size + else + @waiters << inviter_list.user + @waiters_count = @waiters.size + end end end end diff --git a/app/models/mailer.rb b/app/models/mailer.rb index 1325ef613..ec46917d9 100644 --- a/app/models/mailer.rb +++ b/app/models/mailer.rb @@ -199,8 +199,8 @@ class Mailer < ActionMailer::Base @title = "#@user #{t(:label_leave_your_message, :locale => 'zh')}" @issue_author_url = url_for(user_activities_url(@user)) @url = case journals_for_message.jour.class.to_s.to_sym # 判断留言的对象所属类型 - when :Bid - course_for_bid_url(journals_for_message.jour, anchor: "word_li_#{journals_for_message.id}") + # when :Bid + # course_for_bid_url(journals_for_message.jour, anchor: "word_li_#{journals_for_message.id}") when :Project return -1 if journals_for_message.jour.project_type == Project::ProjectType_project project_feedback_url(journals_for_message.jour, anchor: "word_li_#{journals_for_message.id}") @@ -236,12 +236,12 @@ class Mailer < ActionMailer::Base mail :to => @recipients, :subject => "#{l(:label_your_course)}#{journals_for_message.jour.name}#{l(:label_have_message)} ", :filter => true - elsif journals_for_message.jour.class.to_s.to_sym == :Bid - if !journals_for_message.jour.author.notify_about? journals_for_message - return -1 - end - - mail :to => recipients, :subject => @title,:filter => true + # elsif journals_for_message.jour.class.to_s.to_sym == :Bid + # if !journals_for_message.jour.author.notify_about? journals_for_message + # return -1 + # end + # + # mail :to => recipients, :subject => @title,:filter => true elsif journals_for_message.jour.class.to_s.to_sym == :Contest if !journals_for_message.jour.author.notify_about? journals_for_message return -1 diff --git a/app/views/mailer/send_for_user_activities.html.erb b/app/views/mailer/send_for_user_activities.html.erb index e1712a15d..9723783fe 100644 --- a/app/views/mailer/send_for_user_activities.html.erb +++ b/app/views/mailer/send_for_user_activities.html.erb @@ -39,7 +39,7 @@ <% end %> - <% if !@bids.first.nil? %> + <% unless @bids.empty? %>