From 9ee6fee20ad7640d8721431e6e65c5f77046264c Mon Sep 17 00:00:00 2001
From: SylorHuang <sylor_huang@126.com>
Date: Wed, 3 Jul 2019 16:58:42 +0800
Subject: [PATCH] fix bug

---
 .../exercise_questions_controller.rb          | 40 ++++++-------------
 app/helpers/exercises_helper.rb               |  9 +++++
 2 files changed, 21 insertions(+), 28 deletions(-)

diff --git a/app/controllers/exercise_questions_controller.rb b/app/controllers/exercise_questions_controller.rb
index b852e9437..e33e5e2dc 100644
--- a/app/controllers/exercise_questions_controller.rb
+++ b/app/controllers/exercise_questions_controller.rb
@@ -347,36 +347,20 @@ class ExerciseQuestionsController < ApplicationController
 
         #当试卷已发布时（试卷的总状态),当标准答案修改时，如有已提交的学生，需重新计算分数.
 
-        # if @exercise.exercise_status == 2
-        #   ex_users_committed = @exercise.exercise_users.exercise_user_committed
-        #   if ex_users_committed.size > 0
-        #     ex_users_committed.each do |ex_user|
-        #       user = ex_user.user
-        #       objective_score = calculate_student_score(@exercise,user)[:total_score]
-        #       subjective_score = ex_user.subjective_score
-        #       total_score_subjective_score = subjective_score < 0.0 ? 0.0 : subjective_score
-        #       total_score = objective_score + total_score_subjective_score
-        #       ex_user.update_attributes(objective_score:objective_score,score:total_score)
-        #     end
-        #   end
-        # end
-        ex_users_committed = @exercise.exercise_users.exercise_user_committed
-        if ex_users_committed.size > 0
-          ex_users_committed.each do |ex_user|
-            user = ex_user.user
-            objective_score = calculate_student_score(@exercise,user)[:total_score]
-            subjective_score = ex_user.subjective_score
-            total_score_subjective_score = subjective_score < 0.0 ? 0.0 : subjective_score
-            total_score = objective_score + total_score_subjective_score
-            ex_user.update_attributes(objective_score:objective_score,score:total_score)
+        if @exercise.exercise_status == 2
+          ex_users_committed = @exercise.exercise_users.exercise_user_committed
+          if ex_users_committed.size > 0
+            ex_users_committed.each do |ex_user|
+              user = ex_user.user
+              objective_score = calculate_student_score(@exercise,user)[:total_score]
+              subjective_score = ex_user.subjective_score
+              total_score_subjective_score = subjective_score < 0.0 ? 0.0 : subjective_score
+              total_score = objective_score + total_score_subjective_score
+              ex_user.update_attributes(objective_score:objective_score,score:total_score)
+            end
           end
         end
-
-        if @exercise_question.save
-          normal_status(0,"试卷更新成功！")
-        else
-          normal_status(-1,"试卷更新失败！")
-        end
+        normal_status(0,"试卷更新成功！")
       rescue Exception => e
         uid_logger_error(e.message)
         tip_exception("页面调用失败！")
diff --git a/app/helpers/exercises_helper.rb b/app/helpers/exercises_helper.rb
index 437965ca6..55ade6e7c 100644
--- a/app/helpers/exercises_helper.rb
+++ b/app/helpers/exercises_helper.rb
@@ -382,6 +382,9 @@ module ExercisesHelper
               end
               answers_content.update_all(:score => q_score_1)
               score1 = score1 + q.question_score
+            else
+              answers_content.update_all(:score => -1.0)
+              score1 += 0.0
             end
           else
             score1 += 0.0
@@ -403,6 +406,9 @@ module ExercisesHelper
                 if i_standard_answer.include?(u.answer_text.downcase)  #该空的标准答案包含用户的答案才有分数
                   u.update_column('score',q_score_2)
                   score2 = score2 + q_score_2
+                else
+                  u.update_column('score',-1.0)
+                  score2 += 0.0
                 end
               end
             else
@@ -413,6 +419,9 @@ module ExercisesHelper
                   u.update_column("score",q_score_2)
                   score2 = score2 + q_score_2
                   st_answer_text.delete(u_answer_text)
+                else
+                  u.update_column('score',-1.0)
+                  score2 += 0.0
                 end
               end
             end