From d2016b8e0e60ff17421f3ce3609c06760d1b9a7b Mon Sep 17 00:00:00 2001
From: hjm <63528605@qq.com>
Date: Tue, 15 Oct 2019 15:07:06 +0800
Subject: [PATCH 1/2] ChangeRolePop

---
 public/react/src/modules/courses/members/ChangeRolePop.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/public/react/src/modules/courses/members/ChangeRolePop.js b/public/react/src/modules/courses/members/ChangeRolePop.js
index 13130394a..9883c488f 100644
--- a/public/react/src/modules/courses/members/ChangeRolePop.js
+++ b/public/react/src/modules/courses/members/ChangeRolePop.js
@@ -1,4 +1,4 @@
-import React, { useState, useEffect } from 'react'
+import React, { useState, useEffect, memo } from 'react'
 import { trigger, WordsBtn } from 'educoder'
 import { Input, Checkbox, Popconfirm } from "antd";
 import axios from 'axios'
@@ -77,4 +77,4 @@ function ChangeRolePop({ member_roles = [], record, courseId, onChangeRoleSucces
         </Popconfirm>
     )
 }
-export default ChangeRolePop
\ No newline at end of file
+export default memo(ChangeRolePop)
\ No newline at end of file

From ffeb362b78e5bbd12d67da11579303f0313562bb Mon Sep 17 00:00:00 2001
From: hjm <63528605@qq.com>
Date: Tue, 15 Oct 2019 15:23:43 +0800
Subject: [PATCH 2/2] init

---
 public/react/src/modules/courses/members/ChangeRolePop.js | 8 +++++---
 public/react/src/modules/courses/members/studentsList.js  | 4 ++--
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/public/react/src/modules/courses/members/ChangeRolePop.js b/public/react/src/modules/courses/members/ChangeRolePop.js
index 9883c488f..d81c6db46 100644
--- a/public/react/src/modules/courses/members/ChangeRolePop.js
+++ b/public/react/src/modules/courses/members/ChangeRolePop.js
@@ -8,9 +8,11 @@ import axios from 'axios'
 */
 function ChangeRolePop({ member_roles = [], record, courseId, onChangeRoleSuccess, showNotification, getUserId, fetchUser }) {
     const [checkBoxRoles, setCheckBoxRoles] = useState(member_roles)
-    useEffect(() => {
-        setCheckBoxRoles(member_roles)
-    }, [member_roles])
+    // useEffect(() => {
+        // if (checkBoxRoles.length != member_roles.length) {  // 死循环
+            // setCheckBoxRoles(member_roles)
+        // }
+    // }, [member_roles])
     function onCheckBoxChange(val) {
         console.log(val)
 
diff --git a/public/react/src/modules/courses/members/studentsList.js b/public/react/src/modules/courses/members/studentsList.js
index ab29dde45..33d434329 100644
--- a/public/react/src/modules/courses/members/studentsList.js
+++ b/public/react/src/modules/courses/members/studentsList.js
@@ -149,7 +149,7 @@ const buildColumns = (that,isParent) => {
         return (
           <React.Fragment>
             <WordsBtn style2={{ marginRight: '12px' }} onClick={() => that.onDelete(record)} style={'grey'}>删除学生</WordsBtn>              
-            <ChangeRolePop
+            {record.member_roles && record.member_roles.length && <ChangeRolePop
               courseId={courseId}
               record={record}
               member_roles={record.member_roles}
@@ -157,7 +157,7 @@ const buildColumns = (that,isParent) => {
               showNotification={that.props.showNotification}
               getUserId={that.props.isUserid}
               fetchUser={that.props.fetchUser}
-            ></ChangeRolePop>
+            ></ChangeRolePop>}
           </React.Fragment>
         )
       },