From 23e74dcdfab838d2dfaa5f1df94ca11908875bed Mon Sep 17 00:00:00 2001 From: Kevin Bates Date: Thu, 4 Oct 2018 08:35:42 -0700 Subject: [PATCH] Include status types when logging activity Recently I needed to troubleshoot kernel responses and found it helpful to distinguish status types (busy vs. idle) - thought others might find it useful as well. Entries that previously appeared as... ``` activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status activity on 33383dcc-c054-4dc0-b842-16063ea160fe: execute_input activity on 33383dcc-c054-4dc0-b842-16063ea160fe: display_data activity on 33383dcc-c054-4dc0-b842-16063ea160fe: execute_result activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status ``` will now appear as... ``` activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status (idle) activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status (busy) activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status (idle) activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status (busy) activity on 33383dcc-c054-4dc0-b842-16063ea160fe: execute_input activity on 33383dcc-c054-4dc0-b842-16063ea160fe: display_data activity on 33383dcc-c054-4dc0-b842-16063ea160fe: execute_result activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status (idle) ``` --- notebook/services/kernels/kernelmanager.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/notebook/services/kernels/kernelmanager.py b/notebook/services/kernels/kernelmanager.py index f82f5d343..6d2158ef8 100644 --- a/notebook/services/kernels/kernelmanager.py +++ b/notebook/services/kernels/kernelmanager.py @@ -405,9 +405,11 @@ class MappingKernelManager(MultiKernelManager): msg = session.deserialize(fed_msg_list) msg_type = msg['header']['msg_type'] - self.log.debug("activity on %s: %s", kernel_id, msg_type) if msg_type == 'status': kernel.execution_state = msg['content']['execution_state'] + self.log.debug("activity on %s: %s (%s)", kernel_id, msg_type, kernel.execution_state) + else: + self.log.debug("activity on %s: %s", kernel_id, msg_type) kernel._activity_stream.on_recv(record_activity)