From 2c648fe4d09dfeda6ae007f3725c3b4f44172bcc Mon Sep 17 00:00:00 2001 From: Sylvain Corlay Date: Tue, 29 Jul 2014 20:11:34 +0000 Subject: [PATCH] bad call and missing call to unregister_comm --- IPython/html/static/services/kernels/js/comm.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/IPython/html/static/services/kernels/js/comm.js b/IPython/html/static/services/kernels/js/comm.js index 4cb24a6fa..04307cf40 100644 --- a/IPython/html/static/services/kernels/js/comm.js +++ b/IPython/html/static/services/kernels/js/comm.js @@ -56,9 +56,9 @@ define([ return comm.comm_id; }; - CommManager.prototype.unregister_comm = function (comm_id) { + CommManager.prototype.unregister_comm = function (comm) { // Remove a comm from the mapping - delete this.comms[comm_id]; + delete this.comms[comm.comm_id]; }; // comm message handlers @@ -88,7 +88,7 @@ define([ if (comm === undefined) { return; } - delete this.comms[content.comm_id]; + this.unregister_comm(comm); try { comm.handle_close(msg); } catch (e) {