From 38502ed5132724f0e1ee4355df6ddc6f24aa2fc5 Mon Sep 17 00:00:00 2001 From: Jonathan Frederic Date: Mon, 19 Oct 2015 09:11:50 -0700 Subject: [PATCH] notebook.save_notebook should ALWAYS return a Promise of some sort. --- notebook/static/notebook/js/notebook.js | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/notebook/static/notebook/js/notebook.js b/notebook/static/notebook/js/notebook.js index 523bb9570..7f3e17d1f 100644 --- a/notebook/static/notebook/js/notebook.js +++ b/notebook/static/notebook/js/notebook.js @@ -2217,16 +2217,16 @@ define(function (require) { if (check_last_modified === undefined) { check_last_modified = true; } + + var error; if (!this._fully_loaded) { - this.events.trigger('notebook_save_failed.Notebook', - new Error("Load failed, save is disabled") - ); - return; + error = new Error("Load failed, save is disabled"); + this.events.trigger('notebook_save_failed.Notebook', error); + return Promise.reject(error); } else if (!this.writable) { - this.events.trigger('notebook_save_failed.Notebook', - new Error("Notebook is read-only") - ); - return; + error = new Error("Notebook is read-only"); + this.events.trigger('notebook_save_failed.Notebook', error); + return Promise.reject(error); } // Trigger an event before save, which allows listeners to modify