Fix a bug in using promises with comms: this -> that

12 years ago · 4496bfc6bd
parent 9ca509d915
commit 4496bfc6bd
1 changed files with 2 additions and 2 deletions
--- a/IPython/html/static/services/kernels/comm.js
+++ b/IPython/html/static/services/kernels/comm.js
@ -106,9 +106,9 @@ define([
            console.error('Comm promise not found for comm id ' + content.comm_id);
            return;
        }
-
+        var that = this;
        this.comms[content.comm_id] = this.comms[content.comm_id].then(function(comm) {
-            this.unregister_comm(comm);
+            that.unregister_comm(comm);
            try {
                comm.handle_close(msg);
            } catch (e) {