From 61b2ad27ea490c72e46b43cd83f3393a488adb78 Mon Sep 17 00:00:00 2001 From: Jeremy Tuloup Date: Thu, 9 Feb 2023 09:50:23 +0100 Subject: [PATCH] Use Playwright `webServer` (#6720) * Use Playwright `webServer` * Try `jlpm start` * Lint --- .github/workflows/ui-tests.yml | 11 ----------- ui-tests/playwright.config.ts | 10 +++++++++- 2 files changed, 9 insertions(+), 12 deletions(-) diff --git a/.github/workflows/ui-tests.yml b/.github/workflows/ui-tests.yml index de2abfe67..9e0cbebef 100644 --- a/.github/workflows/ui-tests.yml +++ b/.github/workflows/ui-tests.yml @@ -52,17 +52,6 @@ jobs: jlpm --frozen-lockfile jlpm playwright install - - name: Start Jupyter Notebook - run: | - cd ui-tests - jlpm start:detached - - - name: Wait for Jupyter Notebook - uses: ifaxity/wait-on-action@v1 - with: - resource: http-get://127.0.0.1:8888/ - timeout: 360000 - - name: Test run: | cd ui-tests diff --git a/ui-tests/playwright.config.ts b/ui-tests/playwright.config.ts index a016ad08c..4d649dd51 100644 --- a/ui-tests/playwright.config.ts +++ b/ui-tests/playwright.config.ts @@ -6,5 +6,13 @@ module.exports = { appPath: '', video: 'retain-on-failure' }, - retries: 1 + retries: 1, + webServer: [ + { + command: 'jlpm start', + port: 8888, + timeout: 120 * 1000, + reuseExistingServer: true + } + ] };