Don't url escape filenames on download

Grant Nestor 9 years ago
parent f8d4d6ad2d
commit 64ed6e439c

@ -478,7 +478,7 @@ class AuthenticatedFileHandler(IPythonHandler, web.StaticFileHandler):
def get(self, path):
if os.path.splitext(path)[1] == '.ipynb' or self.get_argument("download", False):
name = path.rsplit('/', 1)[-1]
self.set_header('Content-Disposition','attachment; filename="%s"' % escape.url_escape(name))
self.set_header('Content-Disposition','attachment; filename="%s"' % name)
return web.StaticFileHandler.get(self, path)

@ -46,7 +46,7 @@ class FilesHandler(IPythonHandler):
model = cm.get(path, type='file', content=include_body)
if self.get_argument("download", False):
self.set_header('Content-Disposition','attachment; filename="%s"' % escape.url_escape(name))
self.set_header('Content-Disposition','attachment; filename="%s"' % name)
# get mimetype from filename
if name.endswith('.ipynb'):

@ -39,7 +39,7 @@ def respond_zip(handler, name, output, resources):
# Headers
zip_filename = os.path.splitext(name)[0] + '.zip'
handler.set_header('Content-Disposition',
'attachment; filename="%s"' % escape.url_escape(zip_filename))
'attachment; filename="%s"' % zip_filename)
handler.set_header('Content-Type', 'application/zip')
# Prepare the zip file
@ -115,7 +115,7 @@ class NbconvertFileHandler(IPythonHandler):
if self.get_argument('download', 'false').lower() == 'true':
filename = os.path.splitext(name)[0] + resources['output_extension']
self.set_header('Content-Disposition',
'attachment; filename="%s"' % escape.url_escape(filename))
'attachment; filename="%s"' % filename)
# MIME type
if exporter.output_mimetype:

Loading…
Cancel
Save