From 87b5b2ffb0aa491fdef27eb0019fcea34370508c Mon Sep 17 00:00:00 2001 From: Peter Parente Date: Fri, 27 Jan 2017 21:38:27 -0500 Subject: [PATCH] Fix missing running kernels When a kernelspec is removed while a kernel spawned from it is in use the Running tab on the dashboards page errors and no longer shows any results. Fall back on using the kernel name from the session in this case so that users can see and terminate kernels. --- notebook/static/tree/js/kernellist.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/notebook/static/tree/js/kernellist.js b/notebook/static/tree/js/kernellist.js index 50fbd620a..875324291 100644 --- a/notebook/static/tree/js/kernellist.js +++ b/notebook/static/tree/js/kernellist.js @@ -49,7 +49,7 @@ define([ return; // wait for kernelspecs before first load } this.clear_list(); - var item, path, session; + var item, path, session, info; for (path in d) { if (!d.hasOwnProperty(path)) { // nothing is safe in javascript @@ -57,11 +57,12 @@ define([ } session = d[path]; item = this.new_item(-1); + info = this.kernelspecs[session.kernel.name]; this.add_link({ name: path, path: path, type: 'notebook', - kernel_display_name: this.kernelspecs[session.kernel.name].spec.display_name + kernel_display_name: (info && info.spec) ? info.spec.display_name : session.kernel.name }, item); } $('#running_list_placeholder').toggle($.isEmptyObject(d));