From 90486755475dc6b0cc99e47ec066f312198fe63d Mon Sep 17 00:00:00 2001 From: Matthias Bussonnier Date: Mon, 18 May 2015 17:20:53 -0700 Subject: [PATCH] remove reverse dependency in Page --- notebook/static/base/js/namespace.js | 1 + notebook/static/base/js/page.js | 5 +---- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/notebook/static/base/js/namespace.js b/notebook/static/base/js/namespace.js index 664a6b653..fe7c2c3f2 100644 --- a/notebook/static/base/js/namespace.js +++ b/notebook/static/base/js/namespace.js @@ -23,6 +23,7 @@ define(function(){ Jupyter.Kernel = require('services/kernels/kernel').Kernel; Jupyter.Session = require('services/kernels/session').Session; Jupyter.LoginWidget = require('auth/js/loginwidget').LoginWidget + Jupyter.Page = require('base/js/page').Page; Jupyter.version = "4.0.0.dev"; Jupyter._target = '_blank'; diff --git a/notebook/static/base/js/page.js b/notebook/static/base/js/page.js index 5749af1d5..9ec72786f 100644 --- a/notebook/static/base/js/page.js +++ b/notebook/static/base/js/page.js @@ -2,10 +2,9 @@ // Distributed under the terms of the Modified BSD License. define([ - 'base/js/namespace', 'jquery', 'base/js/events', -], function(IPython, $, events){ +], function($, events){ "use strict"; var Page = function () { @@ -59,7 +58,5 @@ define([ $('div#site').height($(window).height() - $('#header').height()); }; - // Register self in the global namespace for convenience. - IPython.Page = Page; return {'Page': Page}; });