From 75ac4015ff158724b5b21a480b4d6fd553d2fe8c Mon Sep 17 00:00:00 2001 From: Jeremy Tuloup Date: Mon, 11 Oct 2021 22:47:05 +0200 Subject: [PATCH 1/2] Hoist the filebrowser factory plugin --- app/index.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/index.js b/app/index.js index 04c829194..ca8558552 100644 --- a/app/index.js +++ b/app/index.js @@ -122,6 +122,9 @@ async function main() { ['@jupyterlab/docmanager-extension:plugin'].includes(id) ), require('@jupyterlab/docprovider-extension'), + require('@jupyterlab/filebrowser-extension').default.filter(({ id }) => + ['@jupyterlab/filebrowser-extension:factory'].includes(id) + ), require('@jupyterlab/fileeditor-extension').default.filter(({ id }) => ['@jupyterlab/fileeditor-extension:plugin'].includes(id) ), @@ -156,7 +159,6 @@ async function main() { [ '@jupyterlab/filebrowser-extension:browser', '@jupyterlab/filebrowser-extension:download', - '@jupyterlab/filebrowser-extension:factory', '@jupyterlab/filebrowser-extension:file-upload-status', '@jupyterlab/filebrowser-extension:open-with', '@jupyterlab/filebrowser-extension:share-file' From 6c1129ca90a714eb808fae2f8a5cf024dab29893 Mon Sep 17 00:00:00 2001 From: Jeremy Tuloup Date: Tue, 12 Oct 2021 00:31:05 +0200 Subject: [PATCH 2/2] factory is already registered in edit --- app/index.js | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/app/index.js b/app/index.js index ca8558552..71a6ad4bf 100644 --- a/app/index.js +++ b/app/index.js @@ -203,10 +203,7 @@ async function main() { ['@jupyterlab/completer-extension:files'].includes(id) ), require('@jupyterlab/filebrowser-extension').default.filter(({ id }) => - [ - '@jupyterlab/filebrowser-extension:browser', - '@jupyterlab/filebrowser-extension:factory' - ].includes(id) + ['@jupyterlab/filebrowser-extension:browser'].includes(id) ) ]); break;