From d1358dd9bad2e77f9030ab46ea1b9bc91ce7b809 Mon Sep 17 00:00:00 2001 From: Min RK Date: Tue, 29 Mar 2016 11:07:49 -0700 Subject: [PATCH] fix validation warnings map is lazily evaluated, so doesn't show messages --- notebook/nbextensions.py | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/notebook/nbextensions.py b/notebook/nbextensions.py index 9f259daf9..0f3a3ecde 100644 --- a/notebook/nbextensions.py +++ b/notebook/nbextensions.py @@ -511,9 +511,11 @@ def validate_nbextension(require, logger=None): if logger: if warnings: - logger.warn(u" - Validating: problems found:") - map(logger.warn, warnings) - map(logger.info, infos) + logger.warning(u" - Validating: problems found:") + for msg in warnings: + logger.warning(msg) + for msg in infos: + logger.info(msg) else: logger.info(u" - Validating: {}".format(GREEN_OK)) @@ -563,10 +565,12 @@ def validate_nbextension_python(spec, full_dest, logger=None): if logger: if warnings: - logger.warn("- Validating: problems found:") - [logger.warn(warning) for warning in warnings] - [logger.info(info) for info in infos] - logger.warn(u"Full spec: {}".format(spec)) + logger.warning("- Validating: problems found:") + for msg in warnings: + logger.warning(msg) + for msg in infos: + logger.info(msg) + logger.warning(u"Full spec: {}".format(spec)) else: logger.info(u"- Validating: {}".format(GREEN_OK))