From d7cc8dcf8d2b6091774d2ade226dd08458b62e20 Mon Sep 17 00:00:00 2001 From: Matthias BUSSONNIER Date: Wed, 16 Jul 2014 18:31:10 +0200 Subject: [PATCH] a few todo --- IPython/html/static/notebook/js/cell.js | 3 ++- IPython/html/static/notebook/js/celltoolbar.js | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/IPython/html/static/notebook/js/cell.js b/IPython/html/static/notebook/js/cell.js index d5f794673..7769fea8c 100644 --- a/IPython/html/static/notebook/js/cell.js +++ b/IPython/html/static/notebook/js/cell.js @@ -6,6 +6,7 @@ define([ 'jquery', 'base/js/utils', ], function(IPython, $, utils) { + // TODO: remove IPython dependency here "use strict"; // monkey patch CM to be able to syntax highlight cell magics @@ -556,7 +557,7 @@ define([ this.code_mirror.setOption('mode', default_mode); }; - // Backwards compatability. + // Backwards compatibility. IPython.Cell = Cell; return {'Cell': Cell}; diff --git a/IPython/html/static/notebook/js/celltoolbar.js b/IPython/html/static/notebook/js/celltoolbar.js index 05a9cfcd7..b7215eb89 100644 --- a/IPython/html/static/notebook/js/celltoolbar.js +++ b/IPython/html/static/notebook/js/celltoolbar.js @@ -16,6 +16,9 @@ define([ // events: $(Events) instance // cell: Cell instance // notebook: Notebook instance + // + // TODO: This leaks, when cell are deleted + // There is still a reference to each celltoolbars. CellToolbar._instances.push(this); this.notebook = options.notebook; this.events = options.events;