From daa80ad4ac7c27ccc8e8204283520184788b3ca3 Mon Sep 17 00:00:00 2001 From: Chris Miller Date: Mon, 3 Dec 2018 19:04:12 -0500 Subject: [PATCH] Tune chunk size for large file uploads to be larger for perf gains. --- notebook/static/tree/js/notebooklist.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/notebook/static/tree/js/notebooklist.js b/notebook/static/tree/js/notebooklist.js index 18122aa68..7753a56dd 100644 --- a/notebook/static/tree/js/notebooklist.js +++ b/notebook/static/tree/js/notebooklist.js @@ -1314,7 +1314,8 @@ define([ var parse_large_file = function (f, item) { // codes inspired by https://stackoverflow.com/a/28318964 - var chunk_size = 1024 * 1024; + // 8MB chunk size chosen to match chunk sizes used by benchmark reference (AWS S3) + var chunk_size = 1024 * 1024 * 8; var offset = 0; var chunk = 0; var chunk_reader = null;