Some improvements to promise handling when saving notebook

Thomas Kluyver 7 years ago
parent c33130dcbb
commit df8a548012

@ -2742,6 +2742,8 @@ define([
$.proxy(that.save_notebook_success, that, start),
function (error) {
that.events.trigger('notebook_save_failed.Notebook', error);
// This hasn't handled the error, so propagate it up
return Promise.reject(error);
}
);
};
@ -2845,6 +2847,7 @@ define([
this.create_checkpoint();
this._checkpoint_after_save = false;
}
return data;
};
Notebook.prototype.save_notebook_as = function() {
@ -3309,7 +3312,7 @@ define([
*/
Notebook.prototype.save_checkpoint = function () {
this._checkpoint_after_save = true;
this.save_notebook(true);
return this.save_notebook(true);
};
/**

Loading…
Cancel
Save