195ca091c5
FileNotebookManager: Use shutil.move() instead of os.rename()
...
`os.rename()` fails in case the new path is on a different
filesystem. For example if a file in `/tmp` is tried to save
to home, it causes following error:
[Errno 18] Invalid cross-device link using os.rename
12 years ago
27a77dedbd
API: Allow NotebookManagers to control kernel startup dir. #5468
12 years ago
62061f0294
only catch errors in copystat
12 years ago
caee63f413
fallback on copy, copyfile if copy2 fails
...
in notebook manager
12 years ago
3588fe40a9
Merge Security Pull Request: google-caja
...
Adds HTML sanitization.
The basics:
- untrusted HTML is always sanitized, with no warning
(there is console logging for changes made)
- markdown is always treated as untrusted
- no warnings for simply excluded output (e.g. Javascript)
- CSS tags and attributes are always stripped from untrusted HTML
- never check whether HTML is "safe," only sanitize
- add 'Trust notebook' to File menu
12 years ago
8d38e042df
Merge pull request #5158 from ivanov/fix-5157
...
log refusal to serve hidden directories
12 years ago
d8f2e320f2
trust method docstrings
12 years ago
d5b0026cf1
trust via mark cells and save, rather than trust API request
12 years ago
c9c23cd71c
cleanup test_nbmanager
...
use class setUp / teardown instead of the same context manager in every test
12 years ago
1ae689f30c
Add Trust Notebook to File menu
12 years ago
6c8cccf9e3
fix test suite
...
is_hidden expects the file to actually exist, so I've rearranged the
logic such that is_hidden is called only after it's clear that the file
exists.
12 years ago
052955a84a
normalize unicode in notebook API tests
...
was failing comparison on OS X
12 years ago
d6f2dfefea
log refusal to serve hidden files dirs
12 years ago
8c1c18461c
Fix a couple of static analysis warnings
12 years ago
3698563794
Make hidden directories configurable
12 years ago
c75d4e9962
Don't attempt locale-aware sorting for now.
...
On Python 2, locale.strxfrm() can't handle unicode.
12 years ago
4fe9f8d057
Case insensitive sorting in the dashboard.
...
Closes gh-5151
12 years ago
c1e8ddc64e
Hide directories beginning with _ from the dashboard.
...
Closes gh-5152
12 years ago
d37780c6a6
use config instead of App.instance to propagate notebook_dir
...
Should behave more logically (I hope).
12 years ago
cb25736a24
reorganize who knows what about paths
...
- add NotebookApp.notebook_dir
- add KernelManager.root_dir
- remove NotebookManager.notebook_dir, move to FileNBM.notebook_dir
Default value for KM.root_dir and fNBM.notebook_dir is NotebookApp.notebook_dir, but they can be configured separately.
SessionManager passes the API path to KernelManager,
which is responsible for turning it into the kernel's cwd.
12 years ago
37cb0fbdee
remove websocket url
...
websockets should follow the kernel URL
(normal behavior is unchanged, only unused configurability is removed)
12 years ago
db4960769b
Merge pull request #5100 from minrk/base_kernel_url
...
remove base_kernel_url
12 years ago
a184724bdb
remove base_kernel_url
12 years ago
fdb8ab37ae
Rearrange the NotebookManager methods for clarity
...
Methods are organized into three categories:
- Methods that must be implemented in subclasses
- Methods that have default implementations, but can
be overridden if required.
- Support methods meant to be called by methods in subclasses
12 years ago
b1c6ba2c97
Move method increment_filename from FileNotebookManager to NotebookManager
...
The implementation requires only a minor change (call notebook_exists
rather than checking for file existence) to be universally usable
in other notebook managers.
12 years ago
0a430f5840
Add method notebook_exists to NotebookManager.
...
It is called by IPython.html.notebook.NotebookHandler.get,
so it must be implemented by every notebook handler.
12 years ago
26e3e31ad8
NotebookManager API: rename *notebook_model methods to *notebook
12 years ago
e1e0b19a6a
s/base_project_url/base_url/
...
deprecate NotebookApp.base_project_url
12 years ago
eb9e0be218
Small refactoring of is_hidden to take root as default kwarg.
12 years ago
243392d810
Creating and testing IPython.html.utils.is_hidden.
12 years ago
7e1a179a7c
Addressing review comments.
...
* list_dirs and get_dir_model added to base NBM class.
* Calling of list_dirs moved to handler.
* type=notebook added to notebook model.
12 years ago
717f031e01
Adding dashboard navigation tests for dir browsing.
12 years ago
c1a8f5af6a
Get the existing tests working.
12 years ago
45a8d046c8
Add support for index.ipynb
12 years ago
a3ef3109db
Server side logic for directories.
12 years ago
eb208b2d77
move signature checking to base NotebookManager
...
so that subclasses have less to duplicate
12 years ago
6dd44de19f
Notaries sign notebooks now
12 years ago
ffb3523d05
use configured scheme, not stored scheme when checking signatures
...
protects against notebook author choosing bad hash scheme.
12 years ago
6a1e7fe685
add nbformat.sign.NotebookNotary
12 years ago
f14f856edb
sign notebooks
12 years ago
7ae363f6d1
turn missing dependencies in nbconvert to 500 errors
...
pygments is the only such example at this time
12 years ago
91d3326923
allow notebook to start without nbconvert
...
catches import / key errors and turns them into proper http errors
12 years ago
57642b3847
Move notebook URL fragment regexen into IPython.html.base.handlers
12 years ago
30e8939a27
Separate listing nbconvert exporters to /api/nbconvert
12 years ago
7655ce579e
Add HTTP handlers for nbconvert
12 years ago
b82b4997e7
test that rename fails with 409 if it would clobber
...
(test already passes, but it should still be tested)
closes #4600
12 years ago
79c27df217
Specify encoding in remainining instances of io.open
12 years ago
3fb55970be
Miscellaneous docs fixes
12 years ago
b829043a60
Add test for saving notebook with .py script
12 years ago
8ed3a725f3
Pass nbformat object to write call to save .py script
...
Closes gh-4495
12 years ago
557fb3f4ae
Python 3 compatibility for os.getcwdu()
12 years ago
93ee2d7173
Make sessions REST API test more robust.
...
Was seeing failures on Windows because it failed to delete the folder.
12 years ago
bce32ec03b
Fixes for notebook session manager
12 years ago
4a14ed7e22
Replace references to unicode and basestring
12 years ago
d4532983f4
Convert print statements to print function calls
...
libmodernize.fixes.fix_print
12 years ago
c3e6e625a7
Merge pull request #4427 from minrk/checkpoint-on-first-save
...
notebooks should always have one checkpoint
closes #4396
12 years ago
6bc2c65c83
notebooks should always have one checkpoint
...
closes #4396
12 years ago
3a4d719033
fix checkpoint filename
12 years ago
922f458d6a
set kernel cwd to notebook's directory
...
closes #4424
12 years ago
40cce4d7e3
s/os.path.sep/os.sep/
12 years ago
dfb538d881
Windows testing fixes
12 years ago
1f90f4d7bb
test /files/ gives 403 on hidden files
12 years ago
24174f31d9
use itertools.count for incrementing notebook filename
13 years ago
cc08837111
fix created timestamp in notebook model
13 years ago
f894dbe664
test upload of v2 notebooks
13 years ago
cf0218e2d1
don't use jsonapi in test_notebook_api
13 years ago
66ccce69c6
copy_from in json, not in url param
13 years ago
ef0d065712
test nbmanager.copy_notebook
13 years ago
7ea311ad64
escape URLs in Location headers
13 years ago
06d9b99141
update notebook api tests
...
with creation URL changes
also use unicode as the default name in tests,
to increase likelihood of catching unicode bugs.
13 years ago
f11caf25e7
update notebook creation handlers
...
- only POST to directories (notebook picks name)
- only PUT to full paths
- PUT and POST should be equivalent aside from
who picks the notebook name.
13 years ago
60d12e4209
allow specifying destination in copy_notebook
13 years ago
d1a36fe4c0
use 'id' for checkpoint ID key
...
rather than redundant checkpoint.checkpoint_id
13 years ago
36aa39e3b7
Improving tests and setting of Location header.
13 years ago
51fc769edd
Handle notebook downloads through the /files URL.
13 years ago
59901ce88c
Adding docstring to NotebookHandler.get.
13 years ago
6017f5d0ef
Specify encoding for loading and saving notebooks.
13 years ago
05e85588cf
Add some unicode testing for saving notebooks
13 years ago
cbc141c95c
Fixes for notebook checkpoint APIs
13 years ago
3f46a05a14
Test notebook checkpoint APIs
13 years ago
4a12890d65
disable download-as-pt
...
since it doesn't work. Adds a note about nbconvert needed to bring it back.
13 years ago
d089f7749f
Use assertEqual, not deprecated assertEquals
13 years ago
836ad5f388
Add tests for interrupting & restarting kernel
...
These are in an existing test method, as starting and stopping kernels
for individual tests is expensive.
13 years ago
06fa301908
Refactor tests for kernels REST API
13 years ago
8b9bb04d12
review pass on Sessions API
13 years ago
b1a0f2e8cc
404 on attempt to list notebooks in nonexistant directory
13 years ago
18f88d020f
Add failing test for listing nonexistant directory
13 years ago
99969474e0
Fix notebook manager test
13 years ago
c18aaefbde
Fix sessionmanager test
13 years ago
e240f21ea1
Clean up sessions code from static analysis
13 years ago
693cc97905
Fix some HTTP status codes in sessions API
13 years ago
b3d2698c11
Fix session API tests
13 years ago
a02bd3d5e4
Improve Session REST API tests
13 years ago
a6a7255454
Fix some notebook model tests
13 years ago
acb4245035
unicode normalization in test_notebooks_api
13 years ago
9f4a4ab3f8
Check Location header from renaming notebook
13 years ago
9144e8e57b
Fix check of notebook path
13 years ago
eb9a55ed6b
Add test for and fix REST save with rename
13 years ago
b9310d0e05
Add test for copying notebook through REST API
13 years ago
7725025d52
Add test for saving notebook via REST API
13 years ago
85d3c39b5a
Add test for REST API uploading notebook
13 years ago
9d9adb1186
Improve tests for notebook REST API
13 years ago
6c88abe1d6
always set location on PATCH
...
don't redirect
13 years ago
dc65b33d14
simplify handler patterns
...
PATH pattern will now sometimes include leading slash,
but that's okay because nbmanager will strip them.
fewer redirect patterns needed
13 years ago
a31cfdc8a8
ensure 'path' never has leading or trailing slash in nbmanager
...
Don't trust API callers to always get this right.
13 years ago
a7f297f8f3
save before download-as
...
uses `async : false`
closes #852
download-as-py still unavailable.
13 years ago
8b94ee2b47
use `async : false` to avoid pop-up blocker on New / Copy notebook
13 years ago
b33ffa7068
update upload and copy
...
adds 'notebook.ipynb/copy' url handler
because we were putting too many things in a single POST handler.
13 years ago
4e12521082
fix dashboard upload
13 years ago
5b1a648fc8
move os_path to FileNBMan
...
doesn't belong in base NotebookManager
13 years ago
fe59217989
move url_[un]escape to utils from nbm
13 years ago
16e8d0ff43
adjust definition of 'path' in notebooks
...
never includes leading or trailing '/'
13 years ago
e46412e30f
fix `--notebook-dir` configurable when there is no trailing slash
13 years ago
d3e456d9a1
add tests to notebooks api
...
- check for correct status codes
- check headers location
- fix COPY api
13 years ago
9e0beba86f
adding to test_kernels_api.py
...
- Check all HTTP status code responses for requests
- Test invalid kernel IDs
- Check 'location' key in POST request to kernels
13 years ago
c26700cd3a
changes after session manager code review
13 years ago
7aaaab0668
fixed notebook rename after nbmanager refactor
13 years ago
2a946c62ab
added tests to nbmanager for url encode/decode
13 years ago
97bc426bb7
add error catching to kernel manager
...
also, adding further tests to kernel manager
13 years ago
c0bc0410ce
Review and refactoring of notebooks web service.
13 years ago
5568cd5db0
ensure test_no_kernels runs first
...
since it expects a clean notebook server.
13 years ago
27680dacb2
Code review changes.
...
Fixed handler issues and api tests from code review
from @minrk and @carreau.
13 years ago
04c6a3cfac
refactoring of nbmanager and filenbmanager
...
major clean up of the two managers. We make sure to follow
the standard models described in IPEP 16
13 years ago
050a3098a8
review fixes on tests, add extra kernel api test
13 years ago
e9ac1c2d37
add tests for session api
13 years ago
8ce586a241
move notebooks api tests into notebooks/tests
13 years ago
f517d44d4b
removing contents changes from this PR
13 years ago
95b505d602
Added notebooks API tests.
13 years ago
5f1b7727d8
fix bug in test_contentmanager
13 years ago
136a19e5eb
Added base class for Notebook API tests.
13 years ago
483d16c8ed
clean kernel manager
13 years ago
22e351ae3b
cleaning nb handlers, adding doc-strings/comments
13 years ago
8c2009874c
session manager restructuring
...
Redid the sessionmanager, added tests for the session manager,
and added a sqlite database to hold kernel,session,nb mapping.
13 years ago
b8318708eb
clean up of get_os_path and its tests
...
work with @Zsailer
13 years ago
34b9840786
fixing broken links from recent changes.
...
After fixing operating system path changes in previous commits,
many links needed to be adjusted to direct to the correct URL.
13 years ago
470595f9e7
handle path separators with os.sep and add tests
...
Added more tests to the notebook manager to check for the correct
path separators on different operating system. Fixed the get_path
method.
13 years ago
bdbe30dc3a
url encode/decode tests added to nbmanager
13 years ago
7ca8a21bf6
named_notebook_path: consistent usage convention
13 years ago
a083ad1fd7
more named_notebook_path cleanup
...
named_notebook_path now returns path with leading and trailing slashes.
Work with @Zsailer
13 years ago
fd7a64ff38
simplified named_notebook_path implementation
...
Also updated the tests
13 years ago
9f08aa5a08
cleaning up named_notebook_path
13 years ago
11e5bd7b24
adding tests for named_notebook_path
...
I want to do some refactoring, so I'll put in some tests that will define the
behavior that I want to preserve, so I can verify that my refactoring hasn't
broken anything.
13 years ago
18fdb26273
Fix to if test
13 years ago
6154c5f626
Remove some unnecessary imports
13 years ago
2a81c5f80c
Update docstring
13 years ago
213b89c1cc
Simplify encoding/decoding URL parts
13 years ago
adb2fc1fa4
Better use Python slicing
13 years ago
1f04b48725
Renaming fixed
13 years ago
f3af343f4f
Change new/copy URLS to POST requests
13 years ago
8261ac2cb9
change standard money keys
13 years ago
Pankaj Pandey
Dale Jung
MinRK
Brian E. Granger
Paul Ivanov
Thomas Kluyver
Konrad Hinsen
Zachary Sailer