1) finish the step allowing the use of es6
- this include some tweak to web pack configuration to speed up
recompile in watch mode (in particular cache sourcemaps).
- enable eslint (error only), on obvious mistakes.
- setup babel to compile to es5 as a target.
2) Make the test pass under Casper that does not always have
`Function.prototype.bind` defined, which we cannot patch only in the
tests.
3) Write an actual shortcut editor that list and allow to modify most of
the command mode shortcut.
The logic to persist the shortcuts is a bit tricky as there are default
keyboard shortcuts, and so when you "unbind" them you need to re-unbind
them at next startup. This does not work for a few shortcut for
technical reasons: `<Esc>`, `<Shift>`, as well as `<Ctrl-Shift-P>` and `<F>`
which register asynchronously, so are not detected as "default"
shortcuts.
It use the notion of Head/Anchor moving the selection normally move both
the head and the anchor. It is possible to mot move the anchor, for
example by pressing Shift.
Everything in between the head and the anchor (head and anchor included)
is in a "soft-selection" marked with the 'jupyter-soft-selection' class
in CSS.
This then remove completely the notion of marked cell, and thus disallow
discontinuous selection.
Unlike previous implementation the used a thick left border, this use
background gradient with 2 stops at the same position to archived the
same visual effect without the gap in between left border in between
contiguous cells.
For compatibility with previous versions, a few choices have been made.
An extra multi-selected class is added to the body when multiple
cells are selected. This allow to toggle the background to a soft blue
indicating selection. And the Head of the selection is still called the
"selected" cell.
The on_focus event have been reworked as a
click-let-click-release-outside of codemirror was putting the notebook
in undefined state with multiple selected cells, and the head in edit
mode.
Finally Travis now test on edge group, to get faster, which can be
removed in a few weeks as the all infrastructure of Travis will move on
Google Cloud.
In the function remove_shortcut, if the action failed, it used to
throw an 'implementation oriented' exception message:
> throws('try to delete non-leaf')
This is not a good message for the user who wants to mess with the
shortcuts.
The solution is to leave this 'implementation oriented' exception message
and add a try-catch bloc above that catches this message and throws
a new, frendliest, exception message.
I came up with this:
> throws('try to remove non-existing shortcut')
* notebook/static/base/js/keyboard.js: (remove_shortcut) add try-catch.
Signed-off-by: Nicolas Barray <nbarray@gmail.com>
Matthias Bussonnier
Jonathan Frederic
Thomas Fors
Brian E. Granger
Josh Barnes
Dave Willmer
Niole Nelson
Nicolas Barray
Min RK