Inject requirejs in notebook and start using it.
Mainly because the behavior of Marked change when require is injected.
So only apply the modification needed for marked to behave.
rollback #3358#3358 was a workaround for a CodeMirror (actually Chrome seems to be the one at fault) bug drawing scrollbars over text, when there isn't anything to scroll. The workaround was a compromise, always drawing the space for the scrollbars to prevent the overlay, but reducing the margin so it isn't quite so annoying in the ~99% of the time that there are no scrollbars. It turns out (#3397, #3399) that the margins are not reliable, so the margin adjustment could cause the very same problem.
closes#3391, #3397, #3399
For users who need to hide the scrollbars while zooming text while we wait for a CodeMirror release, you can add the following to your custom.css:
.CodeMirror-scroll, .CodeMirror-wrap .CodeMirror-scroll {
overflow: scroll;
}
.CodeMirror-vscrollbar, .CodeMirror-scrollbar-filler, .CodeMirror-hscrollbar {
visibility: hidden;
}
or just put CodeMirror master in your profile's static/components directory.
make cookie_secret configurable
Allows config to specify logins that survive across server instances (default behavior unchanged).
Add warning about not sharing config files with cookie secret.
closes#3391
For users who need to hide the scrollbars while zooming text in the meantime, you can add the following to your custom.css:
```css
.CodeMirror-scroll, .CodeMirror-wrap .CodeMirror-scroll {
overflow: scroll;
}
.CodeMirror-vscrollbar, .CodeMirror-scrollbar-filler, .CodeMirror-hscrollbar {
visibility: hidden;
}
```
switch default ws_url logic to js side
In some cases (proxies, #3305), the request object doesn't have the right information about the originating information. This changes the default behavior, so that ws_url is generally empty by default, which the javascript takes to mean 'the same as http'. This is simpler and should be more resilient than trying a guess on server-side.
also replaces unused websocket_host with websocket_url
Rather than specifying only the hostname, it makes much more sense to specify the whole protocol,host,port in a single go.