3e82ea8319
actually send only one kernel_info request
...
store the Future for the initial request,
allowing subsequent requests to wait on the same pending reply.
Previously, any incoming requests that arrived while waiting for the first reply would send their own request.
11 years ago
e329a79bc8
language is removed from kernel specs
...
don't use it when testing kernel spec API
11 years ago
a2575af6a7
log kernel specs that fail to load
11 years ago
e5b135a905
debugging websocket connections
...
- add debug statement at the very beginning of a web socket request
- add debug statement in open, indicating that the connection has been accepted
- add timeout, so failed or slow kernel_info doesn't cause the request to never get a response
- don't send kernel_info_request before authenticating the request
The last one required some icky coroutine shenanigans,
because of our subclass structure, but it should work fine.
11 years ago
a5a43e2746
Don't resend kernel info requests if a bad reply is received
11 years ago
94d6196ef9
add websocket workarounds for tornado 3
...
WebSocketHandler.get is new in tornado 4
11 years ago
769fe38789
cache kernel_info reply for protocol adaptation
...
WebSocket connections will not open until kernel_info is retrieved,
removing a race condition waiting for the reply to indicate adaptation,
which could result in a v5 message being sent to a v4 kernel.
The reply is cached, so that it need not be requested on each new connection.
11 years ago
3693ac83ae
support binary message from javascript
11 years ago
c9c131ebf9
s/unserialize/deserialize
11 years ago
7da61bfc13
use default kernel name in kernels service
...
matches sessions API
11 years ago
624f0071a2
remove on_first_message authentication
...
in ZMQStreams. No need for weird, special first message.
- use regular cookie auth
- use url param for session id
11 years ago
b2a0798fdf
Merge pull request #6598 from minrk/nbformat-backport
...
nbformat validation
11 years ago
7d7b85a043
Merge pull request #6649 from minrk/302-notebooks
...
redirect /api/notebooks to /api/contents
11 years ago
b87fee048c
redirect /api/notebooks to /api/contents
...
eases 2.x-3.x transition for consumers such as emacs-ipython-notebook
11 years ago
b2d946d44e
don't convert notebooks on upload
11 years ago
8392c7ac9e
don't check_and_sign old notebooks on upload
11 years ago
4ae05c729c
trust is stored in code_cell.metadata
...
not top-level code_cell
11 years ago
ddd3aa2a5a
add dialogs for failed save/load
...
- failed validation doesn't prevent save/load,
but the user is now warned about it.
- there is now a warning dialog if fromJSON fails,
rather than the usual silent failure.
11 years ago
d606d53b4e
More informative error messages
11 years ago
e808d23594
Merge pull request #6607 from minrk/cluster-load-remove
...
remove deleted profiles from cluster list
11 years ago
ee1d9d65f3
stop using deprecated DelayedCallback
...
in favor of simpler IOLoop.add_timeout
It was added in pyzmq, but deprecated in pyzmq-13.
11 years ago
1f231f7b5a
remove deleted profiles from cluster list
11 years ago
6bc5702398
More descriptive short message
11 years ago
46e40e5ea1
Return a proper JSON object
11 years ago
5e1e8a116c
Use 501 error code instead of 400
11 years ago
c4a89cd54d
Better user experience when kernel isn't found
11 years ago
cfc234dc89
Handle NoSuchKernel errors more gracefully
11 years ago
974d45343e
allow kernel_name to be undefined in requests
...
fallback to KM.default_kernel_name in that case
11 years ago
5bc118fb6c
handle system-wide kernelspecs
...
in html tets_kernelspecs_api, which can cause counts to be greater than 2
12 years ago
97e99d0661
Merge pull request #6412 from takluyver/sessions-rest-api-fix
...
Sessions rest api fix
12 years ago
fa6056e9ed
Sort directory contents in test before assertion
...
Should fix recent test failures, but I can't replicate failure on my
computer, so it's not clear that it's fixed.
12 years ago
b2737e668e
Add tests and fix some issues
...
Tests taken from #6360
12 years ago
0e109ee4be
Correct comment
12 years ago
ca8dabf705
Fix 404 error when accessing nonexistant session
12 years ago
76b05b24af
Handle sessions where the kernel has been killed
12 years ago
81b06d81a1
Merge pull request #6358 from minrk/contents-missing
...
fix directory listing with broken symlinks
12 years ago
fbae96f9cb
Merge pull request #6269 from takluyver/atomic-save
...
Implement atomic save
12 years ago
819c3c326c
fix directory listing with broken symlinks
...
directory listing would 404 if any listed file doesn't exist
(e.g. symlink to missing target).
Previously-failing test included.
12 years ago
bd5a88e954
handle undefined or closed zmq_stream in on_message
...
can happen if a message is waiting in a pipe and the web socket is closed before the message is handled.
And give ZMQChannels a nice repr with their kernel ID
12 years ago
8b7d4c1c2f
Rework atomic_writing with tests & docstring
12 years ago
04cbce2a14
Implement atomic save
...
Ping @fperez, this should avoid issues with corrupted/lost notebooks
when the disk is full, though I haven't worked out how to test it just
yet.
Closes gh-6254
12 years ago
3e79eea46b
update contents per further review
...
- fix is_hidden always returning True on nonexistent files
- create hidden dir fails with 400
- don't read binary files twice
- logging improvements
- dialog on invalid notebook upload
- warn about disabled `--save`
12 years ago
3c26b079f0
updates per review
...
- clarified docstrings and errors
- still more notebook/file renames
- configurable untitled names
- copy_from can be full path
- fix running, upload, new-tab behaviors in dashboard
Yay, review!
12 years ago
bec995aa63
updates per review
...
a few more notebook mentions in docstrings,
and inappropriate use of setdefault.
12 years ago
93b300adda
support deleting empty directories
...
can’t copy directories
12 years ago
260afd76ae
contents service review
...
- missed some s/notebook/file/ in docstrings
- manager doesn’t sort contents
12 years ago
accf0878ae
test creating a directory with PUT
12 years ago
8c4069cc00
add support and tests for uploading and saving regular files
12 years ago
0c0eb43719
teach contents service about non-notebook files
12 years ago
6cce477e07
rename notebooks service to contents service
...
minimal functional changes, committing because tests are passing.
12 years ago
b73aa2b9f9
mv services/notebooks services/contents
12 years ago
0e3d27c841
Deterministic order for kernels in notebook UI
12 years ago
88e52b2746
Only allow iframe embedding on same origin.
12 years ago
806432072a
Add kernel name to sessions REST API
...
Also, some refactoring so that the relationship between session, kernels
and notebooks is managed in the SessionManager, not in the HTTP
handlers.
12 years ago
ae6309c122
Add support for different kernel specs to kernels REST API
12 years ago
e64f689374
don’t import IPython.parallel until it’s used
...
in IPython.html.notebookapp
12 years ago
3b92c7c24f
Merge pull request #6011 from minrk/no-jsonapi
...
only use zmq.jsonapi when talking to zmq sockets
12 years ago
99f52dee68
Merge pull request #5827 from takluyver/kernelspec-rest-api
...
Kernel specs REST API
12 years ago
44d2a5b62a
only use zmq.jsonapi when talking to zmq sockets
...
use stdlib json otherwise
12 years ago
ebf0ea32ef
Use stdlib json, not zmq jsonapi
12 years ago
76fdfe9eb7
Put full kernel info in REST API response for all kernels
12 years ago
f6628b7006
Refactor kernelspec resource handler to separate URL prefix
12 years ago
336f47c126
update message spec adapter per review
...
- docs and comments
- adapt complete_reply with `end=null`, `start=-len(matched_text)`
- remove some incorrect `status` fields
- add `handle_reply_status_error` for handling `status=error` replies (no-op, currently)
12 years ago
b06f382e9b
interrogate kernel_info to get protocol version for adaptation
12 years ago
1dabf3c547
Test kernel specs REST API
...
And fix kernel not found producing a 404 code.
12 years ago
02fa348c69
Create REST API for kernel specs
12 years ago
c4e0ef142b
Merge pull request #5759 from minrk/travis-3.4
...
test with Python 3.4 on Travis
12 years ago
191cd44c4d
cleanup socket cleanup
...
- set linger on sockets (avoid hang on exit)
- actually close sockets, not just zmq streams (blame pyzmq, aka me)
seems to be necessary for js/notebook/shutdown test to avoid hanging on Python 3.4.
12 years ago
925a58c0b4
Remove unused imports
12 years ago
934e731237
add utils.path.ensure_dir_exists
...
Ensures that a directory exists,
and protects against a common race condition when multiple
processes try to create the same directory.
12 years ago
df335decff
create checkpoints dir in notebook subdirectories
12 years ago
bf871b020d
test notebook checkpoints in subdirectories
12 years ago
dec6fb7260
Merge pull request #5469 from dalejung/nbm_kernel_path
...
API: Allow NotebookManagers to specify kernel startup dir.
closes #5468
12 years ago
195ca091c5
FileNotebookManager: Use shutil.move() instead of os.rename()
...
`os.rename()` fails in case the new path is on a different
filesystem. For example if a file in `/tmp` is tried to save
to home, it causes following error:
[Errno 18] Invalid cross-device link using os.rename
12 years ago
27a77dedbd
API: Allow NotebookManagers to control kernel startup dir. #5468
12 years ago
62061f0294
only catch errors in copystat
12 years ago
caee63f413
fallback on copy, copyfile if copy2 fails
...
in notebook manager
12 years ago
3588fe40a9
Merge Security Pull Request: google-caja
...
Adds HTML sanitization.
The basics:
- untrusted HTML is always sanitized, with no warning
(there is console logging for changes made)
- markdown is always treated as untrusted
- no warnings for simply excluded output (e.g. Javascript)
- CSS tags and attributes are always stripped from untrusted HTML
- never check whether HTML is "safe," only sanitize
- add 'Trust notebook' to File menu
12 years ago
8d38e042df
Merge pull request #5158 from ivanov/fix-5157
...
log refusal to serve hidden directories
12 years ago
d8f2e320f2
trust method docstrings
12 years ago
d5b0026cf1
trust via mark cells and save, rather than trust API request
12 years ago
c9c23cd71c
cleanup test_nbmanager
...
use class setUp / teardown instead of the same context manager in every test
12 years ago
1ae689f30c
Add Trust Notebook to File menu
12 years ago
6c8cccf9e3
fix test suite
...
is_hidden expects the file to actually exist, so I've rearranged the
logic such that is_hidden is called only after it's clear that the file
exists.
12 years ago
052955a84a
normalize unicode in notebook API tests
...
was failing comparison on OS X
12 years ago
d6f2dfefea
log refusal to serve hidden files dirs
12 years ago
8c1c18461c
Fix a couple of static analysis warnings
12 years ago
3698563794
Make hidden directories configurable
12 years ago
c75d4e9962
Don't attempt locale-aware sorting for now.
...
On Python 2, locale.strxfrm() can't handle unicode.
12 years ago
4fe9f8d057
Case insensitive sorting in the dashboard.
...
Closes gh-5151
12 years ago
c1e8ddc64e
Hide directories beginning with _ from the dashboard.
...
Closes gh-5152
12 years ago
d37780c6a6
use config instead of App.instance to propagate notebook_dir
...
Should behave more logically (I hope).
12 years ago
cb25736a24
reorganize who knows what about paths
...
- add NotebookApp.notebook_dir
- add KernelManager.root_dir
- remove NotebookManager.notebook_dir, move to FileNBM.notebook_dir
Default value for KM.root_dir and fNBM.notebook_dir is NotebookApp.notebook_dir, but they can be configured separately.
SessionManager passes the API path to KernelManager,
which is responsible for turning it into the kernel's cwd.
12 years ago
37cb0fbdee
remove websocket url
...
websockets should follow the kernel URL
(normal behavior is unchanged, only unused configurability is removed)
12 years ago
db4960769b
Merge pull request #5100 from minrk/base_kernel_url
...
remove base_kernel_url
12 years ago
a184724bdb
remove base_kernel_url
12 years ago
fdb8ab37ae
Rearrange the NotebookManager methods for clarity
...
Methods are organized into three categories:
- Methods that must be implemented in subclasses
- Methods that have default implementations, but can
be overridden if required.
- Support methods meant to be called by methods in subclasses
12 years ago
b1c6ba2c97
Move method increment_filename from FileNotebookManager to NotebookManager
...
The implementation requires only a minor change (call notebook_exists
rather than checking for file existence) to be universally usable
in other notebook managers.
12 years ago
0a430f5840
Add method notebook_exists to NotebookManager.
...
It is called by IPython.html.notebook.NotebookHandler.get,
so it must be implemented by every notebook handler.
12 years ago
26e3e31ad8
NotebookManager API: rename *notebook_model methods to *notebook
12 years ago
e1e0b19a6a
s/base_project_url/base_url/
...
deprecate NotebookApp.base_project_url
12 years ago
eb9e0be218
Small refactoring of is_hidden to take root as default kwarg.
12 years ago
243392d810
Creating and testing IPython.html.utils.is_hidden.
12 years ago
7e1a179a7c
Addressing review comments.
...
* list_dirs and get_dir_model added to base NBM class.
* Calling of list_dirs moved to handler.
* type=notebook added to notebook model.
12 years ago
717f031e01
Adding dashboard navigation tests for dir browsing.
12 years ago
c1a8f5af6a
Get the existing tests working.
12 years ago
45a8d046c8
Add support for index.ipynb
12 years ago
a3ef3109db
Server side logic for directories.
12 years ago
eb208b2d77
move signature checking to base NotebookManager
...
so that subclasses have less to duplicate
12 years ago
6dd44de19f
Notaries sign notebooks now
12 years ago
ffb3523d05
use configured scheme, not stored scheme when checking signatures
...
protects against notebook author choosing bad hash scheme.
12 years ago
6a1e7fe685
add nbformat.sign.NotebookNotary
12 years ago
f14f856edb
sign notebooks
12 years ago
7ae363f6d1
turn missing dependencies in nbconvert to 500 errors
...
pygments is the only such example at this time
12 years ago
91d3326923
allow notebook to start without nbconvert
...
catches import / key errors and turns them into proper http errors
12 years ago
57642b3847
Move notebook URL fragment regexen into IPython.html.base.handlers
12 years ago
30e8939a27
Separate listing nbconvert exporters to /api/nbconvert
12 years ago
7655ce579e
Add HTTP handlers for nbconvert
12 years ago
b82b4997e7
test that rename fails with 409 if it would clobber
...
(test already passes, but it should still be tested)
closes #4600
12 years ago
79c27df217
Specify encoding in remainining instances of io.open
12 years ago
3fb55970be
Miscellaneous docs fixes
12 years ago
b829043a60
Add test for saving notebook with .py script
12 years ago
8ed3a725f3
Pass nbformat object to write call to save .py script
...
Closes gh-4495
12 years ago
557fb3f4ae
Python 3 compatibility for os.getcwdu()
12 years ago
93ee2d7173
Make sessions REST API test more robust.
...
Was seeing failures on Windows because it failed to delete the folder.
12 years ago
bce32ec03b
Fixes for notebook session manager
12 years ago
4a14ed7e22
Replace references to unicode and basestring
12 years ago
d4532983f4
Convert print statements to print function calls
...
libmodernize.fixes.fix_print
12 years ago
c3e6e625a7
Merge pull request #4427 from minrk/checkpoint-on-first-save
...
notebooks should always have one checkpoint
closes #4396
12 years ago
6bc2c65c83
notebooks should always have one checkpoint
...
closes #4396
12 years ago
3a4d719033
fix checkpoint filename
12 years ago
922f458d6a
set kernel cwd to notebook's directory
...
closes #4424
12 years ago
40cce4d7e3
s/os.path.sep/os.sep/
12 years ago
dfb538d881
Windows testing fixes
12 years ago
1f90f4d7bb
test /files/ gives 403 on hidden files
12 years ago
24174f31d9
use itertools.count for incrementing notebook filename
12 years ago
cc08837111
fix created timestamp in notebook model
12 years ago
f894dbe664
test upload of v2 notebooks
12 years ago
cf0218e2d1
don't use jsonapi in test_notebook_api
12 years ago
66ccce69c6
copy_from in json, not in url param
12 years ago
ef0d065712
test nbmanager.copy_notebook
12 years ago
7ea311ad64
escape URLs in Location headers
12 years ago
06d9b99141
update notebook api tests
...
with creation URL changes
also use unicode as the default name in tests,
to increase likelihood of catching unicode bugs.
12 years ago
f11caf25e7
update notebook creation handlers
...
- only POST to directories (notebook picks name)
- only PUT to full paths
- PUT and POST should be equivalent aside from
who picks the notebook name.
12 years ago
60d12e4209
allow specifying destination in copy_notebook
12 years ago
d1a36fe4c0
use 'id' for checkpoint ID key
...
rather than redundant checkpoint.checkpoint_id
12 years ago
36aa39e3b7
Improving tests and setting of Location header.
12 years ago
51fc769edd
Handle notebook downloads through the /files URL.
12 years ago
59901ce88c
Adding docstring to NotebookHandler.get.
12 years ago
6017f5d0ef
Specify encoding for loading and saving notebooks.
12 years ago
05e85588cf
Add some unicode testing for saving notebooks
12 years ago
cbc141c95c
Fixes for notebook checkpoint APIs
12 years ago
3f46a05a14
Test notebook checkpoint APIs
12 years ago
4a12890d65
disable download-as-pt
...
since it doesn't work. Adds a note about nbconvert needed to bring it back.
12 years ago
d089f7749f
Use assertEqual, not deprecated assertEquals
12 years ago
836ad5f388
Add tests for interrupting & restarting kernel
...
These are in an existing test method, as starting and stopping kernels
for individual tests is expensive.
12 years ago
06fa301908
Refactor tests for kernels REST API
12 years ago
8b9bb04d12
review pass on Sessions API
12 years ago
b1a0f2e8cc
404 on attempt to list notebooks in nonexistant directory
12 years ago
18f88d020f
Add failing test for listing nonexistant directory
12 years ago
99969474e0
Fix notebook manager test
12 years ago
c18aaefbde
Fix sessionmanager test
12 years ago
e240f21ea1
Clean up sessions code from static analysis
12 years ago
693cc97905
Fix some HTTP status codes in sessions API
12 years ago
b3d2698c11
Fix session API tests
12 years ago
a02bd3d5e4
Improve Session REST API tests
12 years ago
a6a7255454
Fix some notebook model tests
12 years ago
acb4245035
unicode normalization in test_notebooks_api
12 years ago
9f4a4ab3f8
Check Location header from renaming notebook
12 years ago
9144e8e57b
Fix check of notebook path
12 years ago
eb9a55ed6b
Add test for and fix REST save with rename
12 years ago
b9310d0e05
Add test for copying notebook through REST API
12 years ago
7725025d52
Add test for saving notebook via REST API
12 years ago
85d3c39b5a
Add test for REST API uploading notebook
12 years ago
9d9adb1186
Improve tests for notebook REST API
12 years ago
6c88abe1d6
always set location on PATCH
...
don't redirect
12 years ago
dc65b33d14
simplify handler patterns
...
PATH pattern will now sometimes include leading slash,
but that's okay because nbmanager will strip them.
fewer redirect patterns needed
12 years ago
a31cfdc8a8
ensure 'path' never has leading or trailing slash in nbmanager
...
Don't trust API callers to always get this right.
12 years ago
a7f297f8f3
save before download-as
...
uses `async : false`
closes #852
download-as-py still unavailable.
12 years ago
8b94ee2b47
use `async : false` to avoid pop-up blocker on New / Copy notebook
12 years ago
b33ffa7068
update upload and copy
...
adds 'notebook.ipynb/copy' url handler
because we were putting too many things in a single POST handler.
12 years ago
4e12521082
fix dashboard upload
12 years ago
5b1a648fc8
move os_path to FileNBMan
...
doesn't belong in base NotebookManager
12 years ago
fe59217989
move url_[un]escape to utils from nbm
12 years ago
16e8d0ff43
adjust definition of 'path' in notebooks
...
never includes leading or trailing '/'
12 years ago
e46412e30f
fix `--notebook-dir` configurable when there is no trailing slash
12 years ago
d3e456d9a1
add tests to notebooks api
...
- check for correct status codes
- check headers location
- fix COPY api
12 years ago
9e0beba86f
adding to test_kernels_api.py
...
- Check all HTTP status code responses for requests
- Test invalid kernel IDs
- Check 'location' key in POST request to kernels
12 years ago
c26700cd3a
changes after session manager code review
12 years ago
7aaaab0668
fixed notebook rename after nbmanager refactor
12 years ago
2a946c62ab
added tests to nbmanager for url encode/decode
12 years ago
97bc426bb7
add error catching to kernel manager
...
also, adding further tests to kernel manager
12 years ago
c0bc0410ce
Review and refactoring of notebooks web service.
12 years ago
5568cd5db0
ensure test_no_kernels runs first
...
since it expects a clean notebook server.
12 years ago
27680dacb2
Code review changes.
...
Fixed handler issues and api tests from code review
from @minrk and @carreau.
12 years ago
04c6a3cfac
refactoring of nbmanager and filenbmanager
...
major clean up of the two managers. We make sure to follow
the standard models described in IPEP 16
12 years ago
050a3098a8
review fixes on tests, add extra kernel api test
12 years ago
e9ac1c2d37
add tests for session api
12 years ago
8ce586a241
move notebooks api tests into notebooks/tests
12 years ago
f517d44d4b
removing contents changes from this PR
12 years ago
Min RK
Matthias Bussonnier
Jessica B. Hamrick
Thomas Kluyver
rgbkrk
Spencer Nelson
Pankaj Pandey
Dale Jung
Brian E. Granger
Paul Ivanov
Konrad Hinsen
Zachary Sailer