ee76005bc2
More review changes
12 years ago
70ffd96eb9
Added some nice comments,
...
so devs can easily figure out what options to pass
into the objects they want to construct.
12 years ago
d9ab2d203a
In person review with @ellisonbg
12 years ago
1e098560b8
Revert "Google hangout review comments."
...
This reverts commit 4e120e76014b2630f957c01d17ba3926d4848872.
12 years ago
eb2b1ab4a4
Google hangout review comments.
12 years ago
2ba8945cab
Fix all the bugs!
12 years ago
c7961ae2db
Fix imports of "modules",
...
required after converting everything into dictionary returns.
12 years ago
0edfdbc703
Return dicts instead of classes,
...
this makes require.js more Python import like.
12 years ago
0e9e1dd5a3
MWE,
...
Fixed LOTS of bugs
12 years ago
516958ac07
Almost done!
...
Still need to check IPython uses in the widgets.
12 years ago
152e23dc76
Progress...
12 years ago
997a9735f0
Merge pull request #5320 from jdfreder/focusbug_tt
...
Fix for Tooltip & completer click focus bug.
12 years ago
b2ec594c76
Getting a lot closer...
12 years ago
5f086fded2
Merge pull request #5372 from minrk/no-close-strings
...
Don't autoclose strings, because CodeMirror's behavior makes it confusing and awkward to type triple-quoted strings (and these are very common in Python).
An issue about this was filed in CodeMirror itself: https://github.com/marijnh/CodeMirror/issues/2385
12 years ago
3c1fe84f52
Don't autoclose strings
...
CodeMirror doesn't do the right thing with triple-quoted strings,
so don't let it try.
12 years ago
67fd905421
minor fixes to docs to address PR feedback
12 years ago
443083c1fd
Added some comments
12 years ago
7762cb0ab3
Fixed a small bug/typo
12 years ago
e61b6aef47
Add logic to close tt when cell is unselected
12 years ago
65732920eb
Remove all should cancel blur logic.
12 years ago
989ae4e1b3
Workaround for Tooltip & completer click focus bug.
12 years ago
54409a196d
dem semicolons
12 years ago
b9e448b160
DRY: refactor common keyboard handling to Cell
...
Our edit mode keyboard shortcuts don't distinguish between being in a
code cell or in a text cell, so it makes sense to handle both in one
place. This is a first step in that direction.
12 years ago
15f4345ba3
typo, use keycodes object instead of magic numbers
12 years ago
bf3ecdb35f
DRY: factor out common handle_keyevent method
...
This method was identical in both CodeCell and TextCell
12 years ago
71d4c427c9
refactor to improve cell switching in edit mode
...
This code was repeated in both CodeCell and TextCell, both of which are
extensions of Cell, so this just unifies the logic in Cell.
TextCell had logic here to check if the cell was rendered or not, but I
don't believe it is possible to end up triggering such a code path.
(Should that be required, I can always just add back these methods to
TextCell, performing the .rendered==True check, and calling the Cell
prior to this, code mirror at_top would only return true on if the
cursor was at the first character of the top line. Now, pressing up
arrow on any character on the top line will take you to the cell above.
The same applies for the bottom line. Pressing down arrow would only go
to the next cell if the cursor was at a location *after* the last
character (something that is only possible to achieve in vim mode if the
last line is empty, for example). Now, down arrow on any character of
the last line will go to the next cell.
12 years ago
af7dd15181
Removing old keyboard handling from IPython.utils.
12 years ago
88460cd212
Merge pull request #5175 from jdfreder/html-take2
...
Audit .html() calls take #2
12 years ago
69e760841a
Move should cancel blur into codecell
12 years ago
a6f883d7f2
Couple of whiteboard logic implementation misses
12 years ago
048ca30b0c
Remove fixes that are implemented correct in new CM
12 years ago
ff37fb7a36
Standardized comments and removed last logs
12 years ago
70086d352f
s/unfocus/blur
12 years ago
c7860d8bc8
Post in person review
...
Removed logic for reverse ordered events
Removed almost all of the log statements
Removed list for should unfocus callbacks
Removed all the logic in focus_editor
Only call focus_editor if the keyboard was used to enter edit mode
12 years ago
10d79a9102
Added cell unfocus event canceller API
12 years ago
6f7c502157
Fixed lots of bugs
...
Half overhaul of notebook focus events...
12 years ago
ad03225cf6
Audit .html() calls take #2
12 years ago
6ced0bcbac
Added automatic close of Brackets.
12 years ago
888698e12f
Merge pull request #4662 from ellisonbg/menu-cleanup
...
Menu cleanup
12 years ago
54666e2e98
Cleaning up output management in code and menus.
12 years ago
f14f856edb
sign notebooks
12 years ago
bc7b51d1b0
Merge pull request #4374 from jdfreder/widget-msg
...
IPEP 23: Backbone.js Widgets
12 years ago
f5fa732bd3
avoid injection in input prompt
12 years ago
bad85fb879
Remove O(N) cell by msg-id lookup
12 years ago
b9f6e562f7
Changed underscores in CSS names to dashes
12 years ago
5cac3fceae
Fixed glitch when widgetarea wouldn't get completely hidden upon re-execution
12 years ago
686dd7aea0
Clear widgets upon cell execute
12 years ago
2b3d6ab2e4
Added clear widget area button
12 years ago
ac874a4bf6
Added widget output area
12 years ago
5e706935e1
Semicolon cleanup.
12 years ago
c888f9d3e4
Cleaning up console log messages.
12 years ago
33097b0c1f
Adding missig altKey test to CodeCell.
12 years ago
11493ca042
Don't always call focus_cell in Cell.command_mode.
...
The focus_cell should only be called when a user enters
command mode by pressing ESC. Calling focus_cell was causing
jumps when command mode was entered through a mouse click.
12 years ago
b244518871
Special handling for CM's vim keyboard mapping.
12 years ago
c1166ea98a
Lots of updates and changes.
...
* Cleaning up the code mirror event handlers.
* Adding logic to prevent calling Notebook.command_mode on cell
focusout.
* Fixing bugs.
12 years ago
caffba142e
Adding keyboard manager logic.
...
This is currently very broken.
12 years ago
40977e545b
Semi working version of basic dual mode UX.
...
As of this point there are lots of things that don't work, but
most of the basic dual mode interactions do work fine.
12 years ago
2a530ff30d
More work on the dual mode UX.
12 years ago
54088a0105
Adding new logic to cells.
12 years ago
2181a29be7
Starting work on select/focus logic.
12 years ago
4039e246fc
Merge pull request #4306 from minrk/raw-cell-metadata
...
add raw_mimetype metadata to raw cells
12 years ago
79a12cf907
Adding prompt area to non-CodeCells to indent content.
...
This is a reponse to the problem of having really long lines in
Markdown cells, which makes the content difficult to read. Users
want wide code cells, so we don't want to narrow everything. The
solution here is to give a prompt area to the heading/md cells
to narrow their content area slightly. The only problem is that
this makes it more difficult to distinguish between output
and md content that follows that output. The solve this, we are
adding a narrow line between output and following md.
12 years ago
9fc9580256
set cell_type properly first-class in the Cell object
...
- in toJSON
- don't clobber existing value in Cell constructor
12 years ago
749e9d9ac4
Fixing cell_type in CodeCell constructor.
...
This was causing the cell_type to be null for CodeCells, which
broke the cell type dropdown in the toolbar.
12 years ago
33dd73eea4
some optimisation and code cleaning
...
optimisation are not obvious, but order and time of attribute creation
in javascript have impact for VMs apparently (Google IO talk on V8)
12 years ago
5db9624d44
prompt '*' strore fix + tab remove tooltip
...
tab was not cancelling tooltip bringing to cases where you could have
tooltip andcompleter open.
Do not store '*' when serializing cells.
12 years ago
a1afcd92b4
Merge pull request #4398 from Carreau/no-tooltip-on-tab
...
[Notebook] Deactivate tooltip on tab by default.
12 years ago
d90429366b
Remove tooltip on tab logic
12 years ago
90f67d3bbe
add CodeCell.get_callbacks
...
for reusing default execute callbacks
12 years ago
aa388570d3
jshint on codecell
12 years ago
d99e25f245
refactor js callbacks
...
all callbacks get the whole message
12 years ago
0558ec4ce0
Cells shouldn't know about Sessions
12 years ago
e16a5807c7
fixup bad rebase
12 years ago
da58c8c470
Fixed session js ajax request.
...
Session was not creating a kernel object on the client side,
after the server created successfully created a session.
12 years ago
bfff3d817d
Fixed bug when linking kernel to new code cells
12 years ago
54c751ce50
Merge pull request #4229 from jdfreder/clearoutput
...
Clear_output: Animation & widget related changes.
13 years ago
6bfd28b91d
Added wait flag to clear_output.
13 years ago
00f0c827e9
Removed ability to clear stdout and stderr individually.
13 years ago
5d19c204db
clear previous callbacks on execute
...
avoids mixed up display of multiple executions in one output area
when a cell is resubmitted.
closes #4223
13 years ago
9ceedb62d0
Have remove_and_cancel_tooltip() return a boolean
13 years ago
a11ebc8b0a
ESC should be handled by CM if tooltip is not on
13 years ago
fc8f118610
store default codemirror mode in only 1 place
13 years ago
9845ba1416
add missing store_history key to Notebook execute_requests
13 years ago
9973445f9a
Closes #3788
13 years ago
f9dd129e1c
remove notebook read-only view
...
it is largely broken, and had problematic security issues.
13 years ago
127a0669ff
enable comment/uncomment selection
...
with `(cmd|ctrl)-/`
closes #1540
13 years ago
2272edf715
correct static path for CM modes autoload
...
this shoudl also allow to require CM python mode for ipython mode and
only pass a config options.
13 years ago
cf726d6a40
mv IPython.html.notebook -> IPython.html
13 years ago
Jonathan Frederic
jon
Paul Ivanov
Fernando Perez
MinRK
Paul Ivanov
Brian E. Granger
damianavila
Matthias BUSSONNIER
Zachary Sailer
Takeshi Kanmae
Jessica B. Hamrick