This was showing 'seconds ago' for every file, because it was looking
for the nonexistant 'modified' field. The correct name is 'last_modified'.
I'm not sure how long this has been broken.
- replace regexes they were not matching at the end of files.
- hide edit/view for multiple, they where not working
From the Pr comments that should closely match the following
Observations:
- "View" is handled by the browser so in most case it's something
"safe". I think that (A) all items we don't know what to do with
should have the _possibility_ to be viewed. (example `config.yaml`,
`cat.gifv`).
- "Edit" make sens only on text files only. In general (B) "edit"
should not be the default action for most files.
- Though (C) "Edit" should be triggerable by advanced users (unless
we know we should not). Example `foo.zorblax`, `conf.toml`
- (D) "Edit" does not make sens for some filetypes, thus should not be
available (`'png`, `.jpeg`)
Question (E):
- If the default action is X {in edit/view} should the X button be shown ?
Proposition:
- if ipynb:
- default link edit
- no button in toolbar.
- If known type, editable (txt, json, yaml, py, rb):
- default link open edit,
- button in toolbar show view
- if known type not editable: (, png, gif, zip)
- default link open view
- no button in toolbar
- if unknown type ('.zorblax, toml, cson, ')
- default link open "view"
- button in the toolbar show "Edit".
In the future I would like to show the Edit button for notebooks
but have it open them in the text editor. Right now, there isn't
any way for a user to do this. Thus hiding Edit on notebooks for
now.
This removes the showing of the Edit button when:
* We know we can't edit the file (pdf, doc, xls, jpeg, png, etc.)
* Or a notebook - looking at this again though...
When a kernelspec is removed while a kernel spawned from it is in use
the Running tab on the dashboards page errors and no longer shows
any results. Fall back on using the kernel name from the session
in this case so that users can see and terminate kernels.
* Edit notebook opens a notebook, Edit any other file type open it in a
text editor
* View only available for HTML files to disambiguate between “viewing”
a notebook or text file (which is the same as editing it) and viewing
an HTML file
samarsultan
Thomas Kluyver
John Emmons
Min RK
Thomas Kluyver
Grant Nestor
Brian E. Granger
Eric Perry
Samar Sultan
Ioannis Papadopoulos
Kaushik Chaubal
Matthias Bussonnier
Peter Parente
Doug Blank
Jinesh Mehta