- replace regexes they were not matching at the end of files.
- hide edit/view for multiple, they where not working
From the Pr comments that should closely match the following
Observations:
- "View" is handled by the browser so in most case it's something
"safe". I think that (A) all items we don't know what to do with
should have the _possibility_ to be viewed. (example `config.yaml`,
`cat.gifv`).
- "Edit" make sens only on text files only. In general (B) "edit"
should not be the default action for most files.
- Though (C) "Edit" should be triggerable by advanced users (unless
we know we should not). Example `foo.zorblax`, `conf.toml`
- (D) "Edit" does not make sens for some filetypes, thus should not be
available (`'png`, `.jpeg`)
Question (E):
- If the default action is X {in edit/view} should the X button be shown ?
Proposition:
- if ipynb:
- default link edit
- no button in toolbar.
- If known type, editable (txt, json, yaml, py, rb):
- default link open edit,
- button in toolbar show view
- if known type not editable: (, png, gif, zip)
- default link open view
- no button in toolbar
- if unknown type ('.zorblax, toml, cson, ')
- default link open "view"
- button in the toolbar show "Edit".
In the future I would like to show the Edit button for notebooks
but have it open them in the text editor. Right now, there isn't
any way for a user to do this. Thus hiding Edit on notebooks for
now.
This removes the showing of the Edit button when:
* We know we can't edit the file (pdf, doc, xls, jpeg, png, etc.)
* Or a notebook - looking at this again though...
When a kernelspec is removed while a kernel spawned from it is in use
the Running tab on the dashboards page errors and no longer shows
any results. Fall back on using the kernel name from the session
in this case so that users can see and terminate kernels.
* Edit notebook opens a notebook, Edit any other file type open it in a
text editor
* View only available for HTML files to disambiguate between “viewing”
a notebook or text file (which is the same as editing it) and viewing
an HTML file
- Cookie-authenticated API requests must use set X-XSRFToken header
- add utils.ajax for making ajax requests, adding xsrf header from default location
1) finish the step allowing the use of es6
- this include some tweak to web pack configuration to speed up
recompile in watch mode (in particular cache sourcemaps).
- enable eslint (error only), on obvious mistakes.
- setup babel to compile to es5 as a target.
2) Make the test pass under Casper that does not always have
`Function.prototype.bind` defined, which we cannot patch only in the
tests.
3) Write an actual shortcut editor that list and allow to modify most of
the command mode shortcut.
The logic to persist the shortcuts is a bit tricky as there are default
keyboard shortcuts, and so when you "unbind" them you need to re-unbind
them at next startup. This does not work for a few shortcut for
technical reasons: `<Esc>`, `<Shift>`, as well as `<Ctrl-Shift-P>` and `<F>`
which register asynchronously, so are not detected as "default"
shortcuts.
Ioannis Papadopoulos
Min RK
Grant Nestor
Kaushik Chaubal
Matthias Bussonnier
Thomas Kluyver
Brian E. Granger
Thomas Kluyver
Peter Parente
Doug Blank
Jinesh Mehta
michaelpacer
alexandercbooth
robnagler
Safia Abdalla
Pierre Gerold
Jonathan Frederic
Jonathan Frederic