Jonathan Frederic
b53386b37b
Ran function comment conversion tool
11 years ago
Jason Grout
3c98127f7c
remove obsolete optimization
11 years ago
Jason Grout
e6a8ef00e0
Catch errors after our then()s, instead of in parallel with them (this missing exceptions)
...
When an error is thrown in a then() success handler, it doesn't call the same then()'s error handler.
I also made all of the utils.reject handlers verbose to aid in debugging.
11 years ago
Jason Grout
efe7098a60
Fix viewlist to use promises correctly
...
A viewlist wasn't getting properly populated before. This also switches the list update to use splice for in-place updates.
11 years ago
Jason Grout
e7065d5a9f
Remove obsolete logic: storing references to child views in a view
...
Users are responsible for keeping track of views they create and removing them in a view's remove() method
11 years ago
Jason Grout
53472ba91b
reimplement the add/remove class logic to not use do_diff and remove do_diff
11 years ago
Jason Grout
1e8b2473b3
Merge branch 'viewlists' of https://github.com/jasongrout/ipython into viewlists
11 years ago
Jason Grout
05d013db59
At least log an error if there is no create or remove defined.
...
We might just remove this...
11 years ago
Jason Grout
bc0cb3c8b5
Do something about do_diff being used for the class stuff in widgets
11 years ago
Jason Grout
88084db35d
Return the viewlist from the update promise so that you can use it immediately.
...
The pattern is:
viewlist.update(new_list).then(function(new_view_list) {
...
})
11 years ago
Jonathan Frederic
d181172948
Implement view logic in selection containers.
11 years ago
Jason Grout
307a320284
tweak documentation for viewlists
11 years ago
Jason Grout
93f658bc9b
Make a copy of the input list so that changes to the children list don't automagically change our reference list
11 years ago
Jason Grout
7658bab99f
Missing semicolon
11 years ago
Jason Grout
a6b901fdd3
Make state_change initialization more conventional
11 years ago
Jason Grout
0164fd32ca
Make error messages more consistent
11 years ago
Jason Grout
88ed50afad
Refactor the do_diff and manual child view lists into a separate ViewList object
11 years ago
Jason Grout
da8cab76dd
Clean up promises code some more.
11 years ago
Jonathan Frederic
f9d730d01e
Address @takluyver 's review comments
11 years ago
Jonathan Frederic
0d591619c6
Make all tests async display safe
11 years ago
Jonathan Frederic
56c5020a84
bool_test passing with slimerjs
11 years ago
Jonathan Frederic
bed3a4cfda
use es6
11 years ago
Jonathan Frederic
8c149c9112
Current state with lots and lots of debugging junk
11 years ago
Jonathan Frederic
b3c49fce66
Move the display Promise into a lower level method,
...
into the create view method of the widget manager.
This makes sure that views created by parent views
are also accounted for in the state/display order
guarantee.
11 years ago
Jonathan Frederic
fed878fed9
Don't throw Errors with Objects as the message/
11 years ago
Jonathan Frederic
bbcd5cb55f
Bug fixes
11 years ago
Jonathan Frederic
3870bb571b
Use rsvp.js for Promises
11 years ago
Jonathan Frederic
c67dcc0dc3
Finished adding error handling.
11 years ago
Jonathan Frederic
1d1572421f
Add a WrappedError class
11 years ago
Jonathan Frederic
b16b2e8749
Make display also pend on set_state.
11 years ago
Jason Grout
a4331a93cc
Fix some this vs. that errors, as well as returning some promises to wait for fulfillment
11 years ago
Jason Grout
8e769a012f
Load the utils module
11 years ago
Jason Grout
686e73dfdf
More simplifications due to promises
11 years ago
Jonathan Frederic
c41dcb35e9
Proxy console.error calls
11 years ago
Jonathan Frederic
5a745be138
Add Promise support to models.
11 years ago
Jonathan Frederic
78c0bbdb4d
Fix view rendering order.
11 years ago
Jonathan Frederic
4beda5d0fb
Initial stab at adding promises to the widget framework.
11 years ago
Sylvain Corlay
604d0bb666
A String is an object
11 years ago
Sylvain Corlay
4b6c753f3f
Dates are JavaScript objects, and _pack_models returns an empty object
11 years ago
Jonathan Frederic
ba77877c18
Rebase fixes
11 years ago
Jonathan Frederic
a68df8a8b1
Address @minrk 's review comments.
11 years ago
Jonathan Frederic
2b5ebb9e8f
Make Python push initial state.
...
Also added initial state push callback.
11 years ago
Jonathan Frederic
79670e8afb
Merge pull request #6494 from takluyver/widget-comm-require
...
Allow widget views to be loaded from require modules
11 years ago
Jonathan Frederic
176529cce2
Make sure DOMWidget _css is set after basic style traits
11 years ago
Thomas Kluyver
590ba19ac3
Clean up some JS code
11 years ago
Thomas Kluyver
1ff846520b
Put callbacks for create_view and create_child_view in options
...
And add errback support
11 years ago
Thomas Kluyver
5953a3f874
Allow widget views to be loaded from require modules
...
This required refactoring things that create widget views to use
callbacks instead of return values.
11 years ago
Jonathan Frederic
60bf0f5b2f
s/apply_update/set_state
11 years ago
Jonathan Frederic
b5195e1b17
Merge pull request #6548 from SylvainCorlay/widget_views_by_id
...
Make WidgetModel.views be an object indexed by view id
11 years ago
sylvain.corlay
60925f0a1a
hasOwnProperty
11 years ago