to measure window height when resizing contents
Sometimes these values differ by a pixel,
we may never know why.
window.innerHeight seems to be larger when they disagree, causing an extra scrollbar to be drawn.
The function in charge of actually converting cursor offset to
CodeMirror line number and character number was actually crashing when
the cursor was at the last character (loop until undefined, then access
length of variable, which is undefined).
This was hiding a bug in which when you would completer to a single
completion pressing tab after as-you-type filtering, the completion
would be completed twice.
The logic that was supposed to detect whether or not all completions had
a common prefix was actually faulty as the common prefix used to be a
string but was then changed to an object. Hence the logic to check
whether or not there was actually a common prefix was always true, even
for empty string, leading to the deletion of the line (replace by '') in
some cases.
Widget.warning('text....') was infinitely sticky in some cases
like content manager raising 'not implemented' on copy.
The make default click_callback to dismiss notification,
and fix the logic to not unbind the click handler if it requests
the notification not to be dismissed.
The approach in #7517 didn't work on Safari
(as in the entire page was invisible).
This is the same mechanism used to size the CodeMirror div on the edit page, and should work more reliably.
Mitigate 7486, could probably be improved, but
treat text as pure text, but assume that when received a dome
element it actually come from a secure source.
Sanitizing all we get, including Dom Element break json-metadata editor
and a few others.
modify toolbar.js to be able to deal with actions.
modify maintoolbar to deal with the new action architecture
add a way to triger notification widget hiding
mainly in navbars, where we were doing custom
things that bootstrap already did with classes.
This did require the removal of multiple class LESS inheritance for
navbar buttons, because it doesn't work properly. Seems like a LESS bug, but I'm not sure.
Min RK
Matthias Bussonnier
Thomas Kluyver
Cedric GESTES
dongweiming
Jonathan Frederic
Nicholas Bollweg (Nick)
Jonathan Frederic