ee76005bc2
More review changes
12 years ago
2d7a4a7879
Some JS test fixes
12 years ago
70ffd96eb9
Added some nice comments,
...
so devs can easily figure out what options to pass
into the objects they want to construct.
12 years ago
d9ab2d203a
In person review with @ellisonbg
12 years ago
1e098560b8
Revert "Google hangout review comments."
...
This reverts commit 4e120e76014b2630f957c01d17ba3926d4848872.
12 years ago
eb2b1ab4a4
Google hangout review comments.
12 years ago
c2c87e1a76
nbconvert api tests fixes
12 years ago
2ba8945cab
Fix all the bugs!
12 years ago
c7961ae2db
Fix imports of "modules",
...
required after converting everything into dictionary returns.
12 years ago
0e9e1dd5a3
MWE,
...
Fixed LOTS of bugs
12 years ago
152e23dc76
Progress...
12 years ago
fb32b6561f
Start of work to make notebook.html requirejs friendly.
12 years ago
2c8a53aca1
Merge pull request #5944 from jdfreder/i5943
...
Markdown rendering bug fix.
12 years ago
d84c8fa863
Fixed mardown rendering bug.
...
The wrong signature of `$()` was being used
wrong: http://api.jquery.com/jQuery/#jQuery1
right: http://api.jquery.com/jQuery/#jQuery2
Instead of implictly calling parseHTML, call it explicitly.
closes #5943
12 years ago
802f74e190
Create ipythongfm mode
12 years ago
5b6b8e2bbf
Why overriding a method if the new one is exactly the same of the one
...
in the base class?
12 years ago
dcf77aa2a0
Hide toolbar of rendered text cells.
12 years ago
d88b2ccc4a
Merge pull request #5310 from ivanov/fix-5238
...
remove raw cell placeholder on focus, closes #5238
12 years ago
2e4036fd4f
raw cell placeholder text as one line
12 years ago
37852baa6d
render on focus out, always pad raw cells
12 years ago
cd38181438
remove raw cell placeholder on focus, closes #5238
12 years ago
b9e448b160
DRY: refactor common keyboard handling to Cell
...
Our edit mode keyboard shortcuts don't distinguish between being in a
code cell or in a text cell, so it makes sense to handle both in one
place. This is a first step in that direction.
12 years ago
bf3ecdb35f
DRY: factor out common handle_keyevent method
...
This method was identical in both CodeCell and TextCell
12 years ago
71d4c427c9
refactor to improve cell switching in edit mode
...
This code was repeated in both CodeCell and TextCell, both of which are
extensions of Cell, so this just unifies the logic in Cell.
TextCell had logic here to check if the cell was rendered or not, but I
don't believe it is possible to end up triggering such a code path.
(Should that be required, I can always just add back these methods to
TextCell, performing the .rendered==True check, and calling the Cell
prior to this, code mirror at_top would only return true on if the
cursor was at the first character of the top line. Now, pressing up
arrow on any character on the top line will take you to the cell above.
The same applies for the bottom line. Pressing down arrow would only go
to the next cell if the cursor was at a location *after* the last
character (something that is only possible to achieve in vim mode if the
last line is empty, for example). Now, down arrow on any character of
the last line will go to the next cell.
12 years ago
8889a7581c
start better keyboard handling
12 years ago
7d87978a66
fix a typo introduced by a rebased PR
...
caused heading cells to appear in both rendered and unrendered state
12 years ago
5f7f1c51ec
remove unused security warning
12 years ago
890c0be1dd
always sanitize markdown
...
don't check if it's safe or not
12 years ago
31c9e08fa8
Don't render insecure Markdown and show warning.
12 years ago
fa3f998295
Adding security.js with 1st attempt at is_safe.
12 years ago
af7dd15181
Removing old keyboard handling from IPython.utils.
12 years ago
15fac2c1d6
make input_area css generic to cells
...
removes otherwise-identical text_cell_input class in text cells
12 years ago
88460cd212
Merge pull request #5175 from jdfreder/html-take2
...
Audit .html() calls take #2
12 years ago
a6f883d7f2
Couple of whiteboard logic implementation misses
12 years ago
9451589e38
implemented whiteboard logic
12 years ago
e847a31348
Always refresh the CM editor upon TextCell unrender.
12 years ago
c7860d8bc8
Post in person review
...
Removed logic for reverse ordered events
Removed almost all of the log statements
Removed list for should unfocus callbacks
Removed all the logic in focus_editor
Only call focus_editor if the keyboard was used to enter edit mode
12 years ago
ef3f61f906
Use set_rendered to set the error msg of the cell.
12 years ago
946212d5fa
Treat set_rendered as unsafe.
12 years ago
6a224d131b
Move todos into set_rendered
12 years ago
ad03225cf6
Audit .html() calls take #2
12 years ago
c888f9d3e4
Cleaning up console log messages.
12 years ago
d83b4ece91
Removing old method on RawCell - just use the base class.
12 years ago
11493ca042
Don't always call focus_cell in Cell.command_mode.
...
The focus_cell should only be called when a user enters
command mode by pressing ESC. Calling focus_cell was causing
jumps when command mode was entered through a mouse click.
12 years ago
b244518871
Special handling for CM's vim keyboard mapping.
12 years ago
0e4c4887aa
TextCell.unrender should not focus CM/select.
12 years ago
b3322fc2d5
Ongoing work on cell splitting.
12 years ago
c1166ea98a
Lots of updates and changes.
...
* Cleaning up the code mirror event handlers.
* Adding logic to prevent calling Notebook.command_mode on cell
focusout.
* Fixing bugs.
12 years ago
40977e545b
Semi working version of basic dual mode UX.
...
As of this point there are lots of things that don't work, but
most of the basic dual mode interactions do work fine.
12 years ago
2a530ff30d
More work on the dual mode UX.
12 years ago
Jonathan Frederic
jon
Min RK
Raffaele De Feo
Paul Ivanov
Brian E. Granger