- replace regexes they were not matching at the end of files.
- hide edit/view for multiple, they where not working
From the Pr comments that should closely match the following
Observations:
- "View" is handled by the browser so in most case it's something
"safe". I think that (A) all items we don't know what to do with
should have the _possibility_ to be viewed. (example `config.yaml`,
`cat.gifv`).
- "Edit" make sens only on text files only. In general (B) "edit"
should not be the default action for most files.
- Though (C) "Edit" should be triggerable by advanced users (unless
we know we should not). Example `foo.zorblax`, `conf.toml`
- (D) "Edit" does not make sens for some filetypes, thus should not be
available (`'png`, `.jpeg`)
Question (E):
- If the default action is X {in edit/view} should the X button be shown ?
Proposition:
- if ipynb:
- default link edit
- no button in toolbar.
- If known type, editable (txt, json, yaml, py, rb):
- default link open edit,
- button in toolbar show view
- if known type not editable: (, png, gif, zip)
- default link open view
- no button in toolbar
- if unknown type ('.zorblax, toml, cson, ')
- default link open "view"
- button in the toolbar show "Edit".
In the future I would like to show the Edit button for notebooks
but have it open them in the text editor. Right now, there isn't
any way for a user to do this. Thus hiding Edit on notebooks for
now.
This removes the showing of the Edit button when:
* We know we can't edit the file (pdf, doc, xls, jpeg, png, etc.)
* Or a notebook - looking at this again though...
When first added, the first item of the list contained the attachment.
After roundtripping to a file, the list was correctly converted to a single string,
the first element of which is a single character, not the full data.
There is a less-than optimal double border between the last button and
the input field.
Remove it by making the left border of the input field None, (or the
right one in RLT layout). We don't change the border of the buton or it
looks ugly when pressed.
Thomas Kluyver
Matthias Bussonnier
Joris Van den Bossche
Brian E. Granger
Vidar Tonaas Fauske
Min RK
Thomas Kluyver
michaelpacer
Grant Nestor
Jason Grout
Tony Cebzanov
Jason Grout