the use of
XX.prototype = new YY();
Does trigger the constructor of YY without the nead for it. `Object.create`
does go around this limitation and target browser that are relatively Old.
Cf https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/create
for more info
It might help to get rid of some logic in constructors that check wether some
options are passed in, that were causing errors on noteboko load. Typically
`if(element){ }` on Abstract `Cell` constructor.
Update to codemirror 4.6 and update most notebook to work wiht it
this include keyevent that where triggerd twice and the re-writing of
ipython-gfm anf ipython mode to work with require.
I consider it a bug that you couldn't merge with heading cells, and that
you couldn't split them, either. (So much so that I thought it was a bug
in ipython-vimception when I ran into it).
This change removes that limitation, so heading cells are on par with
the other cells in terms of the kinds of manipulations one can carry out
with them.
Our edit mode keyboard shortcuts don't distinguish between being in a
code cell or in a text cell, so it makes sense to handle both in one
place. This is a first step in that direction.
This code was repeated in both CodeCell and TextCell, both of which are
extensions of Cell, so this just unifies the logic in Cell.
TextCell had logic here to check if the cell was rendered or not, but I
don't believe it is possible to end up triggering such a code path.
(Should that be required, I can always just add back these methods to
TextCell, performing the .rendered==True check, and calling the Cell
prior to this, code mirror at_top would only return true on if the
cursor was at the first character of the top line. Now, pressing up
arrow on any character on the top line will take you to the cell above.
The same applies for the bottom line. Pressing down arrow would only go
to the next cell if the cursor was at a location *after* the last
character (something that is only possible to achieve in vim mode if the
last line is empty, for example). Now, down arrow on any character of
the last line will go to the next cell.
Thomas Kluyver
Matthias Bussonnier
Min RK
Jessica B. Hamrick
Fernando Perez
Paul Ivanov
Jonathan Frederic
jon
Raffaele De Feo