without this, it is not possible to select any text using the mouse in
the contents of the modal. For example: editing the notebook metadata
JSON you end up just moving the whole box around instead of being able
to select a portion of the JSON using the mouse.
- Cookie-authenticated API requests must use set X-XSRFToken header
- add utils.ajax for making ajax requests, adding xsrf header from default location
See https://bugs.jquery.com/ticket/9841. In our case, the OutputArea was triggering a ‘resize’ event on its element, which was bubbling up and causing this handler to execute every time an output was appended. This was a pretty big drain on output areas that quickly changed (like for interact widgets), presumably since this function involves a DOM read to get heights.
The only real fix is an errant `+` on the final replacement, which would end up skipping sequential replacements.
- leaves trailing `\r` on the text, if there is one
- use groups to avoid unnecessary replace calls (no change)
- includes test
rather than throwing handler errors in the call to `.trigger()`
Extensions can register buggy event handlers.
These should not be able to cause failures in the event-triggering code paths.
This should fix several avenues where extensions (or other bugs) could prevent a notebook from loading.
These are like carriage return, but only affect a character before them
instead of the whole line. I've checked that this makes the output from
'man ls' look OK.
Closes gh-1572
1) finish the step allowing the use of es6
- this include some tweak to web pack configuration to speed up
recompile in watch mode (in particular cache sourcemaps).
- enable eslint (error only), on obvious mistakes.
- setup babel to compile to es5 as a target.
2) Make the test pass under Casper that does not always have
`Function.prototype.bind` defined, which we cannot patch only in the
tests.
3) Write an actual shortcut editor that list and allow to modify most of
the command mode shortcut.
The logic to persist the shortcuts is a bit tricky as there are default
keyboard shortcuts, and so when you "unbind" them you need to re-unbind
them at next startup. This does not work for a few shortcut for
technical reasons: `<Esc>`, `<Shift>`, as well as `<Ctrl-Shift-P>` and `<F>`
which register asynchronously, so are not detected as "default"
shortcuts.
wip add lab page
Add missing source files
Remove unused typings
Clean up tsconfig
No typings are required
Add typescript to dev dependencies
Switch to a JS-only build
Remove unused config file
Remove unused test and cleanup handlers
Update the setup file to build the lab
Use new application plugin from js-plugins
Remove whitespace changes
Bump plugins version
Update to latest plugins
Update to latest plugins
Update to latest jupyter-js-plugins and add files to manifest
Work around bug in css-loader
Update plugins and fix webpack warning
Update lab version
Fix static directory path
Bump plugins version
Add the try jupyter link
Bump dependencies
Back out whitespace changes
Update plugins version
Update dependencies
Update the bootstrap file
Use a standalone template for the lab page
It use the notion of Head/Anchor moving the selection normally move both
the head and the anchor. It is possible to mot move the anchor, for
example by pressing Shift.
Everything in between the head and the anchor (head and anchor included)
is in a "soft-selection" marked with the 'jupyter-soft-selection' class
in CSS.
This then remove completely the notion of marked cell, and thus disallow
discontinuous selection.
Unlike previous implementation the used a thick left border, this use
background gradient with 2 stops at the same position to archived the
same visual effect without the gap in between left border in between
contiguous cells.
For compatibility with previous versions, a few choices have been made.
An extra multi-selected class is added to the body when multiple
cells are selected. This allow to toggle the background to a soft blue
indicating selection. And the Head of the selection is still called the
"selected" cell.
The on_focus event have been reworked as a
click-let-click-release-outside of codemirror was putting the notebook
in undefined state with multiple selected cells, and the head in edit
mode.
Finally Travis now test on edge group, to get faster, which can be
removed in a few weeks as the all infrastructure of Travis will move on
Google Cloud.
In the function remove_shortcut, if the action failed, it used to
throw an 'implementation oriented' exception message:
> throws('try to delete non-leaf')
This is not a good message for the user who wants to mess with the
shortcuts.
The solution is to leave this 'implementation oriented' exception message
and add a try-catch bloc above that catches this message and throws
a new, frendliest, exception message.
I came up with this:
> throws('try to remove non-existing shortcut')
* notebook/static/base/js/keyboard.js: (remove_shortcut) add try-catch.
Signed-off-by: Nicolas Barray <nbarray@gmail.com>
Grant Nestor
Min RK
Thomas Kluyver
samarsultan
Ioannis Papadopoulos
Thomas Kluyver
Tony Cebzanov
Paul Ivanov
Andrew Shaffer
Jason Grout
spoorthyv
Sylvain Corlay
Jonathan
Matthias Bussonnier
Julien Rebetez
Jonathan Frederic
Peter Parente
Matthias Geier
Brian E. Granger
Steven Silvester
Julien Rebetez
Thomas Fors
Safia Abdalla
Josh Barnes
Dave Willmer
Kyle Kelley
Niole Nelson
nsonnad
Nicolas Barray