The function in charge of actually converting cursor offset to
CodeMirror line number and character number was actually crashing when
the cursor was at the last character (loop until undefined, then access
length of variable, which is undefined).
This was hiding a bug in which when you would completer to a single
completion pressing tab after as-you-type filtering, the completion
would be completed twice.
The logic that was supposed to detect whether or not all completions had
a common prefix was actually faulty as the common prefix used to be a
string but was then changed to an object. Hence the logic to check
whether or not there was actually a common prefix was always true, even
for empty string, leading to the deletion of the line (replace by '') in
some cases.
Widget.warning('text....') was infinitely sticky in some cases
like content manager raising 'not implemented' on copy.
The make default click_callback to dismiss notification,
and fix the logic to not unbind the click handler if it requests
the notification not to be dismissed.
while it does improve repaint performance on *some* setups (OS X+Chrome+Low-DPI),
it seems to have no effect on most (OS X+FF, OS X+Chrome+High-DPI, Linux+Chrome),
and the opposite effect on others (Linux+FF).
The approach in #7517 didn't work on Safari
(as in the entire page was invisible).
This is the same mechanism used to size the CodeMirror div on the edit page, and should work more reliably.
Mitigate 7486, could probably be improved, but
treat text as pure text, but assume that when received a dome
element it actually come from a secure source.
Sanitizing all we get, including Dom Element break json-metadata editor
and a few others.
fixes#7355
Also limit the number of query "jump", and use variables.
In particular there was a container width discontinuity at 768 pixel
where below 768 container width is 100% and "only" 720px on wider
screen, making a jump.
So now Css media query have 3 breakpoints:
- <540 px with (aka -no name-)
- colapsed menubar
- vbox for prompt
- 100% width container
- 540 -> 767 (aka -xs- )
- expand menubar
- hbox fro prompt
- 767 -> 991 (aka -sm-)
- show save widget
- fix width (768px)
- 991+ (aka -md-)
- extra save widget info (date time)
- fix with of 991 px.
- 1200+ (aka -lg-)
- widht of 1200px.
of course we've set soem variable wrongly so this is still kinda-a-hack
as we shoudl have pushed the xs-sm limit lower instead of pushing the
nothing-xs limit up but I don't want to "fix it" now.
closes#7409
Mostly a symptome of too many nested div that do different things.
don't try to both have an end space inside and outside the 'document'
area. And don't try to also get the things to be 100viewport height by
hacking around and make them smaller;
set a value to border-radius large, and actually make border radius
small smaller than border radius large.
Make dialog border radius coherent with the rest of the UI.
Matthias Bussonnier
Thomas Kluyver
Min RK
Cedric GESTES
Brian E. Granger
Jonathan Frederic
dongweiming