You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

1156 lines
32 KiB

1 year ago
<?php
/*
** Zabbix
** Copyright (C) 2001-2023 Zabbix SIA
**
** This program is free software; you can redistribute it and/or modify
** it under the terms of the GNU General Public License as published by
** the Free Software Foundation; either version 2 of the License, or
** (at your option) any later version.
**
** This program is distributed in the hope that it will be useful,
** but WITHOUT ANY WARRANTY; without even the implied warranty of
** MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
** GNU General Public License for more details.
**
** You should have received a copy of the GNU General Public License
** along with this program; if not, write to the Free Software
** Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
**/
require_once dirname(__FILE__).'/../../include/CWebTest.php';
require_once dirname(__FILE__).'/../behaviors/CMessageBehavior.php';
require_once dirname(__FILE__).'/../traits/TableTrait.php';
/**
* @backup connector, profiles
*
* @onBefore prepareConnectorsData
*/
class testFormConnectors extends CWebTest {
use TableTrait;
private static $connector_sql = 'SELECT * FROM connector ORDER BY connectorid';
private static $default_connector = 'Default connector';
private static $update_connector = 'Update connector';
private static $delete_connector = 'Delete connector';
/**
* Attach MessageBehavior to the test.
*
* @return array
*/
public function getBehaviors() {
return ['class' => CMessageBehavior::class];
}
public static function prepareConnectorsData() {
CDataHelper::call('connector.create', [
[
'name' => self::$default_connector,
'url' => '{$URL}'
],
[
'name' => self::$update_connector,
'url' => '{$URL}'
],
[
'name' => self::$delete_connector,
'url' => '{$URL}'
]
]);
}
/**
* Check Connector create form layout.
*/
public function testFormConnectors_Layout() {
$default_labels = [
'fields' => ['Name', 'Protocol', 'Data type', 'URL', 'Tag filter', 'HTTP authentication', 'Advanced configuration',
'Max records per message', 'Concurrent sessions', 'Attempts', 'Timeout', 'HTTP proxy', 'SSL verify peer',
'SSL verify host', 'SSL certificate file', 'SSL key file', 'SSL key password', 'Description', 'Enabled'
],
'advanced_fields' => ['Max records per message', 'Concurrent sessions', 'Attempts','Timeout', 'HTTP proxy',
'SSL verify peer', 'SSL verify host', 'SSL certificate file', 'SSL key file', 'SSL key password'
],
'required' => ['Name', 'URL', 'Max records per message', 'Concurrent sessions', 'Attempts', 'Timeout'],
'default' => [
'Data type' => 'Item values',
'Tag filter' => 'And/Or',
'HTTP authentication' => 'None',
'Max records per message' => 'Unlimited',
'Concurrent sessions' => '1',
'Attempts' => '1',
'Timeout' => '5s',
'SSL verify peer' => true,
'SSL verify host' => true,
'Enabled' => true
]
];
$http_auth = [
'None' => [],
'Basic' => ['Username', 'Password'],
'NTLM' => ['Username', 'Password'],
'Kerberos' => ['Username', 'Password'],
'Digest' => ['Username', 'Password'],
'Bearer' => ['Bearer token']
];
$this->page->login()->open('zabbix.php?action=connector.list');
// Check title for create/update form.
$this->query('link', self::$default_connector)->one()->click();
$dialog = COverlayDialogElement::find()->one()->waitUntilReady();
$this->assertEquals('Connector', $dialog->getTitle());
$dialog->close();
$this->query('button:Create connector')->waitUntilClickable()->one()->click();
$form = $dialog->asForm();
$this->assertEquals('New connector', $dialog->getTitle());
// Check advanced configuration default value.
$form->checkValue(['Advanced configuration' => false]);
// Check that the 'Advanced configuration' additional fields are hidden.
foreach ($default_labels['advanced_fields'] as $label) {
$this->assertFalse($form->getLabel($label)->isDisplayed());
}
$form->fill(['Advanced configuration' => true]);
// Check default values.
$form->checkValue($default_labels['default']);
$this->assertEquals('Zabbix Streaming Protocol v1.0', $form->getField('Protocol')->getText());
foreach ($http_auth as $auth => $auth_fields) {
$form->fill(['HTTP authentication' => $auth]);
// Check visible fields.
$this->assertEqualsCanonicalizing(array_merge($default_labels['fields'], $auth_fields),
$form->getLabels(CElementFilter::VISIBLE)->asText()
);
// Check required fields.
$this->assertEqualsCanonicalizing(array_merge($default_labels['required'], ($auth === 'Bearer') ? $auth_fields : []),
$form->getRequiredLabels()
);
// Reset the value of the "HTTP authentication" field to avoid issues with the following checks.
$form->fill(['HTTP authentication' => 'None']);
}
// Check Custom value.
$form->fill(['Max records per message' => 'Custom']);
$this->assertEquals(0, $form->getField('id:max_records')->getValue());
// Check tags table fields.
$tag_filter_table = $form->query('id:tags')->asMultifieldTable()->one();
$tag_filter_table->checkValue([['tag' => '', 'operator' => 'Equals', 'value' => '']]);
// Check that tags table buttons are present.
$this->assertEquals(2, $tag_filter_table->query('button', ['Remove', 'Add'])->all()
->filter(new CElementFilter(CElementFilter::CLICKABLE))->count()
);
// Check tags table dropdown options.
$this->assertSame(['Exists', 'Equals', 'Contains', 'Does not exist', 'Does not equal', 'Does not contain'],
$form->getField('name:tags[0][operator]')->getOptions()->asText()
);
// Check radio buttons and their labels.
$radio_buttons = [
'Data type' => ['Item values', 'Events'],
'Tag filter' => ['And/Or', 'Or'],
'Max records per message' => ['Unlimited', 'Custom']
];
foreach ($radio_buttons as $name => $labels) {
$this->assertEquals($labels, $form->getField($name)->getLabels()->asText());
}
$inputs = [
'Name' => [
'maxlength' => '255'
],
'URL' => [
'maxlength' => '2048'
],
'id:tags_0_tag' => [
'maxlength' => '255',
'placeholder' => 'tag'
],
'id:tags_0_value' => [
'maxlength' => '255',
'placeholder' => 'value'
],
'Bearer token' => [
'maxlength' => '128'
],
'Username' => [
'maxlength' => '255'
],
'Password' => [
'maxlength' => '255'
],
'id:max_records' => [
'maxlength' => '10'
],
'Concurrent sessions' => [
'maxlength' => '3'
],
'Attempts' => [
'maxlength' => '1'
],
'Timeout' => [
'maxlength' => '255'
],
'HTTP proxy' => [
'maxlength' => '255',
'placeholder' => '[protocol://][user[:password]@]proxy.example.com[:port]'
],
'SSL certificate file' => [
'maxlength' => '255'
],
'SSL key file' => [
'maxlength' => '255'
],
'SSL key password' => [
'maxlength' => '64'
],
'Description' => [
'maxlength' => '65535'
]
];
foreach ($inputs as $field => $attributes) {
$this->assertTrue($form->getField($field)->isAttributePresent($attributes));
}
// Check that both 'Cancel' and 'Add' footer buttons are present and clickable.
$this->assertEquals(2, $dialog->getFooter()->query('button', ['Add', 'Cancel'])->all()
->filter(new CElementFilter(CElementFilter::CLICKABLE))->count()
);
$dialog->close();
}
public static function getConnectorsData() {
return [
[
[
'expected' => TEST_BAD,
'fields' => [
'Name' => '',
'URL' => '{$URL}'
],
'error' => [
'Incorrect value for field "name": cannot be empty.'
]
]
],
[
[
'expected' => TEST_BAD,
'fields' => [
'Name' => 'Connector without URL',
'URL' => ''
],
'error' => [
'Incorrect value for field "url": cannot be empty.'
]
]
],
[
[
'expected' => TEST_BAD,
'fields' => [
'Name' => 'Connector with unacceptable URL',
'URL' => 'dns://zabbix.com:82/v1/history'
],
'error' => [
'Invalid parameter "/1/url": unacceptable URL.'
]
]
],
[
[
'expected' => TEST_BAD,
'fields' => [
'Name' => 'Connector with unacceptable URL',
'URL' => 'message://zabbix.com:82/v1/history'
],
'error' => [
'Invalid parameter "/1/url": unacceptable URL.'
]
]
],
[
[
'expected' => TEST_BAD,
'fields' => [
'Name' => 'Connector with unacceptable URL',
'URL' => '?'
],
'error' => [
'Invalid parameter "/1/url": unacceptable URL.'
]
]
],
[
[
'expected' => TEST_BAD,
'fields' => [
'Name' => '',
'URL' => ''
],
'error' => [
'Incorrect value for field "name": cannot be empty.',
'Incorrect value for field "url": cannot be empty.'
]
]
],
[
[
'expected' => TEST_BAD,
'fields' => [
'Name' => 'Empty bearer token',
'URL' => 'https://zabbix.com:82/v1/history',
'HTTP authentication' => 'Bearer'
],
'error' => [
'Incorrect value for field "token": cannot be empty.'
]
]
],
[
[
'expected' => TEST_BAD,
'fields' => [
'Name' => 'Empty bearer token',
'URL' => 'https://zabbix.com:82/v1/history',
'HTTP authentication' => 'Bearer',
'Bearer token' => ' '
],
'error' => [
'Incorrect value for field "token": cannot be empty.'
]
]
],
// Check validation for 'Concurrent sessions' field.
[
[
'expected' => TEST_BAD,
'fields' => [
'Name' => 'Concurrent session check with value that is less than 1',
'URL' => '{$URL}',
'Advanced configuration' => true,
'Concurrent sessions' => '0'
],
'error' => [
'Incorrect value for field "max_senders": value must be no less than "1".'
]
]
],
[
[
'expected' => TEST_BAD,
'fields' => [
'Name' => 'Concurrent session check with empty value',
'URL' => '{$URL}',
'Advanced configuration' => true,
'Concurrent sessions' => ''
],
'error' => [
'Incorrect value "" for "max_senders" field.'
]
]
],
[
[
'expected' => TEST_BAD,
'fields' => [
'Name' => 'Concurrent session check with incorrect value',
'URL' => '{$URL}',
'Advanced configuration' => true,
'Concurrent sessions' => '@'
],
'error' => [
'Incorrect value "@" for "max_senders" field.'
]
]
],
[
[
'expected' => TEST_BAD,
'fields' => [
'Name' => 'Concurrent session check with greater than "100" value',
'URL' => '{$URL}',
'Advanced configuration' => true,
'Concurrent sessions' => '101'
],
'error' => [
'Incorrect value for field "max_senders": value must be no greater than "100".'
]
]
],
// Check validation for 'Attempts' field.
[
[
'expected' => TEST_BAD,
'fields' => [
'Name' => 'Attempts range check',
'URL' => '{$URL}',
'Advanced configuration' => true,
'Attempts' => '0'
],
'error' => [
'Incorrect value for field "max_attempts": value must be no less than "1".'
]
]
],
[
[
'expected' => TEST_BAD,
'fields' => [
'Name' => 'Attempts check with empty value',
'URL' => '{$URL}',
'Advanced configuration' => true,
'Attempts' => ''
],
'error' => [
'Incorrect value "" for "max_attempts" field.'
]
]
],
[
[
'expected' => TEST_BAD,
'fields' => [
'Name' => 'Attempts range check',
'URL' => '{$URL}',
'Advanced configuration' => true,
'Attempts' => '6'
],
'error' => [
'Incorrect value for field "max_attempts": value must be no greater than "5".'
]
]
],
// 'Timeout' field validation checks.
[
[
'expected' => TEST_BAD,
'fields' => [
'Name' => 'Empty timeout field',
'URL' => '{$URL}',
'Advanced configuration' => true,
'Timeout' => ''
],
'error' => [
'Incorrect value for field "timeout": cannot be empty.'
]
]
],
[
[
'expected' => TEST_BAD,
'fields' => [
'Name' => 'Timeout with invalid parameter',
'URL' => '{$URL}',
'Advanced configuration' => true,
'Timeout' => '0'
],
'error' => [
'Invalid parameter "/1/timeout": value must be one of 1-60.'
]
]
],
[
[
'expected' => TEST_BAD,
'fields' => [
'Name' => 'Timeout with invalid parameter',
'URL' => '{$URL}',
'Advanced configuration' => true,
'Timeout' => '61s'
],
'error' => [
'Invalid parameter "/1/timeout": value must be one of 1-60.'
]
]
],
[
[
'expected' => TEST_BAD,
'fields' => [
'Name' => 'Timeout with invalid parameter',
'URL' => '{$URL}',
'Advanced configuration' => true,
'Timeout' => '1h'
],
'error' => [
'Invalid parameter "/1/timeout": value must be one of 1-60.'
]
]
],
[
[
'expected' => TEST_BAD,
'fields' => [
'Name' => 'Timeout with invalid parameter',
'URL' => '{$URL}',
'Advanced configuration' => true,
'Timeout' => STRING_255
],
'error' => [
'Invalid parameter "/1/timeout": a time unit is expected.'
]
]
],
// Tags validation checks.
[
[
'expected' => TEST_BAD,
'fields' => [
'Name' => 'Empty tag name',
'URL' => '{$URL}',
'id:tags_0_tag' => '',
'id:tags_0_value' => 'value'
],
'error' => [
'Invalid parameter "/1/tags/1/tag": cannot be empty.'
]
]
],
[
[
'expected' => TEST_BAD,
'fields' => [
'Name' => 'Empty tag name with gap',
'URL' => '{$URL}',
'id:tags_0_tag' => ' ',
'id:tags_0_value' => 'value'
],
'error' => [
'Invalid parameter "/1/tags/1/tag": cannot be empty.'
]
]
],
[
[
'expected' => TEST_BAD,
'tags' => true,
'fields' => [
'Name' => 'Empty name for second tag',
'URL' => '{$URL}',
'id:tags_0_tag' => 'tag',
'id:tags_0_value' => 'value',
'id:tags_1_tag' => '',
'id:tags_1_value' => 'value'
],
'error' => [
'Invalid parameter "/1/tags/2/tag": cannot be empty.'
]
]
],
[
[
'expected' => TEST_BAD,
'tags' => true,
'fields' => [
'Name' => 'Two identical tags',
'URL' => '{$URL}',
'id:tags_0_tag' => 'tag',
'id:tags_0_value' => 'value',
'id:tags_1_tag' => 'tag',
'id:tags_1_value' => 'value'
],
'error' => [
'Invalid parameter "/1/tags/2": value (tag, operator, value)=(tag, 0, value) already exists.'
]
]
],
// Custom 'Max records per message' validation check.
[
[
'expected' => TEST_BAD,
'fields' => [
'Name' => 'Incorrect value for max records field',
'URL' => '{$URL}',
'Advanced configuration' => true,
'Max records per message' => 'Custom',
'id:max_records' => '2147483648'
],
'error' => [
'Incorrect value "2147483648" for "max_records" field.'
]
]
],
// Checks with multiple errors.
[
[
'expected' => TEST_BAD,
'fields' => [
'Name' => 'Attempts and Concurrent sessions incorrect values',
'URL' => '{$URL}',
'Advanced configuration' => true,
'Concurrent sessions' => '0',
'Attempts' => '0'
],
'error' => [
'Incorrect value for field "max_senders": value must be no less than "1".',
'Incorrect value for field "max_attempts": value must be no less than "1".'
]
]
],
[
[
'expected' => TEST_BAD,
'fields' => [
'Name' => '',
'URL' => '',
'Advanced configuration' => true,
'Max records per message' => 'Custom',
'id:max_records' => '2147483648',
'Concurrent sessions' => '0',
'Attempts' => '6'
],
'error' => [
'Incorrect value for field "name": cannot be empty.',
'Incorrect value for field "url": cannot be empty.',
'Incorrect value "2147483648" for "max_records" field.',
'Incorrect value for field "max_senders": value must be no less than "1".',
'Incorrect value for field "max_attempts": value must be no greater than "5".'
]
]
],
[
[
'expected' => TEST_BAD,
'fields' => [
'Name' => 'Empty bearer token and timeout',
'URL' => '{$URL}',
'Advanced configuration' => true,
'HTTP authentication' => 'Bearer',
'Timeout' => ''
],
'error' => [
'Incorrect value for field "token": cannot be empty.',
'Incorrect value for field "timeout": cannot be empty.'
]
]
],
[
[
'expected' => TEST_GOOD,
'fields' => [
'Name' => 'Simple create with mandatory fields',
'URL' => '{$URL}'
]
]
],
[
[
'expected' => TEST_GOOD,
'fields' => [
'Name' => 'Simple create with changed fields and Basic auth',
'URL' => '{$URL}',
'Data type' => 'Events',
'Tag filter' => 'Or',
'id:tags_0_tag' => 'tag contains',
'name:tags[0][operator]' => 'Contains',
'id:tags_0_value' => 'value',
'HTTP authentication' => 'Basic',
'Username' => 'username',
'Password' => 'password',
'Description' => 'hello world!',
'Enabled' => false
]
]
],
[
[
'expected' => TEST_GOOD,
'fields' => [
'Name' => 'With advanced configuration and long strings',
'URL' => STRING_2048,
'Data type' => 'Item values',
'Tag filter' => 'And/Or',
'id:tags_0_tag' => STRING_255,
'name:tags[0][operator]' => 'Does not contain',
'id:tags_0_value' => STRING_255,
'HTTP authentication' => 'NTLM',
'Username' => STRING_64,
'Password' => STRING_64,
'Advanced configuration' => true,
'id:max_records_mode' => 'Custom',
'id:max_records' => ZBX_MAX_INT32,
'Concurrent sessions' => '100',
'Attempts' => '5',
'Timeout' => '60',
'HTTP proxy' => STRING_255,
'SSL verify peer' => false,
'SSL verify host' => false,
'SSL certificate file' => STRING_255,
'SSL key file' => STRING_255,
'SSL key password' => STRING_64,
'Description' => 'long string check',
'Enabled' => true
]
]
],
[
[
'expected' => TEST_GOOD,
'fields' => [
'Name' => ' Test trailing spaces ',
'URL' => ' {$URL} ',
'Data type' => 'Item values',
'id:tags_0_tag' => ' tag tag ',
'name:tags[0][operator]' => 'Does not contain',
'id:tags_0_value' => ' tag value ',
'HTTP authentication' => 'NTLM',
'Username' => ' {$USERNAME} ',
'Advanced configuration' => true,
'id:max_records_mode' => 'Custom',
'id:max_records' => ' 1 ',
'Concurrent sessions' => ' 1 ',
'Timeout' => ' 60 ',
'HTTP proxy' => ' proxy ',
'SSL certificate file' => ' {$SSL_CERT} ',
'SSL key file' => ' {$SSL_KEY} ',
'Description' => ' trim check '
],
'trim' => ['Name', 'URL', 'id:tags_0_tag', 'id:tags_0_value', 'Username', 'id:max_records',
'Concurrent sessions', 'Timeout', 'HTTP proxy', 'SSL certificate file', 'SSL key file',
'Description'
]
]
],
[
[
'expected' => TEST_GOOD,
'fields' => [
'Name' => 'With advanced configuration and supported macros',
'URL' => '{$URL}',
'id:tags_0_tag' => 'exists',
'name:tags[0][operator]' => 'Exists',
'HTTP authentication' => 'Kerberos',
'Username' => '{$USERNAME}',
'Password' => '{$PASSWORD}',
'Advanced configuration' => true,
'Timeout' => '{$TIMEOUT}',
'HTTP proxy' => '{$PROXY}',
'SSL certificate file' => '{$SSL_CERT}',
'SSL key file' => '{$SSL_KEY}',
'SSL key password' => '{$SSL_PASSWORD}',
'Description' => 'with macros'
]
]
],
[
[
'expected' => TEST_GOOD,
'fields' => [
'Name' => 'Advanced configuration and SSL',
'URL' => '{$URL}',
'id:tags_0_tag' => 'does not exist',
'name:tags[0][operator]' => 'Does not exist',
'HTTP authentication' => 'Digest',
'Username' => '',
'Password' => '',
'Advanced configuration' => true,
'SSL verify peer' => true,
'SSL verify host' => true,
'SSL certificate file' => '/home/zabbix/',
'SSL key file' => 'server.key',
'SSL key password' => 'password',
'Description' => ''
]
]
],
[
[
'expected' => TEST_GOOD,
'fields' => [
'Name' => 'Advanced configuration and one minute timeout',
'URL' => '{$URL}',
'Advanced configuration' => true,
'Timeout' => '1m'
]
]
],
[
[
'expected' => TEST_GOOD,
'fields' => [
'Name' => 'Advanced configuration and 60 seconds timeout',
'URL' => '{$URL}',
'Advanced configuration' => true,
'Timeout' => '60s'
]
]
],
[
[
'expected' => TEST_GOOD,
'fields' => [
'Name' => 'Simple create with changed fields and Bearer token',
'URL' => 'https://zabbix.com:82/v1/events',
'Data type' => 'Events',
'Tag filter' => 'Or',
'id:tags_0_tag' => 'does not equal',
'name:tags[0][operator]' => 'Does not equal',
'id:tags_0_value' => 'value',
'HTTP authentication' => 'Bearer',
'Bearer token' => STRING_128,
'Description' => 'bearer token'
]
]
],
[
[
'expected' => TEST_GOOD,
'fields' => [
'Name' => 'Simple create with changed fields, trim and Bearer macro',
'URL' => 'https://zabbix.com:82/v1/events',
'HTTP authentication' => 'Bearer',
'Bearer token' => ' {$TOKEN} ',
'Description' => 'bearer token'
],
'trim' => ['Bearer token']
]
]
];
}
/**
* @dataProvider getConnectorsData
*/
public function testFormConnectors_Create($data) {
$this->checkConnectorForm($data);
}
public function testFormConnectors_SimpleUpdate() {
$old_hash = CDBHelper::getHash(self::$connector_sql);
$this->page->login()->open('zabbix.php?action=connector.list');
$this->query('link', self::$update_connector)->waitUntilClickable()->one()->click();
COverlayDialogElement::find()->waitUntilReady()->one()->asForm()->submit();
$this->assertMessage(TEST_GOOD, 'Connector updated');
$this->assertEquals($old_hash, CDBHelper::getHash(self::$connector_sql));
}
/**
* @dataProvider getConnectorsData
*/
public function testFormConnectors_Update($data) {
$this->checkConnectorForm($data, true);
}
/**
* Check Connector creation or update form validation and successful submission.
*
* @param boolean $update updating is performed
*/
public function checkConnectorForm($data, $update = false) {
$expected = CTestArrayHelper::get($data, 'expected', TEST_GOOD);
if ($expected === TEST_BAD) {
$old_hash = CDBHelper::getHash(self::$connector_sql);
}
$this->page->login()->open('zabbix.php?action=connector.list');
if ($update) {
$this->query('link', self::$update_connector)->waitUntilClickable()->one()->click();
}
else {
$this->query('button:Create connector')->waitUntilClickable()->one()->click();
}
$dialog = COverlayDialogElement::find()->one()->waitUntilReady();
$form = $dialog->asForm();
// Add a prefix to the name of the Connector in case of update scenario to avoid duplicate names.
if ($update && CTesTArrayHelper::get($data, 'expected', TEST_GOOD) === TEST_GOOD) {
$data['fields']['Name'] = 'Update: '.$data['fields']['Name'];
}
if (array_key_exists('tags', $data)) {
$form->query('xpath://table[@id="tags"]//button[text()="Add"]')->one()->click();
}
$form->fill($data['fields']);
$form->submit();
if ($expected === TEST_BAD) {
$this->assertMessage(TEST_BAD, ($update ? 'Cannot update connector' : 'Cannot create connector'), $data['error']);
$this->assertEquals($old_hash, CDBHelper::getHash(self::$connector_sql));
$dialog->close();
}
else {
$dialog->ensureNotPresent();
// Trim leading and trailing spaces from expected results if necessary.
if (array_key_exists('trim', $data)) {
foreach ($data['trim'] as $field) {
$data['fields'][$field] = trim($data['fields'][$field]);
}
}
$this->assertMessage(TEST_GOOD, ($update ? 'Connector updated' : 'Connector created'));
$this->assertEquals(1, CDBHelper::getCount('SELECT NULL FROM connector WHERE name='.zbx_dbstr($data['fields']['Name'])));
if ($update) {
$this->assertEquals(0, CDBHelper::getCount('SELECT NULL FROM connector WHERE name='.zbx_dbstr(self::$update_connector)));
self::$update_connector = $data['fields']['Name'];
}
$this->query('link', $data['fields']['Name'])->waitUntilClickable()->one()->click();
$form->invalidate();
// Open "Advanced configuration" block if it was filled with data.
if (CTestArrayHelper::get($data, 'fields.Advanced configuration', false)) {
// After form submit "Advanced configuration" is closed.
$form->checkValue(['Advanced configuration' => false]);
$form->fill(['Advanced configuration' => true]);
}
$form->checkValue($data['fields']);
$dialog->close();
}
}
public function getCancellationData() {
return [
[
[
'action' => 'Create'
]
],
[
[
'action' => 'Update',
'name' => self::$default_connector,
'new_values' => [
'Name' => 'New zabbix test connector',
'URL' => 'http://zabbix.com:82/v1/history',
'HTTP authentication' => 'Bearer',
'Bearer token' => STRING_128,
'Advanced configuration' => true,
'SSL verify peer' => false,
'SSL verify host' => false,
'SSL certificate file' => '/home/zabbix/',
'SSL key file' => '{$KEY}',
'SSL key password' => '{$PASSWORD}',
'Description' => 'cancellation of create and update actions',
'Enabled' => false
]
]
],
[
[
'action' => 'Clone',
'name' => self::$default_connector
]
],
[
[
'action' => 'Delete',
'name' => self::$delete_connector,
'alert_message' => 'Delete selected connector?'
]
]
];
}
/**
* Check cancellation of create, update, clone and delete actions.
*
* @dataProvider getCancellationData
*/
public function testFormConnectors_CancelAction($data) {
$old_hash = CDBHelper::getHash(self::$connector_sql);
$this->page->login()->open('zabbix.php?action=connector.list');
$this->query(($data['action'] === 'Create') ? 'button:Create connector' : 'link:'.$data['name'])->one()->click();
$dialog = COverlayDialogElement::find()->waitUntilReady()->one();
$form = $dialog->asForm();
// Fill in data for 'Update' scenario.
if ($data['action'] === 'Update') {
$form->fill($data['new_values']);
}
if ($data['action'] === 'Clone' || ($data['action'] === 'Delete')) {
$dialog->getFooter()->query('button', $data['action'])->one()->click();
// Check alert message and dismiss it.
if ($data['action'] === 'Delete') {
$this->assertEquals($data['alert_message'], $this->page->getAlertText());
$this->page->dismissAlert();
}
}
$dialog->query('button:Cancel')->one()->click();
$dialog->ensureNotPresent();
$this->assertEquals($old_hash, CDBHelper::getHash(self::$connector_sql));
}
public static function getCloneData() {
return [
[
[
'expected' => TEST_GOOD,
'Name' => self::$default_connector
]
],
[
[
'expected' => TEST_BAD,
'Name' => self::$delete_connector,
'error' => [
'Connector "'.self::$delete_connector.'" already exists.'
]
]
]
];
}
/**
* @dataProvider getCloneData
*
* Function for checking connector cloning.
*/
public function testFormConnectors_Clone($data) {
$this->page->login()->open('zabbix.php?action=connector.list');
$this->query('link', $data['Name'])->one()->click();
$form = COverlayDialogElement::find()->waitUntilReady()->asForm()->one();
$values = $form->getValues();
$this->query('button:Clone')->waitUntilClickable()->one()->click();
if (CTestArrayHelper::get($data, 'expected', TEST_GOOD) === TEST_GOOD) {
$new_name = 'Cloned_'.$data['Name'];
$form->invalidate();
$form->fill(['Name' => $new_name]);
$form->submit();
$this->assertMessage(TEST_GOOD, 'Connector created');
$this->assertEquals(1, CDBHelper::getCount('SELECT NULL FROM connector WHERE name='.zbx_dbstr($data['Name'])));
$this->assertEquals(1, CDBHelper::getCount('SELECT NULL FROM connector WHERE name='.zbx_dbstr($new_name)));
$values['Name'] = $new_name;
$this->query('link', $new_name)->one()->click();
$this->assertEquals($values, $form->getValues());
}
else {
$form->submit();
$this->assertMessage(TEST_BAD, 'Cannot create connector', $data['error']);
CMessageElement::find()->one()->close();
$this->assertEquals(1, CDBHelper::getCount('SELECT NULL FROM connector WHERE name='.zbx_dbstr($data['Name'])));
}
COverlayDialogElement::find()->one()->close();
}
public function testFormConnectors_Delete() {
$this->page->login()->open('zabbix.php?action=connector.list');
$this->query('link', self::$delete_connector)->waitUntilClickable()->one()->click();
// Click on the Delete button in the opened Connector configuration dialog.
COverlayDialogElement::find()->waitUntilReady()->one()->query('button:Delete')->waitUntilClickable()->one()->click();
$this->assertEquals('Delete selected connector?', $this->page->getAlertText());
$this->page->acceptAlert();
$this->page->waitUntilReady();
$this->assertMessage(TEST_GOOD, 'Connector deleted');
$this->assertFalse($this->query('link', self::$delete_connector)->one(false)->isValid());
$this->assertEquals(0, CDBHelper::getCount('SELECT NULL FROM connector WHERE name='.zbx_dbstr(self::$delete_connector)));
}
/**
* Modify the URI scheme validation rules and check the result for the URL type in connector form.
*/
public function testFormConnectors_UriScheme() {
$invalid_schemes = ['dns://zabbix.com', 'message://zabbix.com'];
$default_valid_schemes = ['http://zabbix.com', 'https://zabbix.com', 'ftp://zabbix.com', 'file://zabbix.com',
'mailto://zabbix.com', 'tel://zabbix.com', 'ssh://zabbix.com'
];
$this->page->login()->open('zabbix.php?action=connector.list');
$this->query('link', self::$default_connector)->one()->click();
$dialog = COverlayDialogElement::find()->one()->waitUntilReady();
$form = $dialog->asForm();
$dialog->close();
// Check default URI scheme rules: http, https, ftp, file, mailto, tel, ssh.
$this->assertUriScheme($form, $default_valid_schemes);
$this->assertUriScheme($form, $invalid_schemes, TEST_BAD);
// Change valid URI schemes on "Other configuration parameters" page.
$this->page->open('zabbix.php?action=miscconfig.edit');
$config_form = $this->query('name:otherForm')->asForm()->waitUntilVisible()->one();
$config_form->fill(['Valid URI schemes' => 'dns,message']);
$config_form->submit();
$this->assertMessage(TEST_GOOD, 'Configuration updated');
$this->page->open('zabbix.php?action=connector.list');
$this->assertUriScheme($form, $default_valid_schemes, TEST_BAD);
$this->assertUriScheme($form, $invalid_schemes);
// Disable URI scheme validation.
$this->page->open('zabbix.php?action=miscconfig.edit')->waitUntilReady();
$config_form->fill(['Validate URI schemes' => false]);
$config_form->submit();
$this->assertMessage(TEST_GOOD, 'Configuration updated');
$this->page->open('zabbix.php?action=connector.list');
$this->assertUriScheme($form, array_merge($default_valid_schemes, $invalid_schemes));
}
/**
* Fill in the URL field to check the URI scheme validation rules.
*
* @param CFormElement $form form element of connector
* @param array $data url field data
* @param string $expected expected result after connector form submit, TEST_GOOD or TEST_BAD
*/
private function assertUriScheme($form, $data, $expected = TEST_GOOD) {
$this->query('link', self::$default_connector)->one()->click();
foreach ($data as $scheme) {
$form->fill(['URL' => $scheme]);
$form->submit();
$message = CMessageElement::find()->one();
if ($expected === TEST_GOOD) {
$this->assertMessage(TEST_GOOD, 'Connector updated');
$message->close();
$this->query('link', self::$default_connector)->one()->click();
}
else {
$this->assertMessage(TEST_BAD, 'Cannot update connector', 'Invalid parameter "/1/url": unacceptable URL.');
$message->close();
}
}
COverlayDialogElement::find()->one()->close();
}
}