Do not activate lab-extension if no notebook tracker

pull/6294/head
Jeremy Tuloup 5 years ago
parent be90da20f1
commit 02fbb294ca

@ -73,15 +73,17 @@ class ClassicButton
const openClassic: JupyterFrontEndPlugin<void> = {
id: '@jupyterlab-classic/lab-extension:open-classic',
autoStart: true,
requires: [INotebookTracker],
optional: [ICommandPalette, IMainMenu],
optional: [INotebookTracker, ICommandPalette, IMainMenu],
activate: (
app: JupyterFrontEnd,
notebookTracker: INotebookTracker,
palette: ICommandPalette | null,
menu: IMainMenu | null
) => {
// TODO: do not activate if already in a IClassicShell
// TODO: do not activate if already in a IClassicShell?
if (!notebookTracker) {
return;
}
const { commands, docRegistry, shell } = app;
const baseUrl = PageConfig.getBaseUrl();

Loading…
Cancel
Save