From 1c47294bcf927a6ae88fe5a3cdaa67f41cd5cb42 Mon Sep 17 00:00:00 2001 From: Min RK Date: Mon, 14 Sep 2015 14:45:21 +0200 Subject: [PATCH] catch errors in app_initialized callbacks avoids bad custom.js preventing initialization. --- notebook/static/notebook/js/main.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/notebook/static/notebook/js/main.js b/notebook/static/notebook/js/main.js index 4ef118597..7dd4bb2a7 100644 --- a/notebook/static/notebook/js/main.js +++ b/notebook/static/notebook/js/main.js @@ -154,8 +154,11 @@ require([ IPython.keyboard_manager = keyboard_manager; IPython.save_widget = save_widget; IPython.tooltip = notebook.tooltip; - - events.trigger('app_initialized.NotebookApp'); + try { + events.trigger('app_initialized.NotebookApp'); + } catch (e) { + console.error("Error in app_initialized callback", e); + } utils.load_extensions_from_config(config_section); utils.load_extensions_from_config(common_config); notebook.load_notebook(common_options.notebook_path);