From 2c239b591baef2dc1a52cd73c3fb5f1830f742bf Mon Sep 17 00:00:00 2001 From: Joshua Zeltser Date: Tue, 25 Jun 2019 16:50:31 +0100 Subject: [PATCH] changed way translation functions called for non string literals --- notebook/static/tree/js/notebooklist.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/notebook/static/tree/js/notebooklist.js b/notebook/static/tree/js/notebooklist.js index f13e6fb9a..6b0b2a645 100644 --- a/notebook/static/tree/js/notebooklist.js +++ b/notebook/static/tree/js/notebooklist.js @@ -814,10 +814,14 @@ define([ //#issue 3961, update the checkbox aria-label when it changed if(selected.length>=1){ if($('#select-all').prop("checked")){ - $('#button-select-all').attr("aria-label", i18n.msg._("Selected All "+ selected.length+" items")); + // $('#button-select-all').attr("aria-label", i18n.msg._("Selected All "+ selected.length +" items")); + var msg1 = i18n.msg._("Selected All %d items") + $('#button-select-all').attr("aria-label", i18n.msg.sprintf(msg1, selected.length)); } else{ - $('#button-select-all').attr("aria-label", i18n.msg._("Selected, "+ selected.length+" items")); + // $('#button-select-all').attr("aria-label", i18n.msg._("Selected, "+ selected.length+" items")); + var msg2 = i18n.msg._("Selected, %d items") + $('#button-select-all').attr("aria-label", i18n.msg.sprintf(msg2, selected.length)); } } else{