From 05c1f6feb8e220e6f5a0f1df92593f6b5e909e7e Mon Sep 17 00:00:00 2001 From: Vidar Tonaas Fauske Date: Mon, 7 Aug 2017 14:38:05 +0200 Subject: [PATCH 1/2] Add buffers argument to comm open/close --- notebook/static/services/kernels/comm.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/notebook/static/services/kernels/comm.js b/notebook/static/services/kernels/comm.js index f75186608..c8021ee2e 100644 --- a/notebook/static/services/kernels/comm.js +++ b/notebook/static/services/kernels/comm.js @@ -147,13 +147,13 @@ define([ }; // methods for sending messages - Comm.prototype.open = function (data, callbacks, metadata) { + Comm.prototype.open = function (data, callbacks, metadata, buffers) { var content = { comm_id : this.comm_id, target_name : this.target_name, data : data || {}, }; - return this.kernel.send_shell_message("comm_open", content, callbacks, metadata); + return this.kernel.send_shell_message("comm_open", content, callbacks, metadata, buffers); }; Comm.prototype.send = function (data, callbacks, metadata, buffers) { @@ -163,13 +163,13 @@ define([ }; return this.kernel.send_shell_message("comm_msg", content, callbacks, metadata, buffers); }; - - Comm.prototype.close = function (data, callbacks, metadata) { + + Comm.prototype.close = function (data, callbacks, metadata, buffers) { var content = { comm_id : this.comm_id, data : data || {}, }; - return this.kernel.send_shell_message("comm_close", content, callbacks, metadata); + return this.kernel.send_shell_message("comm_close", content, callbacks, metadata, buffers); }; // methods for registering callbacks for incoming messages From 9249ae25e110ea84f27a1c4108ad17077904f6cb Mon Sep 17 00:00:00 2001 From: Vidar Tonaas Fauske Date: Mon, 7 Aug 2017 17:53:59 +0200 Subject: [PATCH 2/2] Add buffers argument to CommManager.new_comm --- notebook/static/services/kernels/comm.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/notebook/static/services/kernels/comm.js b/notebook/static/services/kernels/comm.js index c8021ee2e..cba0ac71c 100644 --- a/notebook/static/services/kernels/comm.js +++ b/notebook/static/services/kernels/comm.js @@ -30,8 +30,8 @@ define([ kernel.register_iopub_handler(msg_type, $.proxy(this[msg_type], this)); } }; - - CommManager.prototype.new_comm = function (target_name, data, callbacks, metadata, comm_id) { + + CommManager.prototype.new_comm = function (target_name, data, callbacks, metadata, comm_id, buffers) { /** * Create a new Comm, register it, and open its Kernel-side counterpart * Mimics the auto-registration in `Comm.__init__` in the Jupyter Comm. @@ -40,7 +40,7 @@ define([ */ var comm = new Comm(target_name, comm_id); this.register_comm(comm); - comm.open(data, callbacks, metadata); + comm.open(data, callbacks, metadata, buffers); return comm; };