Make a copy of the input list so that changes to the children list don't automagically change our reference list

12 years ago · 93f658bc9b
parent 7658bab99f
commit 93f658bc9b
1 changed files with 2 additions and 1 deletions
--- a/IPython/html/static/widgets/js/widget.js
+++ b/IPython/html/static/widgets/js/widget.js
@ -643,7 +643,8 @@ define(["widgets/js/manager",
                for (; i < new_models.length; i++) {
                    added_views.push(create.call(context, new_models[i]));
                }
-                that._models = new_models;
+                // make a copy of the input array
+                that._models = new_models.slice();
                return Promise.all(added_views, function(added) {
                    that.views = that.views.slice(0,first_removed).concat(added);
                });