From c7c815a68ac94e0a3bd5c98fd414db9a8331b14a Mon Sep 17 00:00:00 2001 From: PHaeJin Date: Sat, 18 Nov 2017 21:17:52 -0800 Subject: [PATCH 1/4] Fix some broken links --- notebook/static/notebook/js/outputarea.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/notebook/static/notebook/js/outputarea.js b/notebook/static/notebook/js/outputarea.js index b91681a74..219cee29f 100644 --- a/notebook/static/notebook/js/outputarea.js +++ b/notebook/static/notebook/js/outputarea.js @@ -114,7 +114,7 @@ define([ if (threshold <=0) { return false; } - // line-height from http://stackoverflow.com/questions/1185151 + // line-height from https://stackoverflow.com/questions/1185151 var fontSize = this.element.css('font-size') || '14px'; var lineHeight = Math.floor((parseFloat(fontSize.replace('px','')) || 14) * 1.3); return (this.element.height() > threshold * lineHeight); @@ -399,7 +399,7 @@ define([ // Once the iframe is loaded, the subarea is dynamically inserted iframe.on('load', function() { // Workaround needed by Firefox, to properly render svg inside - // iframes, see http://stackoverflow.com/questions/10177190/ + // iframes, see https://stackoverflow.com/questions/10177190/ // svg-dynamically-added-to-iframe-does-not-render-correctly this.contentDocument.open(); From c3ebd135bc2468555b06218486c31f2f5492da7c Mon Sep 17 00:00:00 2001 From: PHaeJin Date: Sat, 18 Nov 2017 21:23:11 -0800 Subject: [PATCH 2/4] Fix a broken link --- notebook/static/notebook/js/textcell.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/notebook/static/notebook/js/textcell.js b/notebook/static/notebook/js/textcell.js index bc58ed5f4..965938d32 100644 --- a/notebook/static/notebook/js/textcell.js +++ b/notebook/static/notebook/js/textcell.js @@ -491,7 +491,7 @@ define([ // The dragleave event is fired when we hover a child element (which // is often immediatly after we got the dragenter), so we keep track // of the number of dragenter/dragleave we got, as discussed here : - // http://stackoverflow.com/q/7110353/116067 + // https://stackoverflow.com/q/7110353/116067 // This doesn't seem to be 100% reliable, so we clear the dropzone // class when the cell is rendered as well this.code_mirror.on("dragenter", function(cm, evt) { From 2c6ed87a63955f0aec422760d285b216b231787b Mon Sep 17 00:00:00 2001 From: PHaeJin Date: Sat, 18 Nov 2017 21:26:33 -0800 Subject: [PATCH 3/4] Fix broken link --- notebook/static/notebook/js/quickhelp.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/notebook/static/notebook/js/quickhelp.js b/notebook/static/notebook/js/quickhelp.js index 6d41ba620..85724992e 100644 --- a/notebook/static/notebook/js/quickhelp.js +++ b/notebook/static/notebook/js/quickhelp.js @@ -80,7 +80,7 @@ define([ var mac_humanize_map = { // all these are unicode, will probably display badly on anything except macs. // these are the standard symbol that are used in MacOS native menus - // cf http://apple.stackexchange.com/questions/55727/ + // cf https://apple.stackexchange.com/questions/55727/ // for htmlentities and/or unicode value 'cmd':'⌘', 'shift':'⇧', From 1119ae146781f3659d24ca5dc7099a9cec19d028 Mon Sep 17 00:00:00 2001 From: PHaeJin Date: Sat, 18 Nov 2017 21:28:02 -0800 Subject: [PATCH 4/4] Fix typo --- notebook/static/notebook/js/actions.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/notebook/static/notebook/js/actions.js b/notebook/static/notebook/js/actions.js index f9fcfcbb1..3b4fe8ba4 100644 --- a/notebook/static/notebook/js/actions.js +++ b/notebook/static/notebook/js/actions.js @@ -949,7 +949,7 @@ define([ ActionHandler.prototype.get_name = function(name_or_data){ /** - * given an `action` or `name` of a action, return the name attached to this action. + * given an `action` or `name` of an action, return the name attached to this action. * if given the name of and corresponding actions does not exist in registry, return `null`. **/