From b5ab71a6bd05b70ceaef0116206d5cc66906ce20 Mon Sep 17 00:00:00 2001 From: Jeremy Tuloup Date: Wed, 17 Dec 2025 08:02:28 +0100 Subject: [PATCH] Minimize prod builds --- app/package.json | 1 + app/rspack.prod.config.js | 2 +- app/rspack.prod.release.config.js | 14 ++++++++++++++ pyproject.toml | 4 ++-- 4 files changed, 18 insertions(+), 3 deletions(-) create mode 100644 app/rspack.prod.release.config.js diff --git a/app/package.json b/app/package.json index 99265ba1b..10a8af984 100644 --- a/app/package.json +++ b/app/package.json @@ -5,6 +5,7 @@ "scripts": { "build": "rspack", "build:prod": "rspack --config ./rspack.prod.config.js", + "build:prod:release": "rspack --config ./rspack.prod.release.config.js", "clean": "rimraf build && jlpm run clean:static", "clean:static": "rimraf -g \"../notebook/static/!(favicons)\"", "watch": "rspack --watch --config rspack.config.js" diff --git a/app/rspack.prod.config.js b/app/rspack.prod.config.js index a010b88b1..5e92669a2 100644 --- a/app/rspack.prod.config.js +++ b/app/rspack.prod.config.js @@ -16,7 +16,7 @@ config[0] = merge(config[0], { filename: '[name].[contenthash].js?v=[contenthash]', }, optimization: { - minimize: false, + minimize: true, }, plugins: [ new WPPlugin.JSONLicenseWebpackPlugin({ diff --git a/app/rspack.prod.release.config.js b/app/rspack.prod.release.config.js new file mode 100644 index 000000000..fcba47391 --- /dev/null +++ b/app/rspack.prod.release.config.js @@ -0,0 +1,14 @@ +/* + * Copyright (c) Jupyter Development Team. + * Distributed under the terms of the Modified BSD License. + */ + +const merge = require('webpack-merge').default; +const config = require('./rspack.prod.config'); + +config[0] = merge(config[0], { + // Turn off source maps + devtool: false, +}); + +module.exports = config; diff --git a/pyproject.toml b/pyproject.toml index 1fe6f082a..4d18bb080 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -166,7 +166,7 @@ ensured-targets = [ install-pre-commit-hook = true [tool.hatch.build.hooks.jupyter-builder.build-kwargs] -build_cmd = "build:prod" +build_cmd = "build:prod:release" source_dir = "packages" build_dir = "notebook/static" npm = ["jlpm"] @@ -189,7 +189,7 @@ before-bump-version = [ ] before-build-npm = [ "jlpm clean", - "jlpm build:prod" + "jlpm build:prod:release" ] before-build-python = [ "jlpm clean"