From c219ce43c1ea25123fa70d264e7735bdf4585b1e Mon Sep 17 00:00:00 2001 From: Steven Silvester Date: Tue, 15 Mar 2022 10:42:52 -0500 Subject: [PATCH] Merge pull request from GHSA-m87f-39q9-6f55 --- notebook/log.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/notebook/log.py b/notebook/log.py index eb246bc40..f7e393770 100644 --- a/notebook/log.py +++ b/notebook/log.py @@ -44,11 +44,15 @@ def log_request(handler, log=access_log, log_json=False): ns['referer'] = request.headers.get('Referer', 'None') msg = msg + ' referer={referer}' if status >= 500 and status != 502: - # log all headers if it caused an error + # Log a subset of the headers if it caused an error. + headers = {} + for header in ['Host', 'Accept', 'Referer', 'User-Agent']: + if header in request.headers: + headers[header] = request.headers[header] if log_json: - log_method("", extra=dict(props=dict(request.headers))) + log_method("", extra=dict(props=headers)) else: - log_method(json.dumps(dict(request.headers), indent=2)) + log_method(json.dumps(dict(headers), indent=2)) if log_json: log_method("", extra=dict(props=ns)) else: