Remove viewport workaround in the UI tests (#6887)

* Remove viewport workaround in the UI tests

* Update viewport

* Fix handling of kernel ready

* Bump to 600

* Update ui-tests/test/mobile.spec.ts
pull/7187/head
Jeremy Tuloup 2 years ago committed by GitHub
parent 728807f401
commit c2ca209ab8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -9,7 +9,7 @@ import { test } from './fixtures';
import { hideAddCellButton, waitForKernelReady } from './utils';
test.use({ autoGoto: false });
test.use({ autoGoto: false, viewport: { width: 524, height: 800 } });
test.describe('Mobile', () => {
test('The layout should be more compact on the file browser page', async ({
@ -18,10 +18,6 @@ test.describe('Mobile', () => {
}) => {
await page.goto(`tree/${tmpPath}`);
// temporary workaround to trigger a toolbar resize
// TODO: investigate in https://github.com/jupyter/notebook/issues/6553
await page.setViewportSize({ width: 524, height: 800 });
await page.waitForSelector('#top-panel-wrapper', { state: 'hidden' });
expect(await page.screenshot()).toMatchSnapshot('tree.png');
@ -42,10 +38,6 @@ test.describe('Mobile', () => {
// wait for the kernel status animations to be finished
await waitForKernelReady(page);
// temporary workaround to trigger a toolbar resize
// TODO: investigate in https://github.com/jupyter/notebook/issues/6553
await page.setViewportSize({ width: 524, height: 800 });
// force switching back to command mode to avoid capturing the cursor in the screenshot
await page.evaluate(async () => {
await window.jupyterapp.commands.execute('notebook:enter-command-mode');

@ -32,7 +32,9 @@ export async function waitForKernelReady(
}, true);
return finished;
});
await page.waitForSelector('.jp-DebuggerBugButton[aria-disabled="false"]');
if (page.viewportSize()?.width > 600) {
await page.waitForSelector('.jp-DebuggerBugButton[aria-disabled="false"]');
}
}
/**

Loading…
Cancel
Save