Merge pull request #5968 from kevin-bates/skip-terminal-test-win-3.9

Skip terminal tests on Windows 3.9+ (temporary)

.github/workflows/python.yml

@@ -11,7 +11,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu, macos, windows]
-        python-version: [ '3.6' , '3.7', '3.8', '3.9' ] # Windows 3.9 fails due to the pywinpty dependency not working
+        python-version: [ '3.6' , '3.7', '3.8', '3.9' ] # Windows 3.9 fails due to the pywinpty dependency not working (Issue #5967)
     steps:
     - name: Checkout
       uses: actions/checkout@v1

notebook/conftest.py

@@ -0,0 +1,10 @@
+
+import pytest
+
+import sys
+
+# TODO: Remove this hook once Issue #5967 is resolved.
+def pytest_ignore_collect(path):
+    if str(path).endswith("test_terminals_api.py"):
+        if sys.platform.startswith('win') and sys.version_info >= (3, 9):
+            return True  # do not collect