From 17ee541add8ee1aef4d1cb2531452b22050fc0a0 Mon Sep 17 00:00:00 2001 From: Min RK Date: Sat, 28 Feb 2015 15:10:48 -0800 Subject: [PATCH] actually catch failure to load widget state load callback was called directly, rather than in promise function that catches errors --- IPython/html/static/widgets/js/manager.js | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/IPython/html/static/widgets/js/manager.js b/IPython/html/static/widgets/js/manager.js index d1bcd6161..4cf7a05b9 100644 --- a/IPython/html/static/widgets/js/manager.js +++ b/IPython/html/static/widgets/js/manager.js @@ -33,7 +33,9 @@ define([ // registered. var that = this; if (WidgetManager._load_callback) { - Promise.resolve(WidgetManager._load_callback.call(this)).then(function(state) { + Promise.resolve().then(function () { + return WidgetManager._load_callback.call(that); + }).then(function(state) { that.set_state(state); }).catch(utils.reject('Error loading widget manager state', true)); } @@ -95,7 +97,9 @@ define([ // Use the load callback to immediately load widget states. WidgetManager._managers.forEach(function(manager) { if (load_callback) { - Promise.resolve(load_callback.call(manager)).then(function(state) { + Promise.resolve().then(function () { + return load_callback.call(manager); + }).then(function(state) { manager.set_state(state); }).catch(utils.reject('Error loading widget manager state', true)); }