Mark thread as daemon in a way that Python 2 supports

10 years ago · ce3dd80391
parent c1a2a26551
commit ce3dd80391
1 changed files with 2 additions and 1 deletions
--- a/notebook/tests/launchnotebook.py
+++ b/notebook/tests/launchnotebook.py
@ -115,7 +115,8 @@ class NotebookTestBase(TestCase):
                # set the event, so failure to start doesn't cause a hang
                started.set()
                app.session_manager.close()
-        cls.notebook_thread = Thread(target=start_thread, daemon=True)
+        cls.notebook_thread = Thread(target=start_thread)
+        cls.notebook_thread.daemon = True
        cls.notebook_thread.start()
        started.wait()
        cls.wait_until_alive()