monkeyking

Commit Graph

Author	SHA1	Message	Date
pgajdos	fdf14b4ab3	run tests with pytest	5 years ago
Matt Riedemann	67ad5a1c06	Merge remote-tracking branch 'origin/master' into 5798-json-logging	5 years ago
Sai Rahul Poruri	9dd2af27de	CLN : Remove utf8 coding cookies On Python 3, the default source file encoding for Python files is utf-8 and because Python 2 is no longer supported, the utf8 coding cookies can be removed	5 years ago
Matt Riedemann	1929fb53b8	Add support for JSON formatted logs This adds a new extra package dependency on `json-logging` and an environment variable, which when set to "true" regardless of case, will try to use the json-logging non-web app log formatter. If the `json-logging` package is not installed but the environment variable is True, something like this will be logged but it will not crash the application: ``` $ ENABLE_JSON_LOGGING=true jupyter notebook Unable to use json logging due to missing packages. Run "pip install notebook[json-logging]" to fix. Traceback (most recent call last): File "/home/osboxes/jupyter/notebook/notebook/notebookapp.py", line 144, in <module> import json_logging ModuleNotFoundError: No module named 'json_logging' ``` Initially I tried to add a new Bool config option to toggle this but the problem is (from my limited understanding of traitlets and tornado) is that `_log_formatter_cls` needs to be set early and trying to se the log formatter later in `init_logging` is too late - or at least I couldn't figure out a way to reset the log formatter dynamically (I tried calling `_log_format_changed` [1] but that didn't work). With this working you get logs like this: ``` {"written_at": "2020-10-07T21:10:51.606Z", "written_ts": 1602105051606265000, "msg": "404 GET /nbextensions/widgets/notebook/js/extension.js (127.0.0.1) 9.26ms referer=http://localhost:8888/notebooks/Untitled.ipynb", "type": "log", "logger": "NotebookApp", "thread": "MainThread", "level": "WARNING", "module": "log", "line_no": 49} {"written_at": "2020-10-07T21:10:54.443Z", "written_ts": 1602105054443309000, "msg": "Starting buffering for f260ddd7-938c-42d0-ac3b-455bea76694f:49f30b53fc4b4ec6a8f2fb748a171613", "type": "log", "logger": "NotebookApp", "thread": "MainThread", "level": "INFO", "module": "kernelmanager", "line_no": 222} {"written_at": "2020-10-07T21:10:54.446Z", "written_ts": 1602105054446264000, "msg": "Kernel shutdown: f260ddd7-938c-42d0-ac3b-455bea76694f", "type": "log", "logger": "NotebookApp", "thread": "MainThread", "level": "INFO", "module": "multikernelmanager", "line_no": 201} ``` An obvious improvement here would to be able to split the `msg` fields apart so that we can log things like response status code, request method, request URL, response_time_ms etc. That should be possible with the `JSONLogWebFormatter` from `json-logging` but when I tried using that I was getting errors from the library about a correlation id (which is based on a request header we don't use). The `json-logging` library supports several web frameworks like Flask but unfortunately does not have built in support for Tornado, but it does support custom formatters so that might be a follow up option to improve on this. [1] https://github.com/ipython/traitlets/blob/4.3.3/traitlets/config/application.py#L195 Closes #5798	5 years ago
Tomas Hrnciar	cdb103c3f0	Add sphinx_rtd_theme to documentation dependencies in setup.py Fixes: #5781	5 years ago
Kevin Bates	73e6c27369	Prevent inclusion of requests_unixsocket on Windows (#5650 ) * Prevent inclusion of requests_unixsocket on Windows * lazily import Co-authored-by: Steven Silvester <stslve@amazon.com>	6 years ago
Kevin Bates	681497fb7b	Release 6.1.0	6 years ago
Remi Rampin	617f7468fe	Implement password hashing with bcrypt (#3793 ) * Use bcrypt for notebook.auth.security * Add bcrypt to install_requires * Add test for bcrypt * Switch to argon2-cffi	6 years ago
Kevin Bates	e866120cff	Add python 3.8, begin testing 3.9-dev	6 years ago
Vidar Tonaas Fauske	7bf9b5ec68	Document contents chunks (#5508 ) * Document contents chunks Add a documentation entry for the contents API regarding use of "chunk" in save. Adds an `extra_requires` value in setup.py for installing documentation dependencies.	6 years ago
Kevin Bates	84b7b854b6	Apply review comments, revert interval validation, bump terminado to 0.8.3	6 years ago
Kris Wilson	a9ed339d58	Add UNIX socket support to notebook server.	6 years ago
Kevin Bates	499740b4bb	Bump minimum version of jupyter_core (#5170 ) Since there's a 6.0.3 release brewin', I thought we should bump the minimum version of jupyter_core from 4.6.0 to 4.6.1. The latter has an edge case to the slew of secure_write issues that would be very annoying if NB 6.0.3 didn't upgrade to that version. The edge case is to tolerate the owner-execute bit on the connection file, which occurs when RUNTIME_DIR resides on certain filesystem types (e.g., CIFS).	6 years ago
Thomas Kluyver	e53383ceb2	Allow testing with nbconvert 6 again (unpin) Closes gh-5086 Closes gh-5092	6 years ago
Thomas Kluyver	f377abfa04	Pin nbconvert <6 for now	6 years ago
Luciano Resende	13039db1a6	Move license information from COPYING.md Closes #4765 Fixes 2768	6 years ago
Kevin Bates	55e93b9ffe	Update core and client dependencies (#4959 )	6 years ago
Jason Grout	9b597a9091	Notebook 6 supports only Python 3.5 or later, not Python 3.4. (#4875 )	6 years ago
Sylvain Corlay	3ae4fae322	Update jupyter_client	7 years ago
Johan Mabille	93304180d7	Bumped the required version of jupyter_client	7 years ago
Min RK	3d94b517e8	require Python 3.5 3.4 doesn't have isawaitable remove unsupported combinations from test matrix	7 years ago
Min RK	729183b148	use our own maybe_future instead of the monkeypatch we did to keep the backport patch small requiring tornado 5 simplifies things a ton because tornado.concurrent.Future is asyncio.Future	7 years ago
Min RK	57122409b2	unpin tornado to get testing 6.0 again	7 years ago
Thomas Kluyver	9035cb1bdd	Limit to tornado <6 for now Tornado 6.0a1 is causing test failures in CI	7 years ago
Min RK	5711075f0b	Merge pull request #3789 from munkm/pytest modify contributing instructions to use pytest for testing	7 years ago
Steven Silvester	26ec5952a7	Merge pull request #3926 from Carreau/drop-27 Drop 2.7	7 years ago
Matthias Bussonnier	37f9a41948	Drop 2.7	7 years ago
Matthias Bussonnier	d239839e07	Build js translation at build time. Make sure they are included in sdist/wheel.	7 years ago
Madicken Munk	f9d578ee40	add pytest to test env requirements and suggest it in contributing docs	8 years ago
Madicken Munk	f2499f3713	adding selenium to test requirements	8 years ago
Thomas Kluyver	7f1bba613d	Check 'Host' header for local connections	8 years ago
Min RK	19188568c9	Merge pull request #3490 from yuvipanda/prometheus-intro Add a /metrics endpoint for Prometheus Metrics	8 years ago
Thomas Kluyver	7bfa3d03bd	"Require" pyzmq>=17 Not really a requirement, but explaining about the pyzmq/tornado incompatibility gets old fast. Closes gh-3579	8 years ago
yuvipanda	a764f90b14	Add a /metrics endpoint for Prometheus Metrics [Prometheus](https://prometheus.io/) provides a standard metrics format that can be collected and used in many contexts. - From the browser to drive 'current resource usage' displays, such as https://github.com/yuvipanda/nbresuse - From a prometheus server to collect historical data for operational analysis and performance monitoring Example: https://grafana.mybinder.org/dashboard/db/1-overview?refresh=1m&orgId=1 for mybinder.org metrics from JupyterHub and BinderHub, via prometheus server at https://prometheus.mybinder.org The JupyterHub and BinderHub projects already expose Prometheus metrics natively. Adding this to the Jupyter notebook server allows us to instrument the code easily and in a standard format that has lots of 3rd party tooling for it. This commit does the following: - Introduce the `prometheus_client` library as a dependency. This library has no dependencies of its own and is pure python. - Add an authenticated `/metrics` endpoint to the server, which returns metrics in Prometheus Text Format - Expose the default process metrics from `prometheus_client`, which include memory usage and CPU usage info (for just the notebook process)	8 years ago
Thomas Kluyver	aa9c977880	Testing with Selenium & Sauce labs (#3321 ) * Initial selenium test * Try configuring Travis to run selenium tests on Sauce * Encryption key needs to be for my account, not jupyter * Install selenium on Travis * Get more data from server info file * Set cwd when launching notebook server Will this help on Travis? * Use JUPYTER_TEST_BROWSER=chrome to test with Chrome * Debugging test * Separate fixtures into conftest.py * Try with --Cls.a=b option syntax * Try using sauce labs directly, not through Travis proxy * Back to using proxy, with http instead of https Idea from https://stackoverflow.com/questions/48236104/ssl-errors-using- sauce-labs-in-travis-ci-with-selenium-webriver-tests-django-pr * Specify browserName in desired_capabilities for Sauce * Try connecting to Sauce for only some jobs in matrix * Exclude selenium tests from regular test run * Remove redundant JS test for dashboard navigation (converted to Selenium) * Re-enable other tests * Exclude selenium tests on Appveyor * Later browser versions are available on Windows * Try running tests with Firefox 57 instead of 58 * Try running with local Firefox on Travis * Install geckodriver for Selenium tests * Untar the right version of geckodriver * Try stepping back one version of Firefox again	8 years ago
Thomas Kluyver	6f6dc28e0e	Always use setuptools in setup.py This copies what we've already done for some other packages: always use setuptools but disable its implicit egg building which causes so many headaches. The setup code can be significantly simpler if it's not trying to handle the case where setuptools isn't in use.	8 years ago
Thomas Kluyver	3f035c5ba9	Bump jupyter_client dependency to 5.2	8 years ago
Thomas Kluyver	3eb6d72bb5	Find available kernelspecs more efficiently Closes gh-3135	8 years ago
Steven Silvester	7b8759fafb	Add support for terminals on Windows (#3087 ) * Add support for terminals on Windows * Bump terminado requirement * Fix handling of default shell * Fix appveyor syntax * Fix requires syntax * Fix version target * Clean up handling of default shell and update version check * Always require terminado * Clean up appveyor test * Make the terminado warning uniform * Default to powershell on Windows * Clean up terminado verison	8 years ago
Thomas Kluyver	059c2b77fc	Switch to jupyter_core implementation of ensure_dir_exists Closes gh-2858 Requires jupyter_core 4.4.0, which I just released.	8 years ago
Min RK	aa461d9e06	Merge pull request #1968 from takluyver/delete-to-trash Send files to OS trash mechanism on delete	8 years ago
Vidar Tonaas Fauske	522fcf403c	Add nbval to docs tests	9 years ago
Thomas Kluyver	1849b80287	Merge branch 'master' into delete-to-trash	9 years ago
Min RK	8a644a9794	restore r.js-based build system from 4.x	9 years ago
Thomas Kluyver	ad3ab9b8c7	Send files to OS trash mechanism on delete This adds a config option, defaulting to use trash, and adds a dependency on the pure-Python 'send2trash' package. Linux, Mac and Windows should all be supported. Alternatively, we could make it default to hard delete (the current behaviour), and let users opt in to trash behaviour. Then Send2Trash could be a soft dependency. This doesn't touch the UI yet, so you still get a confirmation dialog which inaccurately says it will 'permanently delete' the file. If we want to do this, we'll need some way for the contents manager to pass the UI a hint about whether deleting is permanent or not. Closes gh-165	9 years ago
Adam Chainz	a947025308	Convert readthedocs links for their .org -> .io migration for hosted projects As per [their blog post of the 27th April](https://blog.readthedocs.com/securing-subdomains/) ‘Securing subdomains’: > Starting today, Read the Docs will start hosting projects from subdomains on the domain readthedocs.io, instead of on readthedocs.org. This change addresses some security concerns around site cookies while hosting user generated data on the same domain as our dashboard. Test Plan: Manually visited all the links I’ve modified.	9 years ago
Min RK	f707b78e54	exclude terminal tests on Windows	9 years ago
Peter Parente	de7753402b	Cleanup CLI naming Based on first review by @minrk * bundlerextension for consistency * Move CLI entry point into bundler package * Add bundler/__main__.py (c) Copyright IBM Corp. 2016	10 years ago
Peter Parente	8fb670904b	First pass migrating from jupyter_cms * Change handler for consistency with nbconvert * Change bundler function API to take ContentManager models * Change CLI to work as jupyter bundler * Change UI to fit into existing template / JS structure (c) Copyright IBM Corp. 2016	10 years ago
Sylvain Corlay	a91af4d642	Update traitlets API	10 years ago

1 2 3 4 5

230 Commits (6.1.x)