95 Commits (05a9b02bb7243481fdbdfaac2c17dfd815d2d70c)

Author	SHA1	Message	Date
Kevin Bates	6e9256b064	Culling: ensure last_activity attr exists before use (#5355) ... KernelManager's last_activity attribute is added following the instance's creation. Culling (independently) uses this attribute and should ensure it exists prior to its use, else skip the culling check for that instance. Fixes #5345	6 years ago
Pinar Kavak	8c063c2a61	Added notebook name to the logs	6 years ago
Kevin Bates	1fc9bc0b72	Add comments indicating when dependency check can be removed	6 years ago
Kevin Bates	53d4d08813	Fix detection of unsupported config, prevent async on 3.5	6 years ago
Kevin Bates	99b0afd16e	Apply changes per review ... Add comments and rename self.super to self.pinned_superclass to clarify intent. Add run_sync() util method to clean up shutdown_all() invocation.	6 years ago
Kevin Bates	72d44c58cf	Switch class hierarchy to not use mixin base ... This commit uses the approach used in jupyter_server #191 first proposed by David Brochart. This reduces code duplication and alleviates redundancy relative to configurable options. Also, the startup message now includes the version information. Co-authored-by: David Brochart <david.brochart@gmail.com>	6 years ago
Kevin Bates	788bb0ebe0	Update all coroutine/yield methods to async/await, share another method	6 years ago
Kevin Bates	570986282e	Move duplicated methods to mixin, fix mixin order	6 years ago
Kevin Bates	8a4beb0d15	Convert to async/await and apply touch ups	6 years ago
Kevin Bates	7abd4bee27	Indicate that async kernel management is configured	6 years ago
Kevin Bates	3226b07345	Add support for AsyncMappingKernelManager ... Supports running against incompatible jupyter_client so long as the desired kernel_manager_class is not `AsyncMappingKernelManager`.	6 years ago
Kevin Bates	677ccc3d7a	Refactor buffering, culling and activity monitoring into classes ... Use composition in preparation for AsyncMappingKernelManager.	6 years ago
sasaki takeru	dcef16a5be	typo (#4946)	7 years ago
Sylvain Corlay	10318a9827	Merge pull request #4672 from JohanMabille/control ... Added control channel to ZMQChannelsHandler	7 years ago
Min RK	efc0f0089e	Allow ?no_track_activity=1 to opt-out of activity tracking (#4235) ... * Don't track API requests with `?no_track_activity=1` in the activity counter allows external idle-culling scripts to avoid updating the activity counter * Don't track kernel shutdown as kernel activity this causes idle-kernel shutdowns to restart the idle-shutdown timer user-requested shutdowns will still be tracked as api activity * test ?no_track_activity=1 tracking * Changelog for activity	7 years ago
Johan Mabille	61ae2d6778	Added control channel to ZMQChannelsHandler	7 years ago
Min RK	e908edf171	Fix return value for async restart_kernel ... gen.Return shouldn't be passed the Future, the future should be awaited	7 years ago
Min RK	729183b148	use our own maybe_future ... instead of the monkeypatch we did to keep the backport patch small requiring tornado 5 simplifies things a ton because tornado.concurrent.Future is asyncio.Future	7 years ago
Min RK	bba82ca3bd	Merge pull request #4412 from kevin-bates/async-startup ... Enable restart_kernel for async usage	7 years ago
Kevin Bates	2c526fb60b	Enable restart_kernel for async usage ... Converted `MappingKernelManager.restart_kernel` to a coroutine so that projects that take advantage of async kernel startup can also realize appropriate behavior relative to restarts.	7 years ago
Kevin Bates	acba19033b	Minimize handlers and manager methods ... Eliminated the Kernel and Kernelspec handlers. The Websocket (ZMQ) channels handler still remains. This required turning a few methods into coroutines in the Notebook server. Renamed the Gateway config object to GatewayClient in case we want to extend NB server (probably jupyter_server at that point) with Gateway server functionality - so an NB server could be a Gateway client or a server depending on launch settings. Add code to _replace_ the channels handler rather than rely on position within the handlers lists. Updated mock-gateway to return the appropriate form of results. Updated the session manager tests to use a sync ioloop to call the now async manager methods.	7 years ago
Sylvain Corlay	4a7151448c	Enable kernel message filtering	8 years ago
Min RK	b663bf1b14	Merge pull request #4034 from Carreau/adaptation-log ... When adapting also log the version jupyter_client is expecting.	8 years ago
Kevin Bates	23e74dcdfa	Include status types when logging activity ... Recently I needed to troubleshoot kernel responses and found it helpful to distinguish status types (busy vs. idle) - thought others might find it useful as well. Entries that previously appeared as... ``` activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status activity on 33383dcc-c054-4dc0-b842-16063ea160fe: execute_input activity on 33383dcc-c054-4dc0-b842-16063ea160fe: display_data activity on 33383dcc-c054-4dc0-b842-16063ea160fe: execute_result activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status ``` will now appear as... ``` activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status (idle) activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status (busy) activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status (idle) activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status (busy) activity on 33383dcc-c054-4dc0-b842-16063ea160fe: execute_input activity on 33383dcc-c054-4dc0-b842-16063ea160fe: display_data activity on 33383dcc-c054-4dc0-b842-16063ea160fe: execute_result activity on 33383dcc-c054-4dc0-b842-16063ea160fe: status (idle) ```	8 years ago
Maxim Vov	f2fdbf929e	Added metrics for number of kernels running labeled by type	8 years ago
Matthias Bussonnier	96cb061e7b	More descriptive message.	8 years ago
Matthias Bussonnier	7e140c5baf	When adapting also log the version jupyter_client is expecting. ... It's still (IMHO) unclear how the adaptation goes. Like does "adapting to protocol X.Y.Z." mean the end-result is X.Y.Z or what you got is X.Y.Z and it's X.Y.W after adaptation.	8 years ago
Kevin Bates	2d688f2071	Prevent access through 'NoneType' when closing activity_stream ... Although I'm unable to reproduce the issue, its a safe change to prevent an AttributeError from occuring ('NoneType' object has no attribute 'close'). The user that reported this is attempting to launch a kernel and I believe the launch only partially completed such that `kernel._activity_stream` did not get established. (This occurred from Jupyter Enterprise Gateway where we deal with remote kernel launches across resource-managed clusters, so things are a bit more involved relative to kernel establishment.)	8 years ago
Min RK	a53d2c8489	flush iopub before sending restarting/dead status messages ... to ensure (approximately) that all messages from the stopped kernel are delivered before the dead/restarting message	8 years ago
M Pacer	c6dd032bf8	add kernel_info_timeout traitlet to wait for slow kernel startups ... This affects both the MappingKernelManager and the ZMQChannelsHandler(by extension). This allows one setting to apply to both startup andrestarting.	8 years ago
Kevin Bates	550120906c	Fix leak of iopub object in activity monitoring ... After analyzing various leaked items when running either Notebook or Jupyter Kernel Gateway, one item that recurred across each kernel startup and shutdown sequence was the a zmq socket instance associated with the iopub port. The leaked instance occurs because the activity monitor and normal port creation logic both call `create_iopub`. Although this ens up creating a _wrapper_ around the same port, the object (i.e., wrapper) created by the activity monitor is leaked. By setting the kernel manager's `_activity_stream` member to `None` when the kernel is shutdown, cleanup of the iopub wrapper object will take place.	8 years ago
Min RK	f77e3435cf	tornado 5 fixes in tests ... - start asyncio loop explicitly in notebook thread (tornado 4 starts per-thread loops automatically, asyncio doesn’t) - remove unsupported ‘io_loop=‘ arg in websocket test application runs fine with tornado 5, just a few test bits needed updating	8 years ago
Min RK	a2f72da17f	Merge pull request #2963 from takluyver/shutdown-no-kernels ... Config option to shut down server after N seconds with no kernels	9 years ago
Min RK	1deb0aec16	tornado 5: PeriodicCallback loop arg will be removed (#3034) ... * tornado 5: PeriodicCallback loop arg will be removed PCs are always run with the current eventloop, which is what the explicitly passed loop always is for us already * Don't double-close socket & stream closing stream closes the socket * remove now-inaccurate comment	9 years ago
Thomas Kluyver	bfe012e507	Merge pull request #2910 from mheilman/cull_idle_timeout_minimum ... change cull_idle_timeout_minimum to 1 from 300	9 years ago
Thomas Kluyver	9ec57bfdf5	Config option to shut down server after N seconds with no kernels	9 years ago
Michael Heilman	b31194dfe3	removed extraneous cull_idle_timeout_minimum	9 years ago
Michael Heilman	f8ef573592	added warning about culling kernels with poor network connections	9 years ago
Min RK	e4186c47c0	allow disabling offline message buffering ... escape hatch if the new buffering is causing anyone trouble	9 years ago
Michael Heilman	241c7e162c	change cull_idle_timeout_minimum to 1 from 500	9 years ago
Kyle Kelley	43a97807fc	buffer messages when websocket connection is interrupted (#2871) ... * provide some top level comments * implement buffering of messages on last dropped connection - buffer is per-kernel - session_key is stored because only a single session can resume the buffer and we can't be sure - on any new connection to a kernel, buffer is flushed. If session_key matches, it is replayed. Otherwise, it is discarded. - buffer is an unbounded list for now * restore actual zmq channels when resuming connection rather than establishing new connections fixes failure to resume shell channel * hookup restart callbacks in open instead of in `create_stream`, which is not called on reconnect * improve handling of restored connections in js - dismiss 'connection lost' dialog on reconnect - set busy status on reconnect (if not busy, idle will come soon after via kernel_ready)	9 years ago
Min RK	962c5ccd80	stop using `@json_handlers`	9 years ago
dhirschf	6bb89b717a	Workaround for Windows Containers ... On Windows `os.stat` treats host mapped volumes as broken symlinks	9 years ago
Peter Parente	c8ba55da21	Do not cull connected kernels by default	9 years ago
Peter Parente	85ba2bdabd	Fix help for cull_connected and cull_busy	9 years ago
Peter Parente	d9b4c99180	Do not cull kernels doing work by default	9 years ago
Peter Parente	1550a04848	Add cull_busy, cull_connected options ... Additional logic to support culling or skipping kernels that are busy or that have connections.	9 years ago
Min RK	f4d2c246d5	use dedicated Session for activity monitor ... instead of re-using kernel.session, which can cause hash collisions if other objects use `kernel.session`.	9 years ago
Thomas Kluyver	05979d9a4b	Merge pull request #2368 from minrk/stream-data-rate-boogaloo ... only consider stream outputs for data-rate limit	9 years ago
Min RK	3d7c9b51a6	only consider stream outputs for data-rate limit	9 years ago